Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datahub: Fix organisation search with special chars #737

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Datahub: Fix organisation search with special chars #737

merged 3 commits into from
Dec 20, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Dec 20, 2023

PR handles special characters without spacing in organisation search (like in l'éducation)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

Affected libs: common-fixtures, api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, feature-editor, ui-search, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Dec 20, 2023 •
edited
Loading

Coverage Status

coverage: 82.98% (-2.7%) from 85.644%
when pulling e6cefa1 on fix-org-search
into 95f0151 on main.

Angi-Kinas
Angi-Kinas approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

I only found a minor typo :)

libs/feature/catalog/src/lib/organisations/organisations.component.spec.ts Outdated Show resolved Hide resolved
libs/feature/catalog/src/lib/organisations/organisations.component.spec.ts Outdated Show resolved Hide resolved
@tkohr tkohr merged commit c9e78c3 into main Dec 20, 2023
7 checks passed
@tkohr tkohr deleted the fix-org-search branch December 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkohr @coveralls @Angi-Kinas @fgravin