-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IGN] [Datahub] Add markdown support on metadata-info component #733
Comments
I completely agree on using Markdown as the format for rich text fields (abstract, lineage etc.). Currently the Datahub has a very simplistic approach, it will render the content of the abstract as HTML, so if there are HTML tags in it they will show up correctly. One thing that I was considering was to convert all HTML tags to Markdown at some point in the process, and have the metadata page simply render Markdown and not worry about the rest. Other formatting languages can include RST but this is too elaborate, and I think Markdown is the right compromise as a common language. |
I did this feature, if i can contribute somehow. I created a new ui-elements component to parse markdown content. Do i need some specific rights to push a new branch ? (or maybe should i fork the project ?) |
Please fork the project and open a Pull Request through Github, then a reviewer can examine your contribution and give you feedback. Thank you very much! Also, please note that this change is not trivial since simply switching to MD instead of rendering HTML will break the appearance of many records that rely on HTML-based content (which the datahub currently handles). |
Thanks for your feedback, i will fork the project and open a pull request soon (today or in january after holidays). From what i've tested, marked can take markdown and html content as input:
The thing that can change, is the way we handle styling. |
Thanks for the clarification, it sounds like
(basically everything that the basic syntax allows, see https://www.markdownguide.org/basic-syntax/) That should be enough to have a basic layout showing up. |
I see, it makes more sense this way. |
Hi, another feature i'd like to introduce.
We are going to use markdown as our metadata formatted text language (only the descriptive part).
So we need somehow to implement a markdown parser like marked to render markdown content as html.
Here is the kind of result i achieved to get.
Before:
Before:
It can be an optional setting in the toml file settings. And maybe extend it to others formatted text language ?
The text was updated successfully, but these errors were encountered: