-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(DH): Center bbox extent with different coordinate reference system #698
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, well done!! I've made a few suggestions to improve the OL imports and simplify the code, address as you see fit!
...on/components/data-import-validation-map-panel/data-import-validation-map-panel.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/dataviz/src/lib/geo-table-view/geo-table-view.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/feature/dataviz/src/lib/geo-table-view/geo-table-view.component.spec.ts
Outdated
Show resolved
Hide resolved
0804eb0
to
a543ee3
Compare
a543ee3
to
c86b1c0
Compare
c86b1c0
to
efa9686
Compare
e3bc6dd
to
2f19b52
Compare
2f19b52
to
320c8b0
Compare
This PR fixes the bug that occurs if the extent of the feature is in a different coordinate system than WGS84 (EPSG: 4326). In this case the entire world was used as extent. Now we transform the coordinate system and use the bbox of the feature.
In order to do this, we had to update openlayers to version 8.2.0 and adapt a few types.