Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(DH): Center bbox extent with different coordinate reference system #698

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

This PR fixes the bug that occurs if the extent of the feature is in a different coordinate system than WGS84 (EPSG: 4326). In this case the entire world was used as extent. Now we transform the coordinate system and use the bbox of the feature.
In order to do this, we had to update openlayers to version 8.2.0 and adapt a few types.

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Affected libs: feature-dataviz, feature-record, feature-router, feature-map, data-access-datafeeder, api-metadata-converter, feature-search, feature-editor, api-repository, feature-catalog, feature-auth, ui-search, util-data-fetcher, data-access-gn4, util-app-config, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-map, common-domain, ui-dataviz, ui-layout, util-i18n,
Affected apps: datafeeder, metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, well done!! I've made a few suggestions to improve the OL imports and simplify the code, address as you see fit!

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 83.83% (+0.02%) from 83.812%
when pulling 320c8b0 on DH-fix-map-centering
into 0dd0958 on main.

@Angi-Kinas Angi-Kinas force-pushed the DH-fix-map-centering branch from a543ee3 to c86b1c0 Compare December 4, 2023 12:59
@Angi-Kinas Angi-Kinas force-pushed the DH-fix-map-centering branch from c86b1c0 to efa9686 Compare December 5, 2023 14:32
@cmoinier cmoinier force-pushed the DH-fix-map-centering branch 3 times, most recently from e3bc6dd to 2f19b52 Compare December 7, 2023 16:11
@cmoinier cmoinier force-pushed the DH-fix-map-centering branch from 2f19b52 to 320c8b0 Compare December 7, 2023 16:19
@Angi-Kinas Angi-Kinas merged commit 6d4aec4 into main Dec 7, 2023
8 checks passed
@jahow jahow deleted the DH-fix-map-centering branch January 11, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants