-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub: Improve lineage display #684
Conversation
Affected libs:
|
8c4a548
to
d87aca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think the url-detecting regex needs to have stronger test to avoid any regressions. Detecting URL is a tricky topic!
I've added a list of urls to test the regex agains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests! The E2E tests are failing on main
, you can either merge like that or wait for #704 to be merged and rebase.
12fef76
to
a44eb0f
Compare
Hum, after rebasing, I still had to re-run the e2e tests three times to pass. They randomly broke on two different tests before, that I could not reproduce locally. Once it was |
These tests ring a bell, we had issues with them with @cmoinier. Thanks for reporting this! |
The goal of this PR is to resolve #682 by making the linkify directive include trailing
/
in URL if present.The line break in #682 actually comes from GN that returns
Données Chambre d'agriculture des Hauts-de-France https://hautsdefrance.chambre-agriculture.fr/\nBD TOPO. 2020-11
within thelineageObject
.