DH/Bug : Links format filter filters out everything #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
jahow
reviewed
Oct 30, 2023
There was a problem hiding this comment.
Thanks for the fix! I see two things here:
- The unit tests (
downloads-list.component.spec.ts) would probably be a better place to test this behaviour; it looks like thetoggleFilterFormatmethod is not actually tested there, so this looks like a good time to add tests for it 🙂 Kudos for adding an associated test though!
(Note that you can of course keep the e2e test as well) - Nested ternary operations usually only make sense for their author; it's surprisingly hard to read for anyone else. I for one would really appreciate if you could instead define an intermediate variable like
bool noActiveFormat😉
|
I added a commit addressing my own comments, will merge once everything is green |
jahow
pushed a commit
that referenced
this pull request
Nov 13, 2023
chore(dh): add e2e test feat(downloads): clarify logic, add unit tests Backported from #668
|
backported in 67c862f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the behavior of the downloads filter.
Issue
When clicking on one filter and clicking again on it, the download list becomes empty.
Fix
When clicking on one filter and clicking again on it, the download list falls back to 'All' and shows all download links.
How to test
Go to a dataset with download links with multiple formats, eg :
/dataset/ee965118-2416-4d48-b07e-bbc696f002c2, and click twice on the same format filter in the downloads section.