-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix [datahub]: Display external viewer button correctly #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it works well on mobile too ?
Thanks you 🙏
Affected libs:
|
Ah, I forgot mobile, I'll have a look |
template allows truncate in dropdown within flex layout, without cutting outlines
fa83aac
to
adeabd3
Compare
I've added the Independent of this PR the For |
<gn-ui-dropdown-selector | ||
class="truncate p-1 -mx-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that this does anything; for me the dropdown button already has a truncate built-in if the width is too low for the text to show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, strangely this is necessary, because of the flex I added in the parent.
when title switches to flex-col display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I wish we could understand why this kind of class is needed outside of the component (it should be able to decide its own size correctly), but I looked and couldn't find any reason so, let's go with this.
Thanks @tkohr!
Fixes the external viewer button display while allowing truncating long values in the dropdown select.