feat(editor): Filter by current org #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs: ``,
|
Angi-Kinas
force-pushed
the
ME-records-from-org
branch
from
42f84f6 to
4169baa
Compare
cmoinier
requested changes
Sep 14, 2023
| @@ -39,7 +41,7 @@ | |||
| <a | |||
| class="menu-item" | |||
| routerLink="/records/my-library" | |||
| routerLinkActive | |||
| routerLinkActive="btn-active" | |||
There was a problem hiding this comment.
Very good idea, navigation looks clearer now 👍
| { | ||
| provide: SearchService, | ||
| useClass: searchServiceMock, | ||
| }, |
There was a problem hiding this comment.
I think we need a test for the new functionnality!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we will be able to filter the records by the current organisation of the authenticated user.
Additionally the highlighting of the active menu item is re-implemented here.
Right now the table is empty, because the organisation name is empty:
