Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata-editor : Sorting catalog #608

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Metadata-editor : Sorting catalog #608

merged 3 commits into from
Sep 11, 2023

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Sep 5, 2023

Issue

Sort different columns of the catalog.

Rules:

  • By clicking on a column header, records can be sorted in ascending/descending order; the title header should appear with an up/down arrow if sorting is active
  • The records can be sorted up/down by title, author (alphabetically) and last update time by clicking on the respective header
  • Style the button

Screenshot

image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search, ui-inputs, feature-editor,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier marked this pull request as ready for review September 8, 2023 15:22
@cmoinier cmoinier requested a review from jahow September 8, 2023 15:35
@jahow
Copy link
Collaborator

jahow commented Sep 9, 2023

Thanks for all the improvements @cmoinier. I've added a commit to better handle icons in buttons (so that they don't grow vertically), and also used that opportunity to migrate to symbols outlined. I've also added a story for the RecordTable component, so that we can test it in storybook.

@coveralls
Copy link

coveralls commented Sep 9, 2023

Coverage Status

coverage: 82.394% (-3.4%) from 85.775% when pulling 19a5b34 on ME/sorting into f46783c on main.

This commit makes icons showing up better by default inside buttons, by
not making the button grow vertically.
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that you can merge whenever you feel it's ready 🙂

@cmoinier cmoinier merged commit 7a84a5b into main Sep 11, 2023
5 checks passed
@cmoinier cmoinier deleted the ME/sorting branch September 11, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants