-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata-editor/ Pagination #603
Conversation
Affected libs:
|
9c71e78
to
555f687
Compare
GitHub Pages links:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/metadata-editor/src/app/dashboard/dashboard-page.component.html
Outdated
Show resolved
Hide resolved
libs/ui/elements/src/lib/pagination-buttons/pagination-buttons.component.css
Outdated
Show resolved
Hide resolved
libs/ui/elements/src/lib/pagination-buttons/pagination-buttons.component.html
Outdated
Show resolved
Hide resolved
libs/ui/elements/src/lib/pagination-buttons/pagination-buttons.component.ts
Outdated
Show resolved
Hide resolved
….component.html Co-authored-by: Olivia Guyot <[email protected]>
….component.ts Co-authored-by: Olivia Guyot <[email protected]>
Thanks for the review :) I made the changes and added some e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! thanks for addressing everything 🙂 and for the e2e tests!
Issue
As a user, I want to be able to look through all available search results by selecting a different page.
Rules:
- First page
- "..." separator
- Two previous pages
- Current page
- Two following pages
- "..." separator
- Final page
Screenshot