Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata-editor/ Pagination #603

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Metadata-editor/ Pagination #603

merged 4 commits into from
Sep 1, 2023

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Aug 31, 2023

Issue

As a user, I want to be able to look through all available search results by selecting a different page.

Rules:

  • The pagination component should be visible at the bottom of the search results list
  • The pagination component should be composed of a list of clickable page numbers:
    - First page
    - "..." separator
    - Two previous pages
    - Current page
    - Two following pages
    - "..." separator
    - Final page
  • Left and right arrow should be shown as buttons before and after the page numbers, and respectively change the current page by substracting/adding 1
  • These arrow should appear as disabled if their respective action is not possible
  • The current page number should be highlighted and not clickable
  • Clicking on a page number immediately refresh the results list

Screenshot

Screenshot from 2023-08-31 12-27-26

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Aug 31, 2023

Coverage Status

coverage: 85.634% (+1.4%) from 84.227% when pulling 795c316 on EDIT-14-pagination into a7c25ec on main.

@cmoinier cmoinier changed the title Edit 14 pagination Metadata-editor/ Pagination Aug 31, 2023
@cmoinier cmoinier requested a review from jahow August 31, 2023 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

GitHub Pages links:

  • (Documentation)[https://geonetwork.github.io/geonetwork-ui/EDIT-14-pagination/docs/]
  • (Demo & web components)[https://geonetwork.github.io/geonetwork-ui/EDIT-14-pagination/demo/]
  • (UI components storybook)[https://geonetwork.github.io/geonetwork-ui/EDIT-14-pagination/storybook/demo/]

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work! I noticed that when on the first page, too many pages were shown:
image

Instead on the last page it only shows the 3 last pages:
image

Also added a few comments, and I think you can get rid of all the CSS classes. 🙂

@cmoinier cmoinier requested a review from jahow September 1, 2023 07:32
@cmoinier
Copy link
Collaborator Author

cmoinier commented Sep 1, 2023

Thanks for the review :) I made the changes and added some e2e tests.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! thanks for addressing everything 🙂 and for the e2e tests!

@cmoinier cmoinier merged commit 421a373 into main Sep 1, 2023
5 checks passed
@jahow jahow deleted the EDIT-14-pagination branch September 8, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants