Add wider support for GeoNetwork 4.2.x version #595
Conversation
|
Affected libs:
|
jahow
force-pushed
the
gn-42x-compatiblity
branch
from
cb1bca7
to
6425370
Compare
There was a problem hiding this comment.
The dump has been slightly adjusted because some settings were present in the database but are not supposed to be there in GN 4.2.2 This meant a potential migration to 4.2.3 would fail.
| @@ -126,7 +126,9 @@ services: | |||
| init: | |||
| image: alpine/curl | |||
| # only run init if volumes were cleared | |||
| command: sh -c "if [ ! -f /done ]; then run-parts /docker-entrypoint.d; else echo 'Nothing to do.'; exit 0; fi" | |||
| command: sh -c "if [ ! -f /done ]; then run-parts /docker-entrypoint.d --exit-on-error; else echo 'Nothing to do.'; exit 0; fi" | |||
There was a problem hiding this comment.
This change was simply to make sure that the init sequence would stop if any step fails.
|
I can't seem to get the GN 4.2.5 docker image to run currently, so I'll leave that out for now. |
jahow
force-pushed
the
gn-42x-compatiblity
branch
from
d73fc2d
to
c511849
Compare
There was a problem hiding this comment.
Thanks for the work :)
For what is of my concern (the e2e tests), it looks good!
I was actually hoping for a way to log in outside of the tooltip button since it was tricky. Great that there was one.
I also had a look at the doc files and they well-detailed and helpful. I didn't look at the rest since you said the docker image had a problem for now.
libs/feature/search/src/lib/filter-dropdown/filter-dropdown.component.html
Show resolved
Hide resolved
The test file has been made more concise, many recurring blocks were factorized and the tests were made more reliable in their results. The login command has been created as a separate one and now works everytime hopefully.
Added a section for auth in the Deploy page. Added gn 4.2.2+ as requirement Rewrote the Why? page to be in english. Fixed various typos signaled by the IDE.
jahow
force-pushed
the
gn-42x-compatiblity
branch
from
c511849
to
6db0ba7
Compare
|
Ok I've managed to run the 4.2.5 version in docker so now the E2E tests work in all version! |
|
Also tested in 4.2.4 and 4.2.5, everything is working ! |
|
I'm merging this, we might revisit the way the GN version is fetched later on (see review on #598). |
This PR introduces a way to specify the GN version to use in the
support-servicesdocker composition:$ docker compose up -d # will start GN 4.2.2 by defaultSome E2E tests have been reworked significantly to be simpler and more reliable. All E2E tests currently pass on the 4.2.2, 4.2.3 and 4.2.4 versions.
Some adaptations to the GN4 records repository have been made to accomodate for differences in these versions.
Remaining to do:
Fixes #554