Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Make abstract links as hyperlinks #588

Closed
wants to merge 2 commits into from

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Aug 23, 2023

Relates to #571

JIRA Ticket

https://jira.camptocamp.com/browse/GSGCT-58

Issue

In dataset view, in the abstract section, the text may contain hyperlinks, that weren't clickable nor displayed as such. This is different than the case in #571 since the text in abstract needs to use the safe pipe.

Resolution

Created a function that creates the hyperlinks before sending the text to the HTML to pass the safe pipe. It is not allowed to use a directive if the text is in the innerHTML input, and the safe pipe has to be used in it.

To test

Go to dataset/ee965118-2416-4d48-b07e-bbc696f002c2.

Funded by SwissTopo geocat.ch

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: datahub, demo, webcomponents, metadata-editor, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier force-pushed the GSGCT-58-hyperlink-abstract branch from 7a1d319 to 0200a9e Compare August 23, 2023 08:26
@cmoinier cmoinier requested a review from jahow August 23, 2023 11:47
@jahow jahow added the on hold Work has been temporarily halted label Nov 3, 2023
@fgravin fgravin changed the title Datahub / make abstract links as hyperlinks [SwissTopo] [Datahub] Make abstract links as hyperlinks Dec 12, 2023
@fgravin fgravin changed the title [SwissTopo] [Datahub] Make abstract links as hyperlinks [Datahub] Make abstract links as hyperlinks Dec 14, 2023
@fgravin
Copy link
Member

fgravin commented Dec 20, 2023

What is the status of this PR, is it ready for a review ?
@cmoinier did you work on a similar task before ? How related is it with #571 ?

@cmoinier
Copy link
Collaborator Author

@fgravin As far as I know, back when I opened this, it was working correctly (meaning that all the links in the abstract section were working). It's related to #571 because it's using the same directive I created. I opened this ticket for the abstract section since it was mentioned in the lineage and usages ticket that it would have to be done eventually.

So IMO, yes, it's ready for review.

@fgravin fgravin removed the on hold Work has been temporarily halted label Dec 20, 2023
@fgravin fgravin linked an issue Dec 20, 2023 that may be closed by this pull request
@fgravin
Copy link
Member

fgravin commented Dec 20, 2023

It's related to #571 because it's using the same directive I created.

But you are not using your directive.
The safe pipe has gone BTW, but the abstract is in an innerHtml binding, so I guess we would need a pipe ?

I think that @Angi-Kinas is taking over it anyway.
Thanks

@fgravin
Copy link
Member

fgravin commented Dec 22, 2023

Overseded by #739

@fgravin fgravin closed this Dec 22, 2023
@fgravin fgravin deleted the GSGCT-58-hyperlink-abstract branch December 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datahub] Make abstract links as hyperlinks
3 participants