-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub] Make abstract links as hyperlinks #588
Conversation
Affected libs:
|
7a1d319
to
0200a9e
Compare
@fgravin As far as I know, back when I opened this, it was working correctly (meaning that all the links in the abstract section were working). It's related to #571 because it's using the same directive I created. I opened this ticket for the abstract section since it was mentioned in the lineage and usages ticket that it would have to be done eventually. So IMO, yes, it's ready for review. |
But you are not using your directive. I think that @Angi-Kinas is taking over it anyway. |
Overseded by #739 |
Relates to #571
JIRA Ticket
https://jira.camptocamp.com/browse/GSGCT-58
Issue
In dataset view, in the
abstract
section, the text may contain hyperlinks, that weren't clickable nor displayed as such. This is different than the case in #571 since the text inabstract
needs to use thesafe
pipe.Resolution
Created a function that creates the hyperlinks before sending the text to the HTML to pass the
safe
pipe. It is not allowed to use a directive if the text is in theinnerHTML
input, and thesafe
pipe has to be used in it.To test
Go to
dataset/ee965118-2416-4d48-b07e-bbc696f002c2
.Funded by SwissTopo geocat.ch