Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another batch of fixes for 1.1.0 release #563

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Another batch of fixes for 1.1.0 release #563

merged 1 commit into from
Aug 1, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Jul 31, 2023

  • Handle the case where WMS urls contain SERVICE or REQUEST params

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023 •
edited
Loading

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, util-shared, feature-catalog, feature-search, feature-auth, ui-elements, ui-catalog, ui-search, ui-widgets, feature-editor, ui-inputs, ui-map, api-metadata-converter, data-access-datafeeder, util-data-fetcher, data-access-gn4, util-app-config, util-i18n, ui-dataviz, util-types, ui-layout,
Affected apps: datahub, demo, webcomponents, search, map-viewer, metadata-converter, metadata-editor, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jul 31, 2023 •
edited
Loading

Coverage Status

coverage: 83.971% (-2.7%) from 86.671% when pulling ca507b7 on misc-fixes-for-1.1-2 into ba4b049 on main.

@jahow
fix(map): remove SERVICE & REQUEST params from wms url
ca507b7 
If these params are given to OL for the WMS layer then they will most likely
cause an error. Added a url utility to remove them in a case-insensitive way.

Also added a test for WFS layers
@f-necas f-necas merged commit 8382d9c into main Aug 1, 2023
5 checks passed
@f-necas f-necas deleted the misc-fixes-for-1.1-2 branch August 1, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jahow @coveralls @f-necas