-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: make use of minCharCount and clearOnSelection of autocomplete component #1036
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmoinier thanks for the review and testing! |
5b41632
to
777a839
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @Angi-Kinas ! Works like a charm. Happy to see it needed less logic than expected :-)
libs/feature/editor/src/lib/components/generic-keywords/generic-keywords.component.html
Show resolved
Hide resolved
after selecting an option the input should be cleared clicking inside the input does not show the previous selected option
300b3df
to
5ec61f8
Compare
Thanks for the added test! LGTM |
Description
This PR uses the functionality of the autocomplete component to achieve the following behaviour for the keyword edition:
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label