Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: Make first page default for record edition #1025

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Oct 24, 2024

Description

This PR defines the first page of the editor form as the default page when opening a record,
instead of opening the record on the last page consulted.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Oct 24, 2024

Coverage Status

coverage: 80.673% (-2.9%) from 83.538%
when pulling ccf4bc5 on ME-edit-default-first-page
into f246d6b on main.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@cmoinier cmoinier merged commit 72553e3 into main Oct 25, 2024
21 of 23 checks passed
@cmoinier cmoinier deleted the ME-edit-default-first-page branch October 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants