From 872735702f333caf23e844821f0f16db914c3663 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Thu, 25 Jul 2024 10:01:14 +0200
Subject: [PATCH 01/13] feat(editor): remove unnecessary export

---
 libs/api/metadata-converter/src/index.ts          | 1 -
 libs/api/repository/src/lib/gn4/gn4-repository.ts | 1 -
 2 files changed, 2 deletions(-)

diff --git a/libs/api/metadata-converter/src/index.ts b/libs/api/metadata-converter/src/index.ts
index a5e5f3d06e..169d8dfcb6 100644
--- a/libs/api/metadata-converter/src/index.ts
+++ b/libs/api/metadata-converter/src/index.ts
@@ -1,4 +1,3 @@
-export * from './lib/base.converter'
 export * from './lib/iso19139'
 export * from './lib/iso19115-3'
 export * from './lib/find-converter'
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index d16e72c14d..e916a4d2b4 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -24,7 +24,6 @@ import {
 } from '@geonetwork-ui/common/domain/model/search'
 import { catchError, map, tap } from 'rxjs/operators'
 import {
-  BaseConverter,
   findConverterForDocument,
   Gn4Converter,
   Gn4SearchResults,

From 69705f15a333bd19dd5f5095261a1fa3d506819e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Fri, 26 Jul 2024 11:52:59 +0200
Subject: [PATCH 02/13] feat(editor): delete a record and its draft

---
 .../dashboard-menu.component.ts               | 10 ++--
 .../records/my-draft/my-draft.component.html  |  1 +
 .../records/my-draft/my-draft.component.ts    |  1 +
 .../repository/src/lib/gn4/gn4-repository.ts  | 15 ++++-
 .../records-repository.interface.ts           |  7 +++
 .../results-table-container.component.html    |  1 +
 .../results-table-container.component.ts      | 43 +++++++++++++-
 .../search/src/lib/state/search.facade.ts     |  6 ++
 libs/ui/elements/src/index.ts                 |  1 +
 .../confirmation-dialog.component.css         |  0
 .../confirmation-dialog.component.html        |  8 +++
 .../confirmation-dialog.component.spec.ts     | 24 ++++++++
 .../confirmation-dialog.component.stories.ts  | 47 +++++++++++++++
 .../confirmation-dialog.component.ts          | 37 ++++++++++++
 .../action-menu/action-menu.component.html    | 11 +++-
 .../action-menu/action-menu.component.ts      | 57 ++++++++++++++++++-
 .../results-table.component.html              |  6 +-
 .../results-table/results-table.component.ts  |  6 ++
 18 files changed, 267 insertions(+), 14 deletions(-)
 create mode 100644 libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.css
 create mode 100644 libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
 create mode 100644 libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
 create mode 100644 libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
 create mode 100644 libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.ts

diff --git a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.ts b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.ts
index 4845040432..e2bb95762b 100644
--- a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.ts
+++ b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.ts
@@ -4,7 +4,7 @@ import { MatIconModule } from '@angular/material/icon'
 import { RouterModule } from '@angular/router'
 import { TranslateModule } from '@ngx-translate/core'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
-import { map } from 'rxjs/operators'
+import { map, startWith, switchMap } from 'rxjs/operators'
 import { BadgeComponent } from '@geonetwork-ui/ui/inputs'
 
 @Component({
@@ -22,9 +22,11 @@ import { BadgeComponent } from '@geonetwork-ui/ui/inputs'
   ],
 })
 export class DashboardMenuComponent {
-  draftsCount$ = this.recordsRepository
-    .getAllDrafts()
-    .pipe(map((drafts) => drafts.length))
+  draftsCount$ = this.recordsRepository.draftsChanged$.pipe(
+    startWith(void 0),
+    switchMap(() => this.recordsRepository.getAllDrafts()),
+    map((drafts) => drafts.length)
+  )
 
   constructor(private recordsRepository: RecordsRepositoryInterface) {}
 }
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
index de8be72269..f6562d467e 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
@@ -11,6 +11,7 @@ <h1 class="text-[16px] text-main font-title font-bold" translate>
     <gn-ui-results-table
       [records]="records$ | async"
       [recordHasDraft]="hasDraft"
+      [recordIsDraft]="isDraft"
       (recordClick)="editRecord($event)"
     ></gn-ui-results-table>
   </div>
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
index cd9d312037..851a91914b 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
@@ -33,6 +33,7 @@ import { startWith } from 'rxjs'
 export class MyDraftComponent {
   records$ = this.recordsRepository.getAllDrafts().pipe(startWith([]))
   hasDraft = () => true
+  isDraft = () => true
 
   constructor(
     private router: Router,
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index e916a4d2b4..1df4921968 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -9,6 +9,7 @@ import {
   from,
   Observable,
   of,
+  Subject,
   switchMap,
   throwError,
 } from 'rxjs'
@@ -34,6 +35,9 @@ import { HttpErrorResponse } from '@angular/common/http'
 
 @Injectable()
 export class Gn4Repository implements RecordsRepositoryInterface {
+  _draftsChanged = new Subject<void>()
+  draftsChanged$ = this._draftsChanged.asObservable()
+
   constructor(
     private gn4SearchApi: SearchApiService,
     private gn4SearchHelper: ElasticsearchService,
@@ -244,6 +248,7 @@ export class Gn4Repository implements RecordsRepositoryInterface {
           this.getLocalStorageKeyForRecord(record.uniqueIdentifier),
           xml
         )
+        this._draftsChanged.next()
         return [record, xml, false] as [CatalogRecord, string, false]
       })
     )
@@ -294,17 +299,22 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     )
   }
 
+  deleteRecord(uniqueIdentifier: string): Observable<void> {
+    return this.gn4RecordsApi.deleteRecord(uniqueIdentifier)
+  }
+
   saveRecordAsDraft(
     record: CatalogRecord,
     referenceRecordSource?: string
   ): Observable<string> {
     return this.serializeRecordToXml(record, referenceRecordSource).pipe(
-      tap((recordXml) =>
+      tap((recordXml) => {
         window.localStorage.setItem(
           this.getLocalStorageKeyForRecord(record.uniqueIdentifier),
           recordXml
         )
-      )
+        this._draftsChanged.next()
+      })
     )
   }
 
@@ -312,6 +322,7 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     window.localStorage.removeItem(
       this.getLocalStorageKeyForRecord(uniqueIdentifier)
     )
+    this._draftsChanged.next()
   }
 
   recordHasDraft(uniqueIdentifier: string): boolean {
diff --git a/libs/common/domain/src/lib/repository/records-repository.interface.ts b/libs/common/domain/src/lib/repository/records-repository.interface.ts
index 039eac3812..57f2d2f100 100644
--- a/libs/common/domain/src/lib/repository/records-repository.interface.ts
+++ b/libs/common/domain/src/lib/repository/records-repository.interface.ts
@@ -52,6 +52,12 @@ export abstract class RecordsRepositoryInterface {
     referenceRecordSource?: string
   ): Observable<string>
 
+  /**
+   * @param uniqueIdentifier
+   * @returns Observable<void> Returns when record is deleted
+   */
+  abstract deleteRecord(uniqueIdentifier: string): Observable<void>
+
   /**
    * @param record
    * @param referenceRecordSource
@@ -67,4 +73,5 @@ export abstract class RecordsRepositoryInterface {
 
   /** will return all pending drafts, both published and not published */
   abstract getAllDrafts(): Observable<CatalogRecord[]>
+  abstract draftsChanged$: Observable<void>
 }
diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.html b/libs/feature/search/src/lib/results-table/results-table-container.component.html
index b0aeb07004..3310cf5e8a 100644
--- a/libs/feature/search/src/lib/results-table/results-table-container.component.html
+++ b/libs/feature/search/src/lib/results-table/results-table-container.component.html
@@ -5,6 +5,7 @@
   [sortOrder]="sortBy$ | async"
   (recordClick)="handleRecordClick($event)"
   (duplicateRecord)="handleDuplicateRecord($event)"
+  (deleteRecord)="handleDeleteRecord($event)"
   (recordsSelectedChange)="handleRecordsSelectedChange($event[0], $event[1])"
   (sortByChange)="handleSortByChange($event[0], $event[1])"
 ></gn-ui-results-table>
diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.ts b/libs/feature/search/src/lib/results-table/results-table-container.component.ts
index 6b1cf8ebce..7e15aed314 100644
--- a/libs/feature/search/src/lib/results-table/results-table-container.component.ts
+++ b/libs/feature/search/src/lib/results-table/results-table-container.component.ts
@@ -1,4 +1,4 @@
-import { Component, EventEmitter, Output } from '@angular/core'
+import { Component, EventEmitter, OnDestroy, Output } from '@angular/core'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import { SearchFacade } from '../state/search.facade'
 import { SelectionService } from '@geonetwork-ui/api/repository'
@@ -6,6 +6,9 @@ import { SearchService } from '../utils/service/search.service'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
 import { ResultsTableComponent } from '@geonetwork-ui/ui/search'
 import { CommonModule } from '@angular/common'
+import { Subscription } from 'rxjs'
+import { NotificationsService } from '@geonetwork-ui/feature/notifications'
+import { TranslateService } from '@ngx-translate/core'
 
 @Component({
   selector: 'gn-ui-results-table-container',
@@ -14,10 +17,12 @@ import { CommonModule } from '@angular/common'
   standalone: true,
   imports: [CommonModule, ResultsTableComponent],
 })
-export class ResultsTableContainerComponent {
+export class ResultsTableContainerComponent implements OnDestroy {
   @Output() recordClick = new EventEmitter<CatalogRecord>()
   @Output() duplicateRecord = new EventEmitter<CatalogRecord>()
 
+  subscription = new Subscription()
+
   records$ = this.searchFacade.results$
   selectedRecords$ = this.selectionService.selectedRecordsIdentifiers$
   sortBy$ = this.searchFacade.sortBy$
@@ -29,7 +34,9 @@ export class ResultsTableContainerComponent {
     private searchFacade: SearchFacade,
     private searchService: SearchService,
     private selectionService: SelectionService,
-    private recordsRepository: RecordsRepositoryInterface
+    private recordsRepository: RecordsRepositoryInterface,
+    private notificationsService: NotificationsService,
+    private translateService: TranslateService
   ) {}
 
   handleRecordClick(item: unknown) {
@@ -40,6 +47,32 @@ export class ResultsTableContainerComponent {
     this.duplicateRecord.emit(item as CatalogRecord)
   }
 
+  async handleDeleteRecord(item: unknown) {
+    const uniqueIdentifier = (item as CatalogRecord).uniqueIdentifier
+    this.subscription.add(
+      this.recordsRepository.deleteRecord(uniqueIdentifier).subscribe({
+        next: () => {
+          this.recordsRepository.clearRecordDraft(uniqueIdentifier)
+          this.searchFacade.requestNewResults()
+        },
+        error: (error) => {
+          this.notificationsService.showNotification({
+            type: 'error',
+            title: this.translateService.instant(
+              'editor.record.deleteError.title'
+            ),
+            text: `${this.translateService.instant(
+              'editor.record.deleteError.body'
+            )} ${error}`,
+            closeMessage: this.translateService.instant(
+              'editor.record.deleteError.closeMessage'
+            ),
+          })
+        },
+      })
+    )
+  }
+
   handleSortByChange(col: string, order: 'asc' | 'desc') {
     this.searchService.setSortBy([order, col])
   }
@@ -51,4 +84,8 @@ export class ResultsTableContainerComponent {
       this.selectionService.selectRecords(records)
     }
   }
+
+  ngOnDestroy() {
+    this.subscription.unsubscribe()
+  }
 }
diff --git a/libs/feature/search/src/lib/state/search.facade.ts b/libs/feature/search/src/lib/state/search.facade.ts
index 1f9388a2b1..44c9c34e1e 100644
--- a/libs/feature/search/src/lib/state/search.facade.ts
+++ b/libs/feature/search/src/lib/state/search.facade.ts
@@ -8,6 +8,7 @@ import {
   Paginate,
   RequestMoreOnAggregation,
   RequestMoreResults,
+  RequestNewResults,
   SetConfigAggregations,
   SetConfigFilters,
   SetConfigRequestFields,
@@ -151,6 +152,11 @@ export class SearchFacade {
     return this
   }
 
+  requestNewResults(): SearchFacade {
+    this.store.dispatch(new RequestNewResults(this.searchId))
+    return this
+  }
+
   requestMoreOnAggregation(key: string, increment: number): SearchFacade {
     this.store.dispatch(
       new RequestMoreOnAggregation(key, increment, this.searchId)
diff --git a/libs/ui/elements/src/index.ts b/libs/ui/elements/src/index.ts
index 578e08b8ed..327b9d5c81 100644
--- a/libs/ui/elements/src/index.ts
+++ b/libs/ui/elements/src/index.ts
@@ -1,5 +1,6 @@
 export * from './lib/api-card/api-card.component'
 export * from './lib/avatar/avatar.component'
+export * from './lib/confirmation-dialog/confirmation-dialog.component'
 export * from './lib/content-ghost/content-ghost.component'
 export * from './lib/download-item/download-item.component'
 export * from './lib/downloads-list/downloads-list.component'
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.css b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.css
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
new file mode 100644
index 0000000000..2414c3e5f2
--- /dev/null
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
@@ -0,0 +1,8 @@
+<h1 mat-dialog-title>{{ data.title }}</h1>
+<div mat-dialog-content>{{ data.message }}</div>
+<div mat-dialog-actions>
+  <gn-ui-button (buttonClick)="onCancel()">{{ data.cancelText }}</gn-ui-button>
+  <gn-ui-button (buttonClick)="onConfirm()" cdkFocusInitial class="ml-2">{{
+    data.confirmText
+  }}</gn-ui-button>
+</div>
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
new file mode 100644
index 0000000000..952d289727
--- /dev/null
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
@@ -0,0 +1,24 @@
+import { ComponentFixture, TestBed } from '@angular/core/testing'
+import { ConfirmationDialogComponent } from './confirmation-dialog.component'
+
+describe('ConfirmationDialogComponent', () => {
+  let component: ConfirmationDialogComponent
+  let fixture: ComponentFixture<ConfirmationDialogComponent>
+
+  beforeEach(async () => {
+    await TestBed.configureTestingModule({
+      imports: [ConfirmationDialogComponent],
+    }).compileComponents()
+  })
+
+  beforeEach(() => {
+    fixture = TestBed.createComponent(ConfirmationDialogComponent)
+    component = fixture.componentInstance
+    fixture.detectChanges()
+  })
+
+  it('should create', () => {
+    fixture.detectChanges()
+    expect(component).toBeTruthy()
+  })
+})
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
new file mode 100644
index 0000000000..6f4decc4ac
--- /dev/null
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
@@ -0,0 +1,47 @@
+import { Component, Input } from '@angular/core'
+import { MatDialog } from '@angular/material/dialog'
+import { ButtonComponent } from '@geonetwork-ui/ui/inputs'
+import { Meta, moduleMetadata, StoryObj } from '@storybook/angular'
+import { ConfirmationDialogComponent } from './confirmation-dialog.component'
+
+@Component({
+  selector: 'gn-ui-launcher',
+  template: ` <gn-ui-button (buttonClick)="launch()">Open</gn-ui-button> `,
+})
+class LaunchDialogComponent {
+  @Input() title = ''
+  @Input() message = ''
+  @Input() confirmText = ''
+  @Input() cancelText = ''
+  constructor(private _dialog: MatDialog) {}
+
+  launch(): void {
+    this._dialog.open(ConfirmationDialogComponent, {
+      data: {
+        title: this.title,
+        message: this.message,
+        confirmText: this.confirmText,
+        cancelText: this.cancelText,
+      },
+    })
+  }
+}
+
+export default {
+  title: 'Elements/ConfirmationDialogComponent',
+  component: LaunchDialogComponent,
+  decorators: [
+    moduleMetadata({
+      imports: [ButtonComponent, ConfirmationDialogComponent],
+    }),
+  ],
+} as Meta
+
+export const Primary: StoryObj<LaunchDialogComponent> = {
+  args: {
+    title: 'Some title',
+    message: 'Some message to confirm',
+    confirmText: 'OK',
+    cancelText: 'KO',
+  },
+}
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.ts b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.ts
new file mode 100644
index 0000000000..8eac932175
--- /dev/null
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.ts
@@ -0,0 +1,37 @@
+import { ChangeDetectionStrategy, Component, Inject } from '@angular/core'
+import {
+  MAT_DIALOG_DATA,
+  MatDialogModule,
+  MatDialogRef,
+} from '@angular/material/dialog'
+import { ButtonComponent } from '@geonetwork-ui/ui/inputs'
+
+export interface ConfirmationDialogData {
+  title: string
+  message: string
+  confirmText: string
+  cancelText: string
+}
+
+@Component({
+  selector: 'gn-ui-confirmation-dialog',
+  templateUrl: './confirmation-dialog.component.html',
+  styleUrls: ['./confirmation-dialog.component.css'],
+  changeDetection: ChangeDetectionStrategy.OnPush,
+  standalone: true,
+  imports: [MatDialogModule, ButtonComponent],
+})
+export class ConfirmationDialogComponent {
+  constructor(
+    public dialogRef: MatDialogRef<ConfirmationDialogComponent>,
+    @Inject(MAT_DIALOG_DATA) public data: ConfirmationDialogData
+  ) {}
+
+  onConfirm() {
+    this.dialogRef.close(true)
+  }
+
+  onCancel() {
+    this.dialogRef.close(false)
+  }
+}
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
index f423d03193..416d2d50d6 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
@@ -1,5 +1,5 @@
 <gn-ui-button
-  type="outline"
+  type="light"
   [matMenuTriggerFor]="menu"
   (buttonClick)="openMenu()"
   data-test="record-menu-button"
@@ -9,9 +9,18 @@
 <mat-menu #menu="matMenu">
   <button
     mat-menu-item
+    [disabled]="isDraft"
     (click)="duplicate.emit()"
     data-test="record-menu-duplicate-button"
   >
     <span translate>record.action.duplicate</span>
   </button>
+  <button
+    mat-menu-item
+    [disabled]="isDraft"
+    (click)="openDeleteConfirmationDialog()"
+    data-test="record-menu-delete-button"
+  >
+    <span translate>record.action.delete</span>
+  </button>
 </mat-menu>
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
index 155692316e..a2fe6e57f4 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
@@ -1,22 +1,73 @@
-import { Component, EventEmitter, Output, ViewChild } from '@angular/core'
+import {
+  Component,
+  EventEmitter,
+  Input,
+  Output,
+  ViewChild,
+} from '@angular/core'
+import { MatDialog, MatDialogModule } from '@angular/material/dialog'
 import { MatIconModule } from '@angular/material/icon'
 import { MatMenuModule, MatMenuTrigger } from '@angular/material/menu'
+import { ConfirmationDialogComponent } from '@geonetwork-ui/ui/elements'
 import { ButtonComponent } from '@geonetwork-ui/ui/inputs'
-import { TranslateModule } from '@ngx-translate/core'
+import { TranslateModule, TranslateService } from '@ngx-translate/core'
 
 @Component({
   selector: 'gn-ui-action-menu',
   templateUrl: './action-menu.component.html',
   styleUrls: ['./action-menu.component.css'],
   standalone: true,
-  imports: [MatIconModule, ButtonComponent, MatMenuModule, TranslateModule],
+  imports: [
+    MatIconModule,
+    ButtonComponent,
+    MatMenuModule,
+    MatDialogModule,
+    ConfirmationDialogComponent,
+    TranslateModule,
+  ],
 })
 export class ActionMenuComponent {
+  @Input() isDraft: boolean
   @Output() duplicate = new EventEmitter<void>()
+  @Output() delete = new EventEmitter<void>()
 
   @ViewChild(MatMenuTrigger) trigger: MatMenuTrigger
 
+  constructor(
+    public dialog: MatDialog,
+    private translateService: TranslateService
+  ) {}
+
   openMenu() {
     this.trigger.openMenu()
   }
+
+  openDeleteConfirmationDialog() {
+    const dialogRef = this.dialog.open(ConfirmationDialogComponent, {
+      data: {
+        title: this.translateService.instant(
+          'editor.record.delete.confirmation.title'
+        ),
+        message: this.translateService.instant(
+          'editor.record.delete.confirmation.message'
+        ),
+        confirmText: this.translateService.instant(
+          'editor.record.delete.confirmation.confirmText'
+        ),
+        cancelText: this.translateService.instant(
+          'editor.record.delete.confirmation.cancelText'
+        ),
+      },
+      restoreFocus: false,
+    })
+
+    // Manually restore focus to the menu trigger since the element that
+    // opens the dialog won't be in the DOM any more when the dialog closes.
+    dialogRef.afterClosed().subscribe((result) => {
+      this.trigger.focus()
+      if (result) {
+        this.delete.emit()
+      }
+    })
+  }
 }
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.html b/libs/ui/search/src/lib/results-table/results-table.component.html
index c062fd521c..6f59bdab1f 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.html
+++ b/libs/ui/search/src/lib/results-table/results-table.component.html
@@ -125,7 +125,11 @@
   <gn-ui-interactive-table-column>
     <ng-template #header> </ng-template>
     <ng-template #cell let-item>
-      <gn-ui-action-menu (duplicate)="handleDuplicate(item)">
+      <gn-ui-action-menu
+        [isDraft]="recordIsDraft(item)"
+        (duplicate)="handleDuplicate(item)"
+        (delete)="handleDelete(item)"
+      >
       </gn-ui-action-menu>
     </ng-template>
   </gn-ui-interactive-table-column>
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.ts b/libs/ui/search/src/lib/results-table/results-table.component.ts
index 3d7dba9f0a..a5153280cf 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.ts
+++ b/libs/ui/search/src/lib/results-table/results-table.component.ts
@@ -48,11 +48,13 @@ export class ResultsTableComponent {
   @Input() selectedRecordsIdentifiers: string[] = []
   @Input() sortOrder: SortByField = null
   @Input() recordHasDraft: (record: CatalogRecord) => boolean = () => false
+  @Input() recordIsDraft: (record: CatalogRecord) => boolean = () => false
 
   // emits the column (field) as well as the order
   @Output() sortByChange = new EventEmitter<[string, 'asc' | 'desc']>()
   @Output() recordClick = new EventEmitter<CatalogRecord>()
   @Output() duplicateRecord = new EventEmitter<CatalogRecord>()
+  @Output() deleteRecord = new EventEmitter<CatalogRecord>()
   @Output() recordsSelectedChange = new EventEmitter<
     [CatalogRecord[], boolean]
   >()
@@ -103,6 +105,10 @@ export class ResultsTableComponent {
     this.duplicateRecord.emit(item as CatalogRecord)
   }
 
+  handleDelete(item: unknown) {
+    this.deleteRecord.emit(item as CatalogRecord)
+  }
+
   setSortBy(col: string, order: 'asc' | 'desc') {
     this.sortByChange.emit([col, order])
   }

From bf30cd406b152321ae5930bcd13a239c9d09b982 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Fri, 2 Aug 2024 09:36:45 +0200
Subject: [PATCH 03/13] feat(editor): delete a temporary draft

---
 .../records/my-draft/my-draft.component.html  |  2 ++
 .../records/my-draft/my-draft.component.ts    | 32 ++++++++++++-------
 .../repository/src/lib/gn4/gn4-repository.ts  |  4 +++
 .../records-repository.interface.ts           |  1 +
 .../action-menu/action-menu.component.html    |  2 +-
 .../action-menu/action-menu.component.ts      |  1 +
 .../results-table.component.html              |  1 +
 .../results-table/results-table.component.ts  | 10 ++----
 8 files changed, 33 insertions(+), 20 deletions(-)

diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
index f6562d467e..bc95b84bc0 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
@@ -12,7 +12,9 @@ <h1 class="text-[16px] text-main font-title font-bold" translate>
       [records]="records$ | async"
       [recordHasDraft]="hasDraft"
       [recordIsDraft]="isDraft"
+      [draftIsTemporary]="isTemporary"
       (recordClick)="editRecord($event)"
+      (deleteRecord)="deleteDraft($event)"
     ></gn-ui-results-table>
   </div>
 </main>
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
index 851a91914b..8ef05cf0b1 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
@@ -1,17 +1,17 @@
-import { Component } from '@angular/core'
 import { CommonModule } from '@angular/common'
-import { TranslateModule } from '@ngx-translate/core'
-import { RecordsListComponent } from '../records-list.component'
-import { ResultsTableContainerComponent } from '@geonetwork-ui/feature/search'
-import { ButtonComponent } from '@geonetwork-ui/ui/inputs'
+import { Component } from '@angular/core'
 import { MatIconModule } from '@angular/material/icon'
-import { RecordsCountComponent } from '../records-count/records-count.component'
-import { UiElementsModule } from '@geonetwork-ui/ui/elements'
-import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
-import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import { Router } from '@angular/router'
+import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { ResultsTableContainerComponent } from '@geonetwork-ui/feature/search'
+import { UiElementsModule } from '@geonetwork-ui/ui/elements'
+import { ButtonComponent } from '@geonetwork-ui/ui/inputs'
 import { ResultsTableComponent } from '@geonetwork-ui/ui/search'
-import { startWith } from 'rxjs'
+import { TranslateModule } from '@ngx-translate/core'
+import { startWith, switchMap } from 'rxjs'
+import { RecordsCountComponent } from '../records-count/records-count.component'
+import { RecordsListComponent } from '../records-list.component'
 
 @Component({
   selector: 'md-editor-my-my-draft',
@@ -31,9 +31,15 @@ import { startWith } from 'rxjs'
   ],
 })
 export class MyDraftComponent {
-  records$ = this.recordsRepository.getAllDrafts().pipe(startWith([]))
+  records$ = this.recordsRepository.draftsChanged$.pipe(
+    startWith(void 0),
+    switchMap(() => this.recordsRepository.getAllDrafts()),
+    startWith([])
+  )
   hasDraft = () => true
   isDraft = () => true
+  isTemporary = (record: CatalogRecord): boolean =>
+    this.recordsRepository.draftIsTemporary(record.uniqueIdentifier)
 
   constructor(
     private router: Router,
@@ -43,4 +49,8 @@ export class MyDraftComponent {
   editRecord(record: CatalogRecord) {
     this.router.navigate(['/edit', record.uniqueIdentifier])
   }
+
+  deleteDraft(record: CatalogRecord) {
+    this.recordsRepository.clearRecordDraft(record.uniqueIdentifier)
+  }
 }
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index 1df4921968..a8468763c2 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -333,6 +333,10 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     )
   }
 
+  draftIsTemporary(uniqueIdentifier: string): boolean {
+    return uniqueIdentifier.startsWith('TEMP-ID-')
+  }
+
   // generated by copilot
   getAllDrafts(): Observable<CatalogRecord[]> {
     const items = { ...window.localStorage }
diff --git a/libs/common/domain/src/lib/repository/records-repository.interface.ts b/libs/common/domain/src/lib/repository/records-repository.interface.ts
index 57f2d2f100..001453595b 100644
--- a/libs/common/domain/src/lib/repository/records-repository.interface.ts
+++ b/libs/common/domain/src/lib/repository/records-repository.interface.ts
@@ -70,6 +70,7 @@ export abstract class RecordsRepositoryInterface {
 
   abstract clearRecordDraft(uniqueIdentifier: string): void
   abstract recordHasDraft(uniqueIdentifier: string): boolean
+  abstract draftIsTemporary(uniqueIdentifier: string): boolean
 
   /** will return all pending drafts, both published and not published */
   abstract getAllDrafts(): Observable<CatalogRecord[]>
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
index 416d2d50d6..de020e865a 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
@@ -17,7 +17,7 @@
   </button>
   <button
     mat-menu-item
-    [disabled]="isDraft"
+    [disabled]="!(isDraftOnly || !isDraft)"
     (click)="openDeleteConfirmationDialog()"
     data-test="record-menu-delete-button"
   >
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
index a2fe6e57f4..b154e756fd 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
@@ -28,6 +28,7 @@ import { TranslateModule, TranslateService } from '@ngx-translate/core'
 })
 export class ActionMenuComponent {
   @Input() isDraft: boolean
+  @Input() isDraftOnly: boolean
   @Output() duplicate = new EventEmitter<void>()
   @Output() delete = new EventEmitter<void>()
 
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.html b/libs/ui/search/src/lib/results-table/results-table.component.html
index 6f59bdab1f..f2cdade463 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.html
+++ b/libs/ui/search/src/lib/results-table/results-table.component.html
@@ -127,6 +127,7 @@
     <ng-template #cell let-item>
       <gn-ui-action-menu
         [isDraft]="recordIsDraft(item)"
+        [isDraftOnly]="draftIsTemporary(item)"
         (duplicate)="handleDuplicate(item)"
         (delete)="handleDelete(item)"
       >
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.ts b/libs/ui/search/src/lib/results-table/results-table.component.ts
index a5153280cf..017b24d2f3 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.ts
+++ b/libs/ui/search/src/lib/results-table/results-table.component.ts
@@ -1,13 +1,6 @@
 import { CommonModule } from '@angular/common'
-import {
-  Component,
-  EventEmitter,
-  Input,
-  Output,
-  ViewChild,
-} from '@angular/core'
+import { Component, EventEmitter, Input, Output } from '@angular/core'
 import { MatIconModule } from '@angular/material/icon'
-import { MatMenuModule, MatMenuTrigger } from '@angular/material/menu'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import {
   FieldSort,
@@ -49,6 +42,7 @@ export class ResultsTableComponent {
   @Input() sortOrder: SortByField = null
   @Input() recordHasDraft: (record: CatalogRecord) => boolean = () => false
   @Input() recordIsDraft: (record: CatalogRecord) => boolean = () => false
+  @Input() draftIsTemporary: (record: CatalogRecord) => boolean = () => false
 
   // emits the column (field) as well as the order
   @Output() sortByChange = new EventEmitter<[string, 'asc' | 'desc']>()

From 70f05d033ff55cfa87cd09421c154e9288a9615b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Tue, 6 Aug 2024 15:42:29 +0200
Subject: [PATCH 04/13] e2e(editor): delete record and draft

---
 apps/metadata-editor-e2e/src/e2e/delete.cy.ts | 62 +++++++++++++++++++
 .../dashboard-menu.component.html             |  8 ++-
 .../search-records-list.component.html        |  6 +-
 .../confirmation-dialog.component.html        | 10 ++-
 .../interactive-table.component.html          |  1 +
 5 files changed, 80 insertions(+), 7 deletions(-)
 create mode 100644 apps/metadata-editor-e2e/src/e2e/delete.cy.ts

diff --git a/apps/metadata-editor-e2e/src/e2e/delete.cy.ts b/apps/metadata-editor-e2e/src/e2e/delete.cy.ts
new file mode 100644
index 0000000000..c9500aa349
--- /dev/null
+++ b/apps/metadata-editor-e2e/src/e2e/delete.cy.ts
@@ -0,0 +1,62 @@
+describe('delete', () => {
+  beforeEach(() => {
+    cy.login('admin', 'admin', false)
+    cy.visit('/catalog/search')
+  })
+
+  describe('record with draft', () => {
+    it('should delete the record, delete its associated draft and refresh the interface', () => {
+      // First create a record and its draft
+      cy.get('[data-cy="create-record"]').click()
+      cy.get('gn-ui-form-field[ng-reflect-model=abstract] textarea').type(
+        'record abstract'
+      )
+      cy.get('md-editor-publish-button').click()
+      // eslint-disable-next-line cypress/no-unnecessary-waiting
+      cy.wait(1000) // waiting for publication
+      cy.get('gn-ui-form-field[ng-reflect-model=abstract] textarea').type(
+        'draft abstract'
+      )
+      // eslint-disable-next-line cypress/no-unnecessary-waiting
+      cy.wait(1000) // waiting for draft saving to kick in
+      cy.visit('/catalog/search?_sort=-changeDate')
+      cy.get('[data-cy="table-row"]')
+        .contains('My new record')
+        .should('have.length', 1)
+      cy.get('[data-cy="dashboard-drafts-count"]').should('contain', '1')
+      // Delete the record
+      cy.get('[data-test="record-menu-button"]').first().click()
+      cy.get('[data-test="record-menu-delete-button"]').click()
+      cy.get('[data-cy="confirm-button"]').click()
+      cy.get('[data-cy="table-row"]')
+        .contains('My new record')
+        .should('have.length', 0)
+      cy.get('[data-cy="dashboard-drafts-count"]').should('contain', '0')
+    })
+  })
+
+  describe('draft without record', () => {
+    it('should delete the draft and refresh the interface', () => {
+      // First create a draft
+      cy.get('[data-cy="create-record"]').click()
+      cy.get('gn-ui-form-field[ng-reflect-model=abstract] textarea').type(
+        'draft abstract'
+      )
+      // eslint-disable-next-line cypress/no-unnecessary-waiting
+      cy.wait(1000) // waiting for draft saving to kick in
+      cy.visit('/my-space/my-draft')
+      cy.get('[data-cy="table-row"]')
+        .contains('My new record')
+        .should('have.length', 1)
+      cy.get('[data-cy="dashboard-drafts-count"]').should('contain', '1')
+      // Delete the draft
+      cy.get('[data-test="record-menu-button"]').click()
+      cy.get('[data-test="record-menu-delete-button"]').click()
+      cy.get('[data-cy="confirm-button"]').click()
+      cy.get('[data-cy="table-row"]')
+        .contains('New record')
+        .should('have.length', 0)
+      cy.get('[data-cy="dashboard-drafts-count"]').should('contain', '0')
+    })
+  })
+})
diff --git a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html
index ed67fe8b72..b57c19c048 100644
--- a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html
+++ b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html
@@ -67,9 +67,11 @@
     >
       <mat-icon class="material-symbols-outlined">edit_note</mat-icon>
       <span translate="">dashboard.records.myDraft</span>
-      <gn-ui-badge [style.--gn-ui-badge-rounded]="'100px'">{{
-        draftsCount$ | async
-      }}</gn-ui-badge>
+      <gn-ui-badge
+        [style.--gn-ui-badge-rounded]="'100px'"
+        data-cy="dashboard-drafts-count"
+        >{{ draftsCount$ | async }}</gn-ui-badge
+      >
     </a>
     <a
       class="menu-item"
diff --git a/apps/metadata-editor/src/app/records/search-records/search-records-list.component.html b/apps/metadata-editor/src/app/records/search-records/search-records-list.component.html
index d07c2c50ef..becee4f003 100644
--- a/apps/metadata-editor/src/app/records/search-records/search-records-list.component.html
+++ b/apps/metadata-editor/src/app/records/search-records/search-records-list.component.html
@@ -31,7 +31,11 @@ <h1 class="text-[16px] text-main font-title font-bold" translate>
       <span class="uppercase" translate>dashboard.results.listResources</span>
     </div>
     <div class="grow"></div>
-    <gn-ui-button (buttonClick)="createRecord()" type="primary">
+    <gn-ui-button
+      (buttonClick)="createRecord()"
+      type="primary"
+      data-cy="create-record"
+    >
       <mat-icon class="material-symbols-outlined mr-2">edit_document</mat-icon>
       <span translate>dashboard.createRecord</span>
     </gn-ui-button>
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
index 2414c3e5f2..684437dc99 100644
--- a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.html
@@ -2,7 +2,11 @@ <h1 mat-dialog-title>{{ data.title }}</h1>
 <div mat-dialog-content>{{ data.message }}</div>
 <div mat-dialog-actions>
   <gn-ui-button (buttonClick)="onCancel()">{{ data.cancelText }}</gn-ui-button>
-  <gn-ui-button (buttonClick)="onConfirm()" cdkFocusInitial class="ml-2">{{
-    data.confirmText
-  }}</gn-ui-button>
+  <gn-ui-button
+    (buttonClick)="onConfirm()"
+    cdkFocusInitial
+    class="ml-2"
+    data-cy="confirm-button"
+    >{{ data.confirmText }}</gn-ui-button
+  >
 </div>
diff --git a/libs/ui/layout/src/lib/interactive-table/interactive-table.component.html b/libs/ui/layout/src/lib/interactive-table/interactive-table.component.html
index 81c2e88dec..143497cfbb 100644
--- a/libs/ui/layout/src/lib/interactive-table/interactive-table.component.html
+++ b/libs/ui/layout/src/lib/interactive-table/interactive-table.component.html
@@ -30,6 +30,7 @@
     class="contents text-gray-900 cursor-pointer group"
     *ngFor="let item of items"
     (click)="handleRowClick(item)"
+    data-cy="table-row"
   >
     <div
       class="relative h-0"

From 2656eb01b6821941cd0a3b688dee955eca53be35 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 7 Aug 2024 08:48:11 +0200
Subject: [PATCH 05/13] test(editor): records observable, delete error
 notification

---
 .../dashboard-menu.component.spec.ts          | 24 ++++++++++-
 .../my-draft/my-draft.component.spec.ts       | 23 +++++++++--
 .../results-table-container.component.spec.ts | 40 ++++++++++++++++++-
 3 files changed, 80 insertions(+), 7 deletions(-)

diff --git a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
index 2e04d1d6f7..a4c4eccd82 100644
--- a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
+++ b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
@@ -1,19 +1,22 @@
 import { NO_ERRORS_SCHEMA } from '@angular/core'
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 import { ActivatedRoute } from '@angular/router'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
 import { TranslateModule } from '@ngx-translate/core'
+import { cold, hot } from 'jasmine-marbles'
 import { of } from 'rxjs'
 import { DashboardMenuComponent } from './dashboard-menu.component'
-import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
-import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
 
 class RecordsRepositoryMock {
+  draftsChanged$ = of(void 0)
   getAllDrafts = jest.fn().mockReturnValue(of(DATASET_RECORDS))
 }
 
 describe('DashboardMenuComponent', () => {
   let component: DashboardMenuComponent
   let fixture: ComponentFixture<DashboardMenuComponent>
+  let recordsRepository: RecordsRepositoryMock
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
@@ -30,6 +33,7 @@ describe('DashboardMenuComponent', () => {
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).compileComponents()
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
     fixture = TestBed.createComponent(DashboardMenuComponent)
     component = fixture.componentInstance
     fixture.detectChanges()
@@ -38,4 +42,20 @@ describe('DashboardMenuComponent', () => {
   it('should create', () => {
     expect(component).toBeTruthy()
   })
+
+  it('should emit draftsCount$ immediately and then on drafts change', () => {
+    // Mock the source observable that draftsCount$ depends on
+    recordsRepository.draftsChanged$ = hot('-a-|', {
+      a: void 0,
+    })
+    recordsRepository.getAllDrafts = jest
+      .fn()
+      .mockReturnValue(hot('ab-|', { a: [], b: [{}] }))
+
+    // Define the expected marble diagram
+    const expected = cold('ab-|', { a: 0, b: 1 })
+
+    // Assert that draftsCount$ behaves as expected
+    expect(component.draftsCount$).toBeObservable(expected)
+  })
 })
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
index 4c42919839..2a6607cb96 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
@@ -6,6 +6,7 @@ import { RecordsListComponent } from '../records-list.component'
 import { of } from 'rxjs'
 import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { cold, hot } from 'jasmine-marbles'
 
 @Component({
   selector: 'md-editor-records-list',
@@ -15,12 +16,15 @@ import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/reposit
 export class MockRecordsListComponent {}
 
 class RecordsRepositoryMock {
+  draftsChanged$ = of(void 0)
   getAllDrafts = jest.fn().mockReturnValue(of(DATASET_RECORDS))
+  draftIsTemporary = jest.fn()
 }
 
 describe('MyDraftComponent', () => {
   let component: MyDraftComponent
   let fixture: ComponentFixture<MyDraftComponent>
+  let recordsRepository: RecordsRepositoryMock
 
   beforeEach(() => {
     TestBed.configureTestingModule({
@@ -39,6 +43,7 @@ describe('MyDraftComponent', () => {
         imports: [MockRecordsListComponent],
       },
     })
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
     fixture = TestBed.createComponent(MyDraftComponent)
     component = fixture.componentInstance
     fixture.detectChanges()
@@ -48,9 +53,19 @@ describe('MyDraftComponent', () => {
     expect(component).toBeTruthy()
   })
 
-  it('gets all drafts on init', () => {
-    expect(
-      TestBed.inject(RecordsRepositoryInterface).getAllDrafts
-    ).toHaveBeenCalled()
+  it('should emit records$ immediately and then on drafts change', () => {
+    // Mock the source observable that records$ depends on
+    recordsRepository.draftsChanged$ = hot('--a-|', {
+      a: void 0,
+    })
+    recordsRepository.getAllDrafts = jest
+      .fn()
+      .mockReturnValue(hot('-ab-|', { a: [], b: [{}] }))
+
+    // Define the expected marble diagram
+    const expected = cold('abc-|', { a: [], b: [], c: [{}] })
+
+    // Assert that records$ behaves as expected
+    expect(component.records$).toBeObservable(expected)
   })
 })
diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts b/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
index eb843061a3..9e842d087c 100644
--- a/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
+++ b/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
@@ -5,8 +5,9 @@ import { SelectionService } from '@geonetwork-ui/api/repository'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
 import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
+import { NotificationsService } from '@geonetwork-ui/feature/notifications'
 import { TranslateModule } from '@ngx-translate/core'
-import { BehaviorSubject } from 'rxjs'
+import { BehaviorSubject, of, throwError } from 'rxjs'
 import { SearchFacade } from '../state/search.facade'
 import { SearchService } from '../utils/service/search.service'
 import { ResultsTableContainerComponent } from './results-table-container.component'
@@ -17,6 +18,7 @@ class SearchFacadeMock {
   setConfigRequestFields = jest.fn(() => this)
   setSortBy = jest.fn(() => this)
   sortBy$ = new BehaviorSubject<any>(['asc', 'updateDate'])
+  requestNewResults = jest.fn()
 }
 class SearchServiceMock {
   setPage = jest.fn()
@@ -30,6 +32,11 @@ class SelectionServiceMock {
 }
 class RecordsRepositoryMock {
   recordHasDraft = jest.fn(() => false)
+  deleteRecord = jest.fn(() => of(void 0))
+  clearRecordDraft = jest.fn()
+}
+class NotificationsServiceMock {
+  showNotification = jest.fn()
 }
 
 describe('ResultsTableContainerComponent', () => {
@@ -37,6 +44,8 @@ describe('ResultsTableContainerComponent', () => {
   let searchFacade: SearchFacadeMock
   let searchService: SearchServiceMock
   let selectionService: SelectionServiceMock
+  let recordsRepository: RecordsRepositoryMock
+  let notificationsService: NotificationsServiceMock
   let fixture: ComponentFixture<ResultsTableContainerComponent>
 
   beforeEach(async () => {
@@ -59,6 +68,7 @@ describe('ResultsTableContainerComponent', () => {
           provide: RecordsRepositoryInterface,
           useClass: RecordsRepositoryMock,
         },
+        { provide: NotificationsService, useClass: NotificationsServiceMock },
       ],
     }).compileComponents()
 
@@ -66,6 +76,8 @@ describe('ResultsTableContainerComponent', () => {
     searchFacade = TestBed.inject(SearchFacade) as any
     searchService = TestBed.inject(SearchService) as any
     selectionService = TestBed.inject(SelectionService) as any
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
+    notificationsService = TestBed.inject(NotificationsService) as any
     component = fixture.componentInstance
     fixture.detectChanges()
   })
@@ -146,6 +158,32 @@ describe('ResultsTableContainerComponent', () => {
     })
   })
 
+  describe('deleting a dataset', () => {
+    describe('delete error', () => {
+      it('shows notification', () => {
+        recordsRepository.deleteRecord = jest.fn(() =>
+          throwError(() => 'oopsie')
+        )
+        component.handleDeleteRecord(DATASET_RECORDS[0])
+        expect(notificationsService.showNotification).toHaveBeenCalledWith({
+          type: 'error',
+          title: 'editor.record.deleteError.title',
+          text: 'editor.record.deleteError.body oopsie',
+          closeMessage: 'editor.record.deleteError.closeMessage',
+        })
+      })
+    })
+
+    describe('delete success', () => {
+      it('shows notification', () => {
+        component.handleDeleteRecord(DATASET_RECORDS[0])
+        expect(recordsRepository.deleteRecord).toHaveBeenCalled()
+        expect(recordsRepository.clearRecordDraft).toHaveBeenCalled()
+        expect(searchFacade.requestNewResults).toHaveBeenCalled()
+      })
+    })
+  })
+
   describe('#hasDraft', () => {
     it('calls the repository service', () => {
       const record = DATASET_RECORDS[0]

From aaeab24160d35f5154876611e6fa675bde665822 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 7 Aug 2024 12:57:37 +0200
Subject: [PATCH 06/13] chore(editor): i18n

---
 translations/de.json |  8 ++++++++
 translations/en.json |  8 ++++++++
 translations/es.json |  8 ++++++++
 translations/fr.json | 26 +++++++++++++++++---------
 translations/it.json |  8 ++++++++
 translations/nl.json |  8 ++++++++
 translations/pt.json |  8 ++++++++
 translations/sk.json |  8 ++++++++
 8 files changed, 73 insertions(+), 9 deletions(-)

diff --git a/translations/de.json b/translations/de.json
index 22ed837330..edef9798c3 100644
--- a/translations/de.json
+++ b/translations/de.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "unbekannt",
   "downloads.wfs.featuretype.not.found": "Der Layer wurde nicht gefunden",
   "dropFile": "Datei ablegen",
+  "editor.record.delete.confirmation.cancelText": "Stornieren",
+  "editor.record.delete.confirmation.confirmText": "Löschen",
+  "editor.record.delete.confirmation.message": "Sind Sie sicher, dass Sie diesen Datensatz löschen möchten?",
+  "editor.record.delete.confirmation.title": "Datensatz löschen?",
+  "editor.record.deleteError.body": "Der Datensatz konnte nicht gelöscht werden:",
+  "editor.record.deleteError.closeMessage": "Verstanden",
+  "editor.record.deleteError.title": "Fehler beim Löschen des Datensatzes",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "Seite",
   "pagination.pageOf": "von",
   "previous": "zurück",
+  "record.action.delete": "Löschen",
   "record.action.download": "Herunterladen",
   "record.action.duplicate": "",
   "record.action.view": "Anzeigen",
diff --git a/translations/en.json b/translations/en.json
index 97dfeaf85b..09a7b63809 100644
--- a/translations/en.json
+++ b/translations/en.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "unknown",
   "downloads.wfs.featuretype.not.found": "The layer was not found",
   "dropFile": "drop file",
+  "editor.record.delete.confirmation.cancelText": "Cancel",
+  "editor.record.delete.confirmation.confirmText": "Delete",
+  "editor.record.delete.confirmation.message": "Are you sure you want to delete this record?",
+  "editor.record.delete.confirmation.title": "Delete record?",
+  "editor.record.deleteError.body": "The record could not be deleted:",
+  "editor.record.deleteError.closeMessage": "Understood",
+  "editor.record.deleteError.title": "Error deleting record",
   "editor.record.form.bottomButtons.comeBackLater": "Come back later",
   "editor.record.form.bottomButtons.next": "Next",
   "editor.record.form.bottomButtons.previous": "Previous",
@@ -298,6 +305,7 @@
   "pagination.page": "page",
   "pagination.pageOf": "of",
   "previous": "previous",
+  "record.action.delete": "Delete",
   "record.action.download": "Download",
   "record.action.duplicate": "Duplicate",
   "record.action.view": "View",
diff --git a/translations/es.json b/translations/es.json
index bef8b6ed2f..07f31e9d3c 100644
--- a/translations/es.json
+++ b/translations/es.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "",
   "downloads.wfs.featuretype.not.found": "",
   "dropFile": "",
+  "editor.record.delete.confirmation.cancelText": "",
+  "editor.record.delete.confirmation.confirmText": "",
+  "editor.record.delete.confirmation.message": "",
+  "editor.record.delete.confirmation.title": "",
+  "editor.record.deleteError.body": "",
+  "editor.record.deleteError.closeMessage": "",
+  "editor.record.deleteError.title": "",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "",
   "pagination.pageOf": "",
   "previous": "",
+  "record.action.delete": "",
   "record.action.download": "",
   "record.action.duplicate": "",
   "record.action.view": "",
diff --git a/translations/fr.json b/translations/fr.json
index c6639fe31c..cbb09a3aae 100644
--- a/translations/fr.json
+++ b/translations/fr.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "inconnu",
   "downloads.wfs.featuretype.not.found": "La couche n'a pas été retrouvée",
   "dropFile": "Faites glisser votre fichier",
+  "editor.record.delete.confirmation.cancelText": "Annuler",
+  "editor.record.delete.confirmation.confirmText": "Supprimer",
+  "editor.record.delete.confirmation.message": "Etes-vous sûr de vouloir supprimer cette fiche ?",
+  "editor.record.delete.confirmation.title": "Supprimer la fiche",
+  "editor.record.deleteError.body": "La fiche n'a pas pu être supprimée :",
+  "editor.record.deleteError.closeMessage": "Compris",
+  "editor.record.deleteError.title": "Erreur lors de la suppression",
   "editor.record.form.bottomButtons.comeBackLater": "Revenir plus tard",
   "editor.record.form.bottomButtons.next": "Suivant",
   "editor.record.form.bottomButtons.previous": "Précédent",
@@ -208,15 +215,15 @@
   "editor.record.form.temporalExtents.date": "Date concernée",
   "editor.record.form.temporalExtents.range": "Période concernée",
   "editor.record.form.updateFrequency.planned": "Ces données doivent être mise à jour régulièrement.",
-  "editor.record.loadError.body": "",
-  "editor.record.loadError.closeMessage": "",
-  "editor.record.loadError.title": "",
-  "editor.record.publish": "",
-  "editor.record.publishError.body": "",
-  "editor.record.publishError.closeMessage": "",
-  "editor.record.publishError.title": "",
-  "editor.record.publishSuccess.body": "",
-  "editor.record.publishSuccess.title": "",
+  "editor.record.loadError.body": "La fiche n'a pas pu être chargée :",
+  "editor.record.loadError.closeMessage": "Compris",
+  "editor.record.loadError.title": "Erreur lors du chargement",
+  "editor.record.publish": "Publier cette fiche",
+  "editor.record.publishError.body": "La fiche n'a pas pu être publiée :",
+  "editor.record.publishError.closeMessage": "Compris",
+  "editor.record.publishError.title": "Erreur lors de la publication",
+  "editor.record.publishSuccess.body": "La fiche a bien été publiée !",
+  "editor.record.publishSuccess.title": "Publication réussie",
   "editor.record.saveStatus.asDraftOnly": "Brouillon enregistré - fiche non publiée",
   "editor.record.saveStatus.draftWithChangesPending": "Brouillon enregistré - modifications en cours",
   "editor.record.saveStatus.recordUpToDate": "La fiche publiée est à jour",
@@ -298,6 +305,7 @@
   "pagination.page": "page",
   "pagination.pageOf": "sur",
   "previous": "précédent",
+  "record.action.delete": "Supprimer",
   "record.action.download": "Télécharger",
   "record.action.duplicate": "Dupliquer",
   "record.action.view": "Voir",
diff --git a/translations/it.json b/translations/it.json
index 8e942a7316..c72244392c 100644
--- a/translations/it.json
+++ b/translations/it.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "sconosciuto",
   "downloads.wfs.featuretype.not.found": "Il layer non è stato trovato",
   "dropFile": "Trascina il suo file",
+  "editor.record.delete.confirmation.cancelText": "",
+  "editor.record.delete.confirmation.confirmText": "",
+  "editor.record.delete.confirmation.message": "",
+  "editor.record.delete.confirmation.title": "",
+  "editor.record.deleteError.body": "",
+  "editor.record.deleteError.closeMessage": "",
+  "editor.record.deleteError.title": "",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "pagina",
   "pagination.pageOf": "di",
   "previous": "precedente",
+  "record.action.delete": "",
   "record.action.download": "Scarica",
   "record.action.duplicate": "",
   "record.action.view": "Visualizza",
diff --git a/translations/nl.json b/translations/nl.json
index 050ac145c5..aa531bd9c9 100644
--- a/translations/nl.json
+++ b/translations/nl.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "",
   "downloads.wfs.featuretype.not.found": "",
   "dropFile": "",
+  "editor.record.delete.confirmation.cancelText": "",
+  "editor.record.delete.confirmation.confirmText": "",
+  "editor.record.delete.confirmation.message": "",
+  "editor.record.delete.confirmation.title": "",
+  "editor.record.deleteError.body": "",
+  "editor.record.deleteError.closeMessage": "",
+  "editor.record.deleteError.title": "",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "",
   "pagination.pageOf": "",
   "previous": "",
+  "record.action.delete": "",
   "record.action.download": "",
   "record.action.duplicate": "",
   "record.action.view": "",
diff --git a/translations/pt.json b/translations/pt.json
index 62897470fb..86c2e5a0fc 100644
--- a/translations/pt.json
+++ b/translations/pt.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "",
   "downloads.wfs.featuretype.not.found": "",
   "dropFile": "",
+  "editor.record.delete.confirmation.cancelText": "",
+  "editor.record.delete.confirmation.confirmText": "",
+  "editor.record.delete.confirmation.message": "",
+  "editor.record.delete.confirmation.title": "",
+  "editor.record.deleteError.body": "",
+  "editor.record.deleteError.closeMessage": "",
+  "editor.record.deleteError.title": "",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "",
   "pagination.pageOf": "",
   "previous": "",
+  "record.action.delete": "",
   "record.action.download": "",
   "record.action.duplicate": "",
   "record.action.view": "",
diff --git a/translations/sk.json b/translations/sk.json
index 5065f5eb8e..16b9c17267 100644
--- a/translations/sk.json
+++ b/translations/sk.json
@@ -165,6 +165,13 @@
   "downloads.format.unknown": "neznámy",
   "downloads.wfs.featuretype.not.found": "Vrstva nebola nájdená",
   "dropFile": "nahrať súbor",
+  "editor.record.delete.confirmation.cancelText": "",
+  "editor.record.delete.confirmation.confirmText": "",
+  "editor.record.delete.confirmation.message": "",
+  "editor.record.delete.confirmation.title": "",
+  "editor.record.deleteError.body": "",
+  "editor.record.deleteError.closeMessage": "",
+  "editor.record.deleteError.title": "",
   "editor.record.form.bottomButtons.comeBackLater": "",
   "editor.record.form.bottomButtons.next": "",
   "editor.record.form.bottomButtons.previous": "",
@@ -298,6 +305,7 @@
   "pagination.page": "strana",
   "pagination.pageOf": "z",
   "previous": "predchádzajúci",
+  "record.action.delete": "",
   "record.action.download": "Stiahnuť",
   "record.action.duplicate": "",
   "record.action.view": "Zobraziť",

From 01dfc84d5e127bd426238dd00395faa1697f0eaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 7 Aug 2024 16:40:11 +0200
Subject: [PATCH 07/13] test(editor): shallow unit tests for deletion with
 ng-mocks

---
 .../dashboard-menu.component.spec.ts          |  29 ++---
 .../dashboard-page.component.spec.ts          |  15 +--
 .../search-header.component.spec.ts           |   7 +-
 .../sidebar/sidebar.component.spec.ts         |  64 +++--------
 .../src/app/edit/edit-page.component.spec.ts  |   2 -
 .../src/app/new-record.resolver.spec.ts       |   1 +
 .../my-draft/my-draft.component.spec.ts       |  46 ++------
 apps/metadata-editor/src/test-setup.ts        |  38 +++++++
 .../results-table-container.component.spec.ts | 100 +++++-------------
 libs/feature/search/src/test-setup.ts         |  32 ++++++
 .../confirmation-dialog.component.spec.ts     |  15 +++
 libs/ui/elements/src/test-setup.ts            |  15 +++
 package-lock.json                             |  16 +++
 package.json                                  |   1 +
 14 files changed, 185 insertions(+), 196 deletions(-)

diff --git a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
index a4c4eccd82..f6160ffb1a 100644
--- a/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
+++ b/apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.spec.ts
@@ -1,39 +1,26 @@
-import { NO_ERRORS_SCHEMA } from '@angular/core'
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 import { ActivatedRoute } from '@angular/router'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
-import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
 import { TranslateModule } from '@ngx-translate/core'
 import { cold, hot } from 'jasmine-marbles'
-import { of } from 'rxjs'
+import { MockBuilder, MockProviders } from 'ng-mocks'
 import { DashboardMenuComponent } from './dashboard-menu.component'
 
-class RecordsRepositoryMock {
-  draftsChanged$ = of(void 0)
-  getAllDrafts = jest.fn().mockReturnValue(of(DATASET_RECORDS))
-}
-
 describe('DashboardMenuComponent', () => {
   let component: DashboardMenuComponent
   let fixture: ComponentFixture<DashboardMenuComponent>
-  let recordsRepository: RecordsRepositoryMock
+  let recordsRepository: RecordsRepositoryInterface
+
+  beforeEach(() => {
+    return MockBuilder(DashboardMenuComponent)
+  })
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [DashboardMenuComponent, TranslateModule.forRoot()],
-      providers: [
-        {
-          provide: ActivatedRoute,
-          useValue: { params: of({ id: 1 }) },
-        },
-        {
-          provide: RecordsRepositoryInterface,
-          useClass: RecordsRepositoryMock,
-        },
-      ],
-      schemas: [NO_ERRORS_SCHEMA],
+      providers: [MockProviders(ActivatedRoute, RecordsRepositoryInterface)],
     }).compileComponents()
-    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface)
     fixture = TestBed.createComponent(DashboardMenuComponent)
     component = fixture.componentInstance
     fixture.detectChanges()
diff --git a/apps/metadata-editor/src/app/dashboard/dashboard-page.component.spec.ts b/apps/metadata-editor/src/app/dashboard/dashboard-page.component.spec.ts
index 036765507b..6f3395deb0 100644
--- a/apps/metadata-editor/src/app/dashboard/dashboard-page.component.spec.ts
+++ b/apps/metadata-editor/src/app/dashboard/dashboard-page.component.spec.ts
@@ -1,21 +1,16 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
+import { MockBuilder } from 'ng-mocks'
 import { DashboardPageComponent } from './dashboard-page.component'
-import { CommonModule } from '@angular/common'
 
 describe('DashboardPageComponent', () => {
   let component: DashboardPageComponent
   let fixture: ComponentFixture<DashboardPageComponent>
 
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({})
-      .overrideComponent(DashboardPageComponent, {
-        set: {
-          imports: [CommonModule],
-          providers: [],
-        },
-      })
-      .compileComponents()
+  beforeEach(() => {
+    return MockBuilder(DashboardPageComponent)
+  })
 
+  beforeEach(() => {
     fixture = TestBed.createComponent(DashboardPageComponent)
     component = fixture.componentInstance
     fixture.detectChanges()
diff --git a/apps/metadata-editor/src/app/dashboard/search-header/search-header.component.spec.ts b/apps/metadata-editor/src/app/dashboard/search-header/search-header.component.spec.ts
index e0337e836a..8e897166be 100644
--- a/apps/metadata-editor/src/app/dashboard/search-header/search-header.component.spec.ts
+++ b/apps/metadata-editor/src/app/dashboard/search-header/search-header.component.spec.ts
@@ -1,8 +1,4 @@
-import {
-  ChangeDetectionStrategy,
-  CUSTOM_ELEMENTS_SCHEMA,
-  NO_ERRORS_SCHEMA,
-} from '@angular/core'
+import { ChangeDetectionStrategy, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { SearchHeaderComponent } from './search-header.component'
@@ -37,7 +33,6 @@ describe('SearchHeaderComponent', () => {
         StoreModule.forRoot({}),
         TranslateModule.forRoot(TRANSLATE_DEFAULT_CONFIG),
       ],
-      schemas: [NO_ERRORS_SCHEMA],
       providers: [
         {
           provide: AvatarServiceInterface,
diff --git a/apps/metadata-editor/src/app/dashboard/sidebar/sidebar.component.spec.ts b/apps/metadata-editor/src/app/dashboard/sidebar/sidebar.component.spec.ts
index 362fb48249..50982f3777 100644
--- a/apps/metadata-editor/src/app/dashboard/sidebar/sidebar.component.spec.ts
+++ b/apps/metadata-editor/src/app/dashboard/sidebar/sidebar.component.spec.ts
@@ -1,66 +1,30 @@
-import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core'
 import { ComponentFixture, TestBed } from '@angular/core/testing'
-import { of } from 'rxjs'
-import { SidebarComponent } from './sidebar.component'
-import { ActivatedRoute } from '@angular/router'
-import { TranslateModule } from '@ngx-translate/core'
-import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
-import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
-import { PlatformServiceInterface } from '@geonetwork-ui/common/domain/platform.service.interface'
 import { AvatarServiceInterface } from '@geonetwork-ui/api/repository'
 import { OrganizationsServiceInterface } from '@geonetwork-ui/common/domain/organizations.service.interface'
-
-class RecordsRepositoryMock {
-  getAllDrafts = jest.fn().mockReturnValue(of(DATASET_RECORDS))
-}
-
-class PlatformServiceMock {
-  getMe = jest.fn().mockReturnValue(of({ organisation: 'organisation' }))
-}
-
-class AvatarServiceInterfaceMock {
-  getPlaceholder = () => of('http://placeholder.com')
-}
-
-class OrganisationsServiceMock {
-  organisations$ = of([{ name: 'organisation' }])
-}
+import { PlatformServiceInterface } from '@geonetwork-ui/common/domain/platform.service.interface'
+import { TranslateModule } from '@ngx-translate/core'
+import { MockBuilder, MockProviders } from 'ng-mocks'
+import { SidebarComponent } from './sidebar.component'
 
 describe('SidebarComponent', () => {
   let component: SidebarComponent
   let fixture: ComponentFixture<SidebarComponent>
 
+  beforeEach(() => {
+    return MockBuilder(SidebarComponent)
+  })
+
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [SidebarComponent, TranslateModule.forRoot()],
       providers: [
-        {
-          provide: ActivatedRoute,
-          useValue: { params: of({ id: 1 }) },
-        },
-        {
-          provide: RecordsRepositoryInterface,
-          useClass: RecordsRepositoryMock,
-        },
-        {
-          provide: PlatformServiceInterface,
-          useClass: PlatformServiceMock,
-        },
-        {
-          provide: AvatarServiceInterface,
-          useClass: AvatarServiceInterfaceMock,
-        },
-        {
-          provide: OrganizationsServiceInterface,
-          useClass: OrganisationsServiceMock,
-        },
+        MockProviders(
+          PlatformServiceInterface,
+          AvatarServiceInterface,
+          OrganizationsServiceInterface
+        ),
       ],
-      schemas: [NO_ERRORS_SCHEMA],
-    })
-      .overrideComponent(SidebarComponent, {
-        set: { changeDetection: ChangeDetectionStrategy.Default },
-      })
-      .compileComponents()
+    }).compileComponents()
 
     fixture = TestBed.createComponent(SidebarComponent)
     component = fixture.componentInstance
diff --git a/apps/metadata-editor/src/app/edit/edit-page.component.spec.ts b/apps/metadata-editor/src/app/edit/edit-page.component.spec.ts
index 4889c0822c..6830ace538 100644
--- a/apps/metadata-editor/src/app/edit/edit-page.component.spec.ts
+++ b/apps/metadata-editor/src/app/edit/edit-page.component.spec.ts
@@ -1,7 +1,6 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 import { EditPageComponent } from './edit-page.component'
 import { ActivatedRoute, Router } from '@angular/router'
-import { NO_ERRORS_SCHEMA } from '@angular/core'
 import { DATASET_RECORDS, EDITOR_CONFIG } from '@geonetwork-ui/common/fixtures'
 import { BehaviorSubject, Subject } from 'rxjs'
 import { NotificationsService } from '@geonetwork-ui/feature/notifications'
@@ -49,7 +48,6 @@ describe('EditPageComponent', () => {
         TranslateModule.forRoot(),
         PageSelectorComponent,
       ],
-      schemas: [NO_ERRORS_SCHEMA],
       providers: [
         {
           provide: ActivatedRoute,
diff --git a/apps/metadata-editor/src/app/new-record.resolver.spec.ts b/apps/metadata-editor/src/app/new-record.resolver.spec.ts
index 6f88be9b7a..1f97a7f9ca 100644
--- a/apps/metadata-editor/src/app/new-record.resolver.spec.ts
+++ b/apps/metadata-editor/src/app/new-record.resolver.spec.ts
@@ -17,6 +17,7 @@ describe('NewRecordResolver', () => {
 
   describe('new record', () => {
     beforeEach(() => {
+      recordsRepository.generateTemporaryId = jest.fn(() => 'TEMP-ID-123')
       resolvedData = undefined
       resolver.resolve().subscribe((r) => (resolvedData = r))
     })
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
index 2a6607cb96..9abff1f58d 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.spec.ts
@@ -1,49 +1,25 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
-import { MyDraftComponent } from './my-draft.component'
-import { Component, importProvidersFrom } from '@angular/core'
-import { TranslateModule } from '@ngx-translate/core'
-import { RecordsListComponent } from '../records-list.component'
-import { of } from 'rxjs'
-import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { TranslateModule } from '@ngx-translate/core'
 import { cold, hot } from 'jasmine-marbles'
-
-@Component({
-  selector: 'md-editor-records-list',
-  template: '',
-  standalone: true,
-})
-export class MockRecordsListComponent {}
-
-class RecordsRepositoryMock {
-  draftsChanged$ = of(void 0)
-  getAllDrafts = jest.fn().mockReturnValue(of(DATASET_RECORDS))
-  draftIsTemporary = jest.fn()
-}
+import { MockBuilder, MockProvider } from 'ng-mocks'
+import { MyDraftComponent } from './my-draft.component'
 
 describe('MyDraftComponent', () => {
   let component: MyDraftComponent
   let fixture: ComponentFixture<MyDraftComponent>
-  let recordsRepository: RecordsRepositoryMock
+  let recordsRepository: RecordsRepositoryInterface
+
+  beforeEach(() => {
+    return MockBuilder(MyDraftComponent)
+  })
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      providers: [
-        importProvidersFrom(TranslateModule.forRoot()),
-        {
-          provide: RecordsRepositoryInterface,
-          useClass: RecordsRepositoryMock,
-        },
-      ],
-    }).overrideComponent(MyDraftComponent, {
-      remove: {
-        imports: [RecordsListComponent],
-      },
-      add: {
-        imports: [MockRecordsListComponent],
-      },
+      imports: [TranslateModule.forRoot()],
+      providers: [MockProvider(RecordsRepositoryInterface)],
     })
-    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface)
     fixture = TestBed.createComponent(MyDraftComponent)
     component = fixture.componentInstance
     fixture.detectChanges()
diff --git a/apps/metadata-editor/src/test-setup.ts b/apps/metadata-editor/src/test-setup.ts
index 1261469e19..37ff1f2a88 100644
--- a/apps/metadata-editor/src/test-setup.ts
+++ b/apps/metadata-editor/src/test-setup.ts
@@ -1,11 +1,23 @@
 import 'jest-preset-angular/setup-jest'
 import '../../../jest.setup'
 
+import { CommonModule } from '@angular/common'
 import { getTestBed } from '@angular/core/testing'
+import { MatDialogModule } from '@angular/material/dialog'
+import { MatIconModule } from '@angular/material/icon'
+import { BrowserModule } from '@angular/platform-browser'
 import {
   BrowserDynamicTestingModule,
   platformBrowserDynamicTesting,
 } from '@angular/platform-browser-dynamic/testing'
+import { RouterModule } from '@angular/router'
+import { AvatarServiceInterface } from '@geonetwork-ui/api/repository'
+import { PlatformServiceInterface } from '@geonetwork-ui/common/domain/platform.service.interface'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { SearchFacade } from '@geonetwork-ui/feature/search'
+import { TranslateModule } from '@ngx-translate/core'
+import { ngMocks } from 'ng-mocks'
+import { BehaviorSubject, EMPTY } from 'rxjs'
 
 getTestBed().resetTestEnvironment()
 getTestBed().initTestEnvironment(
@@ -13,3 +25,29 @@ getTestBed().initTestEnvironment(
   platformBrowserDynamicTesting(),
   { teardown: { destroyAfterEach: false } }
 )
+
+// ng-mocks global configuration
+ngMocks.autoSpy('jest')
+
+ngMocks.globalKeep(CommonModule, true)
+ngMocks.globalKeep(BrowserModule, true)
+ngMocks.globalKeep(RouterModule, true)
+ngMocks.globalKeep(TranslateModule, true)
+ngMocks.globalKeep(MatIconModule, true)
+
+ngMocks.defaultMock(AvatarServiceInterface, () => ({
+  getPlaceholder: jest.fn(),
+}))
+
+ngMocks.defaultMock(PlatformServiceInterface, () => ({
+  getMe: jest.fn(() => EMPTY),
+}))
+
+ngMocks.defaultMock(RecordsRepositoryInterface, () => ({
+  deleteRecord: jest.fn(() => EMPTY),
+  draftsChanged$: EMPTY,
+}))
+
+ngMocks.defaultMock(SearchFacade, () => ({
+  results$: new BehaviorSubject([]),
+}))
diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts b/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
index 9e842d087c..0ececc40ce 100644
--- a/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
+++ b/libs/feature/search/src/lib/results-table/results-table-container.component.spec.ts
@@ -1,83 +1,49 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
-import { By } from '@angular/platform-browser'
-import { NoopAnimationsModule } from '@angular/platform-browser/animations'
 import { SelectionService } from '@geonetwork-ui/api/repository'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
 import { DATASET_RECORDS } from '@geonetwork-ui/common/fixtures'
 import { NotificationsService } from '@geonetwork-ui/feature/notifications'
 import { TranslateModule } from '@ngx-translate/core'
-import { BehaviorSubject, of, throwError } from 'rxjs'
+import { MockBuilder, MockProviders } from 'ng-mocks'
+import { of, Subject, throwError } from 'rxjs'
 import { SearchFacade } from '../state/search.facade'
 import { SearchService } from '../utils/service/search.service'
 import { ResultsTableContainerComponent } from './results-table-container.component'
 
-class SearchFacadeMock {
-  results$ = new BehaviorSubject(DATASET_RECORDS)
-  resultsHits$ = new BehaviorSubject(1000)
-  setConfigRequestFields = jest.fn(() => this)
-  setSortBy = jest.fn(() => this)
-  sortBy$ = new BehaviorSubject<any>(['asc', 'updateDate'])
-  requestNewResults = jest.fn()
-}
-class SearchServiceMock {
-  setPage = jest.fn()
-  setSortBy = jest.fn()
-}
-class SelectionServiceMock {
-  selectRecords = jest.fn()
-  deselectRecords = jest.fn()
-  clearSelection = jest.fn()
-  selectedRecordsIdentifiers$ = new BehaviorSubject([])
-}
-class RecordsRepositoryMock {
-  recordHasDraft = jest.fn(() => false)
-  deleteRecord = jest.fn(() => of(void 0))
-  clearRecordDraft = jest.fn()
-}
-class NotificationsServiceMock {
-  showNotification = jest.fn()
-}
-
 describe('ResultsTableContainerComponent', () => {
   let component: ResultsTableContainerComponent
-  let searchFacade: SearchFacadeMock
-  let searchService: SearchServiceMock
-  let selectionService: SelectionServiceMock
-  let recordsRepository: RecordsRepositoryMock
-  let notificationsService: NotificationsServiceMock
+  let searchFacade: SearchFacade
+  let searchService: SearchService
+  let selectionService: SelectionService
+  let recordsRepository: RecordsRepositoryInterface
+  let notificationsService: NotificationsService
   let fixture: ComponentFixture<ResultsTableContainerComponent>
 
+  beforeEach(() => {
+    return MockBuilder(ResultsTableContainerComponent)
+  })
+
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      imports: [TranslateModule.forRoot(), NoopAnimationsModule],
+      imports: [TranslateModule.forRoot()],
       providers: [
-        {
-          provide: SearchFacade,
-          useClass: SearchFacadeMock,
-        },
-        {
-          provide: SearchService,
-          useClass: SearchServiceMock,
-        },
-        {
-          provide: SelectionService,
-          useClass: SelectionServiceMock,
-        },
-        {
-          provide: RecordsRepositoryInterface,
-          useClass: RecordsRepositoryMock,
-        },
-        { provide: NotificationsService, useClass: NotificationsServiceMock },
+        MockProviders(
+          SearchFacade,
+          SearchService,
+          SelectionService,
+          RecordsRepositoryInterface,
+          NotificationsService
+        ),
       ],
     }).compileComponents()
 
     fixture = TestBed.createComponent(ResultsTableContainerComponent)
-    searchFacade = TestBed.inject(SearchFacade) as any
-    searchService = TestBed.inject(SearchService) as any
-    selectionService = TestBed.inject(SelectionService) as any
-    recordsRepository = TestBed.inject(RecordsRepositoryInterface) as any
-    notificationsService = TestBed.inject(NotificationsService) as any
+    searchFacade = TestBed.inject(SearchFacade)
+    searchService = TestBed.inject(SearchService)
+    selectionService = TestBed.inject(SelectionService)
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface)
+    notificationsService = TestBed.inject(NotificationsService)
     component = fixture.componentInstance
     fixture.detectChanges()
   })
@@ -97,7 +63,7 @@ describe('ResultsTableContainerComponent', () => {
 
   describe('selection', () => {
     beforeEach(() => {
-      searchFacade.results$.next([
+      ;(searchFacade.results$ as Subject<CatalogRecord[]>).next([
         {
           uniqueIdentifier: '1',
         },
@@ -128,10 +94,7 @@ describe('ResultsTableContainerComponent', () => {
     })
 
     it('emits a recordClick event', () => {
-      const tableRow = fixture.debugElement.queryAll(
-        By.css('.table-row-cell')
-      )[1].nativeElement as HTMLDivElement
-      tableRow.parentElement.click()
+      component.handleRecordClick(DATASET_RECORDS[0])
       expect(clickedRecord).toEqual(DATASET_RECORDS[0])
     })
   })
@@ -145,15 +108,7 @@ describe('ResultsTableContainerComponent', () => {
     })
 
     it('emits a duplicateRecord event', () => {
-      const menuButton = fixture.debugElement.query(
-        By.css('[data-test="record-menu-button"]')
-      ).nativeElement as HTMLButtonElement
-      menuButton.click()
-      fixture.detectChanges()
-      const duplicateButton = fixture.debugElement.query(
-        By.css('[data-test="record-menu-duplicate-button"]')
-      ).nativeElement as HTMLButtonElement
-      duplicateButton.click()
+      component.handleDuplicateRecord(DATASET_RECORDS[0])
       expect(recordToBeDuplicated).toEqual(DATASET_RECORDS[0])
     })
   })
@@ -176,6 +131,7 @@ describe('ResultsTableContainerComponent', () => {
 
     describe('delete success', () => {
       it('shows notification', () => {
+        recordsRepository.deleteRecord = jest.fn(() => of(void 0))
         component.handleDeleteRecord(DATASET_RECORDS[0])
         expect(recordsRepository.deleteRecord).toHaveBeenCalled()
         expect(recordsRepository.clearRecordDraft).toHaveBeenCalled()
diff --git a/libs/feature/search/src/test-setup.ts b/libs/feature/search/src/test-setup.ts
index 70e41af1c8..027b08590d 100644
--- a/libs/feature/search/src/test-setup.ts
+++ b/libs/feature/search/src/test-setup.ts
@@ -1,11 +1,21 @@
 import 'jest-preset-angular/setup-jest'
 import '../../../../jest.setup'
 
+import { CommonModule } from '@angular/common'
 import { getTestBed } from '@angular/core/testing'
+import { MatIconModule } from '@angular/material/icon'
+import { BrowserModule } from '@angular/platform-browser'
 import {
   BrowserDynamicTestingModule,
   platformBrowserDynamicTesting,
 } from '@angular/platform-browser-dynamic/testing'
+import { RouterModule } from '@angular/router'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { TranslateModule } from '@ngx-translate/core'
+import { ngMocks } from 'ng-mocks'
+import { BehaviorSubject } from 'rxjs'
+import { SearchFacade } from './lib/state/search.facade'
+import { SearchService } from './lib/utils/service/search.service'
 
 getTestBed().resetTestEnvironment()
 getTestBed().initTestEnvironment(
@@ -13,3 +23,25 @@ getTestBed().initTestEnvironment(
   platformBrowserDynamicTesting(),
   { teardown: { destroyAfterEach: false } }
 )
+
+// ng-mocks global configuration
+ngMocks.autoSpy('jest')
+
+ngMocks.globalKeep(CommonModule, true)
+ngMocks.globalKeep(BrowserModule, true)
+ngMocks.globalKeep(RouterModule, true)
+ngMocks.globalKeep(TranslateModule, true)
+ngMocks.globalKeep(MatIconModule, true)
+
+ngMocks.defaultMock(RecordsRepositoryInterface, () => ({
+  clearRecordDraft: jest.fn(),
+  recordHasDraft: jest.fn(),
+}))
+
+ngMocks.defaultMock(SearchFacade, () => ({
+  results$: new BehaviorSubject([]),
+}))
+
+ngMocks.defaultMock(SearchService, () => ({
+  setSortBy: jest.fn(),
+}))
diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
index 952d289727..0bc6508618 100644
--- a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.spec.ts
@@ -1,13 +1,28 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
+import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog'
+import { MockBuilder, MockProvider } from 'ng-mocks'
 import { ConfirmationDialogComponent } from './confirmation-dialog.component'
 
 describe('ConfirmationDialogComponent', () => {
   let component: ConfirmationDialogComponent
   let fixture: ComponentFixture<ConfirmationDialogComponent>
 
+  beforeEach(() => {
+    return MockBuilder(ConfirmationDialogComponent)
+  })
+
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [ConfirmationDialogComponent],
+      providers: [
+        MockProvider(MatDialogRef),
+        MockProvider(MAT_DIALOG_DATA, {
+          title: 'title',
+          message: 'message',
+          confirmText: 'confirm',
+          cancelText: 'cancel',
+        }),
+      ],
     }).compileComponents()
   })
 
diff --git a/libs/ui/elements/src/test-setup.ts b/libs/ui/elements/src/test-setup.ts
index 19b403b6c7..73bc92687d 100644
--- a/libs/ui/elements/src/test-setup.ts
+++ b/libs/ui/elements/src/test-setup.ts
@@ -6,6 +6,12 @@ import {
   BrowserDynamicTestingModule,
   platformBrowserDynamicTesting,
 } from '@angular/platform-browser-dynamic/testing'
+import { ngMocks } from 'ng-mocks'
+import { CommonModule } from '@angular/common'
+import { BrowserModule } from '@angular/platform-browser'
+import { TranslateModule } from '@ngx-translate/core'
+import { MatIconModule } from '@angular/material/icon'
+import { MatTooltipModule } from '@angular/material/tooltip'
 
 getTestBed().resetTestEnvironment()
 getTestBed().initTestEnvironment(
@@ -20,3 +26,12 @@ class ResizeObserverMock {
 }
 
 ;(window as any).ResizeObserver = ResizeObserverMock
+
+// ng-mocks global configuration
+ngMocks.autoSpy('jest')
+
+ngMocks.globalKeep(CommonModule, true)
+ngMocks.globalKeep(BrowserModule, true)
+ngMocks.globalKeep(TranslateModule, true)
+ngMocks.globalKeep(MatIconModule, true)
+ngMocks.globalKeep(MatTooltipModule, true)
diff --git a/package-lock.json b/package-lock.json
index 9c0760ac11..0bd5abcb9f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -127,6 +127,7 @@
         "jest-canvas-mock": "2.5.2",
         "jest-environment-jsdom": "29.6.2",
         "jest-preset-angular": "13.1.1",
+        "ng-mocks": "^14.13.0",
         "ng-packagr": "^16.2.3",
         "ngrx-store-freeze": "^0.2.4",
         "ngx-translate-testing": "^6.1.0",
@@ -24221,6 +24222,21 @@
       "resolved": "https://registry.npmjs.org/neo-async/-/neo-async-2.6.2.tgz",
       "integrity": "sha512-Yd3UES5mWCSqR+qNT93S3UoYUkqAZ9lLg8a7g9rimsWmYGK8cVToA4/sF3RrshdyV3sAGMXVUmpMYOw+dLpOuw=="
     },
+    "node_modules/ng-mocks": {
+      "version": "14.13.0",
+      "resolved": "https://registry.npmjs.org/ng-mocks/-/ng-mocks-14.13.0.tgz",
+      "integrity": "sha512-cQ6nUj/P+v7X52gYU6bAj/03iDKl2pzbPy2V0tx/d5lxME063Vxc190p6UPlJkbRIxcB+OqSALPgQvy83efzjw==",
+      "dev": true,
+      "funding": {
+        "url": "https://github.com/sponsors/help-me-mom"
+      },
+      "peerDependencies": {
+        "@angular/common": "5.0.0-alpha - 5 || 6.0.0-alpha - 6 || 7.0.0-alpha - 7 || 8.0.0-alpha - 8 || 9.0.0-alpha - 9 || 10.0.0-alpha - 10 || 11.0.0-alpha - 11 || 12.0.0-alpha - 12 || 13.0.0-alpha - 13 || 14.0.0-alpha - 14 || 15.0.0-alpha - 15 || 16.0.0-alpha - 16 || 17.0.0-alpha - 17 || 18.0.0-alpha - 18",
+        "@angular/core": "5.0.0-alpha - 5 || 6.0.0-alpha - 6 || 7.0.0-alpha - 7 || 8.0.0-alpha - 8 || 9.0.0-alpha - 9 || 10.0.0-alpha - 10 || 11.0.0-alpha - 11 || 12.0.0-alpha - 12 || 13.0.0-alpha - 13 || 14.0.0-alpha - 14 || 15.0.0-alpha - 15 || 16.0.0-alpha - 16 || 17.0.0-alpha - 17 || 18.0.0-alpha - 18",
+        "@angular/forms": "5.0.0-alpha - 5 || 6.0.0-alpha - 6 || 7.0.0-alpha - 7 || 8.0.0-alpha - 8 || 9.0.0-alpha - 9 || 10.0.0-alpha - 10 || 11.0.0-alpha - 11 || 12.0.0-alpha - 12 || 13.0.0-alpha - 13 || 14.0.0-alpha - 14 || 15.0.0-alpha - 15 || 16.0.0-alpha - 16 || 17.0.0-alpha - 17 || 18.0.0-alpha - 18",
+        "@angular/platform-browser": "5.0.0-alpha - 5 || 6.0.0-alpha - 6 || 7.0.0-alpha - 7 || 8.0.0-alpha - 8 || 9.0.0-alpha - 9 || 10.0.0-alpha - 10 || 11.0.0-alpha - 11 || 12.0.0-alpha - 12 || 13.0.0-alpha - 13 || 14.0.0-alpha - 14 || 15.0.0-alpha - 15 || 16.0.0-alpha - 16 || 17.0.0-alpha - 17 || 18.0.0-alpha - 18"
+      }
+    },
     "node_modules/ng-packagr": {
       "version": "16.2.3",
       "resolved": "https://registry.npmjs.org/ng-packagr/-/ng-packagr-16.2.3.tgz",
diff --git a/package.json b/package.json
index eca918b93a..bd6d8547c0 100644
--- a/package.json
+++ b/package.json
@@ -162,6 +162,7 @@
     "jest-canvas-mock": "2.5.2",
     "jest-environment-jsdom": "29.6.2",
     "jest-preset-angular": "13.1.1",
+    "ng-mocks": "^14.13.0",
     "ng-packagr": "^16.2.3",
     "ngrx-store-freeze": "^0.2.4",
     "ngx-translate-testing": "^6.1.0",

From 06105fc39b746ebd7f30c588dfcc337c1c3f2bbd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Thu, 8 Aug 2024 14:42:13 +0200
Subject: [PATCH 08/13] refactor(editor): rename draft functions

---
 .../src/app/records/my-draft/my-draft.component.html       | 5 ++---
 .../src/app/records/my-draft/my-draft.component.ts         | 4 ++--
 libs/api/repository/src/lib/gn4/gn4-repository.ts          | 2 +-
 .../src/lib/repository/records-repository.interface.ts     | 2 +-
 .../results-table/results-table-container.component.html   | 2 +-
 .../results-table/action-menu/action-menu.component.html   | 4 ++--
 .../lib/results-table/action-menu/action-menu.component.ts | 4 ++--
 .../src/lib/results-table/results-table.component.html     | 6 +++---
 .../src/lib/results-table/results-table.component.ts       | 7 ++++---
 9 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
index bc95b84bc0..939b1b1ff0 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
@@ -10,9 +10,8 @@ <h1 class="text-[16px] text-main font-title font-bold" translate>
   >
     <gn-ui-results-table
       [records]="records$ | async"
-      [recordHasDraft]="hasDraft"
-      [recordIsDraft]="isDraft"
-      [draftIsTemporary]="isTemporary"
+      [isDraft]="isDraft"
+      [isDraftWithoutRecord]="isDraftIdTemporary"
       (recordClick)="editRecord($event)"
       (deleteRecord)="deleteDraft($event)"
     ></gn-ui-results-table>
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
index 8ef05cf0b1..8c27fe0d96 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
@@ -38,8 +38,8 @@ export class MyDraftComponent {
   )
   hasDraft = () => true
   isDraft = () => true
-  isTemporary = (record: CatalogRecord): boolean =>
-    this.recordsRepository.draftIsTemporary(record.uniqueIdentifier)
+  isDraftIdTemporary = (record: CatalogRecord): boolean =>
+    this.recordsRepository.isDraftIdTemporary(record.uniqueIdentifier)
 
   constructor(
     private router: Router,
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index a8468763c2..23fdcb0348 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -333,7 +333,7 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     )
   }
 
-  draftIsTemporary(uniqueIdentifier: string): boolean {
+  isDraftIdTemporary(uniqueIdentifier: string): boolean {
     return uniqueIdentifier.startsWith('TEMP-ID-')
   }
 
diff --git a/libs/common/domain/src/lib/repository/records-repository.interface.ts b/libs/common/domain/src/lib/repository/records-repository.interface.ts
index 001453595b..8f2922072b 100644
--- a/libs/common/domain/src/lib/repository/records-repository.interface.ts
+++ b/libs/common/domain/src/lib/repository/records-repository.interface.ts
@@ -70,7 +70,7 @@ export abstract class RecordsRepositoryInterface {
 
   abstract clearRecordDraft(uniqueIdentifier: string): void
   abstract recordHasDraft(uniqueIdentifier: string): boolean
-  abstract draftIsTemporary(uniqueIdentifier: string): boolean
+  abstract isDraftIdTemporary(uniqueIdentifier: string): boolean
 
   /** will return all pending drafts, both published and not published */
   abstract getAllDrafts(): Observable<CatalogRecord[]>
diff --git a/libs/feature/search/src/lib/results-table/results-table-container.component.html b/libs/feature/search/src/lib/results-table/results-table-container.component.html
index 3310cf5e8a..a2be70d0af 100644
--- a/libs/feature/search/src/lib/results-table/results-table-container.component.html
+++ b/libs/feature/search/src/lib/results-table/results-table-container.component.html
@@ -1,6 +1,6 @@
 <gn-ui-results-table
   [records]="records$ | async"
-  [recordHasDraft]="hasDraft"
+  [hasDraft]="hasDraft"
   [selectedRecordsIdentifiers]="selectedRecords$ | async"
   [sortOrder]="sortBy$ | async"
   (recordClick)="handleRecordClick($event)"
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
index de020e865a..87532fb4f4 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.html
@@ -9,7 +9,7 @@
 <mat-menu #menu="matMenu">
   <button
     mat-menu-item
-    [disabled]="isDraft"
+    [disabled]="!canDuplicate"
     (click)="duplicate.emit()"
     data-test="record-menu-duplicate-button"
   >
@@ -17,7 +17,7 @@
   </button>
   <button
     mat-menu-item
-    [disabled]="!(isDraftOnly || !isDraft)"
+    [disabled]="!canDelete"
     (click)="openDeleteConfirmationDialog()"
     data-test="record-menu-delete-button"
   >
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
index b154e756fd..1218c10e9e 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
@@ -27,8 +27,8 @@ import { TranslateModule, TranslateService } from '@ngx-translate/core'
   ],
 })
 export class ActionMenuComponent {
-  @Input() isDraft: boolean
-  @Input() isDraftOnly: boolean
+  @Input() canDuplicate: boolean
+  @Input() canDelete: boolean
   @Output() duplicate = new EventEmitter<void>()
   @Output() delete = new EventEmitter<void>()
 
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.html b/libs/ui/search/src/lib/results-table/results-table.component.html
index f2cdade463..d0b95e7dc1 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.html
+++ b/libs/ui/search/src/lib/results-table/results-table.component.html
@@ -37,7 +37,7 @@
       <div class="flex flex-row items-center gap-2 max-w-full">
         <span class="overflow-hidden text-ellipsis">{{ item.title }}</span>
         <gn-ui-badge
-          *ngIf="recordHasDraft(item)"
+          *ngIf="hasDraft(item) || isDraft(item)"
           [style.--gn-ui-badge-padding]="'0.4em 0.6em'"
           [style.--gn-ui-badge-text-color]="'#3d2006'"
           [style.--gn-ui-badge-background-color]="'#ffbc7b'"
@@ -126,8 +126,8 @@
     <ng-template #header> </ng-template>
     <ng-template #cell let-item>
       <gn-ui-action-menu
-        [isDraft]="recordIsDraft(item)"
-        [isDraftOnly]="draftIsTemporary(item)"
+        [canDuplicate]="!isDraft(item)"
+        [canDelete]="isDraftWithoutRecord(item) || !isDraft(item)"
         (duplicate)="handleDuplicate(item)"
         (delete)="handleDelete(item)"
       >
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.ts b/libs/ui/search/src/lib/results-table/results-table.component.ts
index 017b24d2f3..684e0b6a1d 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.ts
+++ b/libs/ui/search/src/lib/results-table/results-table.component.ts
@@ -40,9 +40,10 @@ export class ResultsTableComponent {
   @Input() records: CatalogRecord[] = []
   @Input() selectedRecordsIdentifiers: string[] = []
   @Input() sortOrder: SortByField = null
-  @Input() recordHasDraft: (record: CatalogRecord) => boolean = () => false
-  @Input() recordIsDraft: (record: CatalogRecord) => boolean = () => false
-  @Input() draftIsTemporary: (record: CatalogRecord) => boolean = () => false
+  @Input() hasDraft: (record: CatalogRecord) => boolean = () => false
+  @Input() isDraft: (record: CatalogRecord) => boolean = () => false
+  @Input() isDraftWithoutRecord: (record: CatalogRecord) => boolean = () =>
+    false
 
   // emits the column (field) as well as the order
   @Output() sortByChange = new EventEmitter<[string, 'asc' | 'desc']>()

From 3b9da60d2ea02d8aa17d46a2a72ad10c50a3ccb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 14 Aug 2024 17:26:14 +0200
Subject: [PATCH 09/13] e2e(editor): wait on specific request

---
 apps/metadata-editor-e2e/src/e2e/delete.cy.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/apps/metadata-editor-e2e/src/e2e/delete.cy.ts b/apps/metadata-editor-e2e/src/e2e/delete.cy.ts
index c9500aa349..63dfb4932c 100644
--- a/apps/metadata-editor-e2e/src/e2e/delete.cy.ts
+++ b/apps/metadata-editor-e2e/src/e2e/delete.cy.ts
@@ -11,9 +11,12 @@ describe('delete', () => {
       cy.get('gn-ui-form-field[ng-reflect-model=abstract] textarea').type(
         'record abstract'
       )
+      cy.intercept({
+        method: 'PUT',
+        pathname: '**/records',
+      }).as('insertRecord')
       cy.get('md-editor-publish-button').click()
-      // eslint-disable-next-line cypress/no-unnecessary-waiting
-      cy.wait(1000) // waiting for publication
+      cy.wait('@insertRecord')
       cy.get('gn-ui-form-field[ng-reflect-model=abstract] textarea').type(
         'draft abstract'
       )

From 604e6b2ec779bd086018182b48810d851c724f72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 14 Aug 2024 17:27:49 +0200
Subject: [PATCH 10/13] feat(editor): make draft temp id more robust

---
 .../src/app/new-record.resolver.spec.ts               | 11 +++++++++--
 apps/metadata-editor/src/app/new-record.resolver.ts   |  7 +++++--
 libs/api/repository/src/lib/gn4/gn4-repository.ts     |  8 +++++++-
 .../lib/repository/records-repository.interface.ts    |  1 +
 4 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/apps/metadata-editor/src/app/new-record.resolver.spec.ts b/apps/metadata-editor/src/app/new-record.resolver.spec.ts
index 1f97a7f9ca..e77e545fcd 100644
--- a/apps/metadata-editor/src/app/new-record.resolver.spec.ts
+++ b/apps/metadata-editor/src/app/new-record.resolver.spec.ts
@@ -1,14 +1,20 @@
 import { TestBed } from '@angular/core/testing'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { MockProvider } from 'ng-mocks'
 import { NewRecordResolver } from './new-record.resolver'
 
 describe('NewRecordResolver', () => {
   let resolver: NewRecordResolver
   let resolvedData: [CatalogRecord, string, boolean]
+  let recordsRepository: RecordsRepositoryInterface
 
   beforeEach(() => {
-    TestBed.configureTestingModule({})
+    TestBed.configureTestingModule({
+      providers: [MockProvider(RecordsRepositoryInterface)],
+    })
     resolver = TestBed.inject(NewRecordResolver)
+    recordsRepository = TestBed.inject(RecordsRepositoryInterface)
   })
 
   it('should be created', () => {
@@ -20,6 +26,7 @@ describe('NewRecordResolver', () => {
       recordsRepository.generateTemporaryId = jest.fn(() => 'TEMP-ID-123')
       resolvedData = undefined
       resolver.resolve().subscribe((r) => (resolvedData = r))
+      recordsRepository.generateTemporaryId = jest.fn(() => 'TEMP-ID-123')
     })
     it('creates a new empty record with a pregenerated id', () => {
       expect(resolvedData).toMatchObject([
@@ -30,7 +37,7 @@ describe('NewRecordResolver', () => {
           status: 'ongoing',
           temporalExtents: [],
           title: expect.stringMatching(/^My new record/),
-          uniqueIdentifier: expect.stringMatching(/^TEMP-ID-/),
+          uniqueIdentifier: 'TEMP-ID-123',
         },
         null,
         false,
diff --git a/apps/metadata-editor/src/app/new-record.resolver.ts b/apps/metadata-editor/src/app/new-record.resolver.ts
index ec206eeb99..bfd2cc6a8d 100644
--- a/apps/metadata-editor/src/app/new-record.resolver.ts
+++ b/apps/metadata-editor/src/app/new-record.resolver.ts
@@ -1,15 +1,18 @@
 import { Injectable } from '@angular/core'
-import { Observable, of } from 'rxjs'
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
+import { RecordsRepositoryInterface } from '@geonetwork-ui/common/domain/repository/records-repository.interface'
+import { Observable, of } from 'rxjs'
 
 @Injectable({
   providedIn: 'root',
 })
 export class NewRecordResolver {
+  constructor(private recordsRepository: RecordsRepositoryInterface) {}
+
   resolve(): Observable<[CatalogRecord, string, boolean]> {
     return of([
       {
-        uniqueIdentifier: `TEMP-ID-${Date.now()}`,
+        uniqueIdentifier: this.recordsRepository.generateTemporaryId(),
         title: `My new record (${new Date().toISOString()})`,
         abstract: '',
         ownerOrganization: {},
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index 23fdcb0348..a527d85265 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -33,6 +33,8 @@ import {
 import { CatalogRecord } from '@geonetwork-ui/common/domain/model/record'
 import { HttpErrorResponse } from '@angular/common/http'
 
+const TEMPORARY_ID_PREFIX = 'TEMP-ID-'
+
 @Injectable()
 export class Gn4Repository implements RecordsRepositoryInterface {
   _draftsChanged = new Subject<void>()
@@ -241,7 +243,7 @@ export class Gn4Repository implements RecordsRepositoryInterface {
       switchMap(async (recordAsXml) => {
         const converter = findConverterForDocument(recordAsXml)
         const record = await converter.readRecord(recordAsXml)
-        record.uniqueIdentifier = `TEMP-ID-${Date.now()}`
+        record.uniqueIdentifier = `${TEMPORARY_ID_PREFIX}${Date.now()}`
         record.title = `${record.title} (Copy)`
         const xml = await converter.writeRecord(record, recordAsXml)
         window.localStorage.setItem(
@@ -303,6 +305,10 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     return this.gn4RecordsApi.deleteRecord(uniqueIdentifier)
   }
 
+  generateTemporaryId(): string {
+    return `${TEMPORARY_ID_PREFIX}${Date.now()}`
+  }
+
   saveRecordAsDraft(
     record: CatalogRecord,
     referenceRecordSource?: string
diff --git a/libs/common/domain/src/lib/repository/records-repository.interface.ts b/libs/common/domain/src/lib/repository/records-repository.interface.ts
index 8f2922072b..ca3cb4274b 100644
--- a/libs/common/domain/src/lib/repository/records-repository.interface.ts
+++ b/libs/common/domain/src/lib/repository/records-repository.interface.ts
@@ -58,6 +58,7 @@ export abstract class RecordsRepositoryInterface {
    */
   abstract deleteRecord(uniqueIdentifier: string): Observable<void>
 
+  abstract generateTemporaryId(): string
   /**
    * @param record
    * @param referenceRecordSource

From 199bba2f42c48b7453b66b4ebf520e91e2144d0e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 14 Aug 2024 17:29:19 +0200
Subject: [PATCH 11/13] storybook(ui-elements): document confirmation dialog
 response

---
 .../confirmation-dialog.component.stories.ts     | 16 ++++++++++++++--
 .../action-menu/action-menu.component.ts         |  4 ++--
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
index 6f4decc4ac..5cda484c54 100644
--- a/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
+++ b/libs/ui/elements/src/lib/confirmation-dialog/confirmation-dialog.component.stories.ts
@@ -6,17 +6,25 @@ import { ConfirmationDialogComponent } from './confirmation-dialog.component'
 
 @Component({
   selector: 'gn-ui-launcher',
-  template: ` <gn-ui-button (buttonClick)="launch()">Open</gn-ui-button> `,
+  template: `
+    <gn-ui-button (buttonClick)="launch()">Open</gn-ui-button>
+    <span *ngIf="confirmed === undefined">Waiting for a result</span>
+    <span *ngIf="confirmed">Confirmed</span>
+    <span *ngIf="confirmed === false">Canceled</span>
+  `,
 })
 class LaunchDialogComponent {
   @Input() title = ''
   @Input() message = ''
   @Input() confirmText = ''
   @Input() cancelText = ''
+
+  confirmed: boolean
+
   constructor(private _dialog: MatDialog) {}
 
   launch(): void {
-    this._dialog.open(ConfirmationDialogComponent, {
+    const dialogRef = this._dialog.open(ConfirmationDialogComponent, {
       data: {
         title: this.title,
         message: this.message,
@@ -24,6 +32,10 @@ class LaunchDialogComponent {
         cancelText: this.cancelText,
       },
     })
+
+    dialogRef.afterClosed().subscribe((confirmed) => {
+      this.confirmed = confirmed
+    })
   }
 }
 
diff --git a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
index 1218c10e9e..07732050d7 100644
--- a/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
+++ b/libs/ui/search/src/lib/results-table/action-menu/action-menu.component.ts
@@ -64,9 +64,9 @@ export class ActionMenuComponent {
 
     // Manually restore focus to the menu trigger since the element that
     // opens the dialog won't be in the DOM any more when the dialog closes.
-    dialogRef.afterClosed().subscribe((result) => {
+    dialogRef.afterClosed().subscribe((confirmed) => {
       this.trigger.focus()
-      if (result) {
+      if (confirmed) {
         this.delete.emit()
       }
     })

From d840db08b5a24b48c086d7f73808b0e1171ba07a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Wed, 14 Aug 2024 17:30:43 +0200
Subject: [PATCH 12/13] feat(editor): simplify canDuplicate canDelete
 resolution

---
 .../src/app/records/my-draft/my-draft.component.html        | 4 ++--
 .../src/app/records/my-draft/my-draft.component.ts          | 6 +++---
 libs/api/repository/src/lib/gn4/gn4-repository.ts           | 4 ++--
 .../src/lib/repository/records-repository.interface.ts      | 3 ++-
 .../src/lib/results-table/results-table.component.html      | 6 +++---
 .../search/src/lib/results-table/results-table.component.ts | 5 ++---
 6 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
index 939b1b1ff0..c9d8dbb4f2 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.html
@@ -10,8 +10,8 @@ <h1 class="text-[16px] text-main font-title font-bold" translate>
   >
     <gn-ui-results-table
       [records]="records$ | async"
-      [isDraft]="isDraft"
-      [isDraftWithoutRecord]="isDraftIdTemporary"
+      [canDuplicate]="canDuplicate"
+      [canDelete]="canDelete"
       (recordClick)="editRecord($event)"
       (deleteRecord)="deleteDraft($event)"
     ></gn-ui-results-table>
diff --git a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
index 8c27fe0d96..be61640ea4 100644
--- a/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
+++ b/apps/metadata-editor/src/app/records/my-draft/my-draft.component.ts
@@ -37,9 +37,9 @@ export class MyDraftComponent {
     startWith([])
   )
   hasDraft = () => true
-  isDraft = () => true
-  isDraftIdTemporary = (record: CatalogRecord): boolean =>
-    this.recordsRepository.isDraftIdTemporary(record.uniqueIdentifier)
+  canDuplicate = (): boolean => false
+  canDelete = (record: CatalogRecord): boolean =>
+    this.recordsRepository.isRecordNotYetSaved(record.uniqueIdentifier)
 
   constructor(
     private router: Router,
diff --git a/libs/api/repository/src/lib/gn4/gn4-repository.ts b/libs/api/repository/src/lib/gn4/gn4-repository.ts
index a527d85265..a31688b218 100644
--- a/libs/api/repository/src/lib/gn4/gn4-repository.ts
+++ b/libs/api/repository/src/lib/gn4/gn4-repository.ts
@@ -339,8 +339,8 @@ export class Gn4Repository implements RecordsRepositoryInterface {
     )
   }
 
-  isDraftIdTemporary(uniqueIdentifier: string): boolean {
-    return uniqueIdentifier.startsWith('TEMP-ID-')
+  isRecordNotYetSaved(uniqueIdentifier: string): boolean {
+    return uniqueIdentifier.startsWith(TEMPORARY_ID_PREFIX)
   }
 
   // generated by copilot
diff --git a/libs/common/domain/src/lib/repository/records-repository.interface.ts b/libs/common/domain/src/lib/repository/records-repository.interface.ts
index ca3cb4274b..e254465afe 100644
--- a/libs/common/domain/src/lib/repository/records-repository.interface.ts
+++ b/libs/common/domain/src/lib/repository/records-repository.interface.ts
@@ -59,6 +59,7 @@ export abstract class RecordsRepositoryInterface {
   abstract deleteRecord(uniqueIdentifier: string): Observable<void>
 
   abstract generateTemporaryId(): string
+
   /**
    * @param record
    * @param referenceRecordSource
@@ -71,7 +72,7 @@ export abstract class RecordsRepositoryInterface {
 
   abstract clearRecordDraft(uniqueIdentifier: string): void
   abstract recordHasDraft(uniqueIdentifier: string): boolean
-  abstract isDraftIdTemporary(uniqueIdentifier: string): boolean
+  abstract isRecordNotYetSaved(uniqueIdentifier: string): boolean
 
   /** will return all pending drafts, both published and not published */
   abstract getAllDrafts(): Observable<CatalogRecord[]>
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.html b/libs/ui/search/src/lib/results-table/results-table.component.html
index d0b95e7dc1..420f44fbde 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.html
+++ b/libs/ui/search/src/lib/results-table/results-table.component.html
@@ -37,7 +37,7 @@
       <div class="flex flex-row items-center gap-2 max-w-full">
         <span class="overflow-hidden text-ellipsis">{{ item.title }}</span>
         <gn-ui-badge
-          *ngIf="hasDraft(item) || isDraft(item)"
+          *ngIf="hasDraft(item)"
           [style.--gn-ui-badge-padding]="'0.4em 0.6em'"
           [style.--gn-ui-badge-text-color]="'#3d2006'"
           [style.--gn-ui-badge-background-color]="'#ffbc7b'"
@@ -126,8 +126,8 @@
     <ng-template #header> </ng-template>
     <ng-template #cell let-item>
       <gn-ui-action-menu
-        [canDuplicate]="!isDraft(item)"
-        [canDelete]="isDraftWithoutRecord(item) || !isDraft(item)"
+        [canDuplicate]="canDuplicate(item)"
+        [canDelete]="canDelete(item)"
         (duplicate)="handleDuplicate(item)"
         (delete)="handleDelete(item)"
       >
diff --git a/libs/ui/search/src/lib/results-table/results-table.component.ts b/libs/ui/search/src/lib/results-table/results-table.component.ts
index 684e0b6a1d..a475569e5b 100644
--- a/libs/ui/search/src/lib/results-table/results-table.component.ts
+++ b/libs/ui/search/src/lib/results-table/results-table.component.ts
@@ -41,9 +41,8 @@ export class ResultsTableComponent {
   @Input() selectedRecordsIdentifiers: string[] = []
   @Input() sortOrder: SortByField = null
   @Input() hasDraft: (record: CatalogRecord) => boolean = () => false
-  @Input() isDraft: (record: CatalogRecord) => boolean = () => false
-  @Input() isDraftWithoutRecord: (record: CatalogRecord) => boolean = () =>
-    false
+  @Input() canDuplicate: (record: CatalogRecord) => boolean = () => true
+  @Input() canDelete: (record: CatalogRecord) => boolean = () => true
 
   // emits the column (field) as well as the order
   @Output() sortByChange = new EventEmitter<[string, 'asc' | 'desc']>()

From eeb79bdcb6d1c6f3ca6127f0983de3edacf0efdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laure-H=C3=A9l=C3=A8ne=20Bruneton?=
 <laure-helene.bruneton@camptocamp.com>
Date: Mon, 19 Aug 2024 14:30:42 +0200
Subject: [PATCH 13/13] doc: ng-mocks progressively replacing custom mocks

---
 docs/guide/{best-practices.md => code-guide.md} | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
 rename docs/guide/{best-practices.md => code-guide.md} (90%)

diff --git a/docs/guide/best-practices.md b/docs/guide/code-guide.md
similarity index 90%
rename from docs/guide/best-practices.md
rename to docs/guide/code-guide.md
index 1c792ce806..87e92bd800 100644
--- a/docs/guide/best-practices.md
+++ b/docs/guide/code-guide.md
@@ -2,7 +2,7 @@
 outline: deep
 ---
 
-# Best practices
+# Code guide
 
 ## Standalone components
 
@@ -13,11 +13,24 @@ Standalone components have the following differences with legacy "non-standalone
 - Standalone components are _not_ declared in Angular Modules; instead, they act as their own module, declaring their own dependencies and providers
 - Standalone components can import either Angular modules or other standalone components
 
+Existing components are migrated progressively to become standalone as continuous improvement.
+All new components must be created as standalone.
+
 ## Testing
 
 ### Unit tests
 
-#### Mocking services
+#### ng-mocks
+
+Unit tests are meant to be shallow. We should only test the behaviour of a component or a service by controlling the inputs and dependencies, and checking the outputs and results.
+
+Angular provides many tools to clearly split the responsabilities between each components and services. The testing library `ng-mocks` relies on those tools, to provide an easy way to mock dependencies.
+
+See commit `01dfc84d5e127bd426238dd00395faa1697f0eaa` for a few examples.
+
+Unit tests are migrated progressively to use `ng-mocks`.
+
+#### Mocking services (legacy)
 
 One of the advantages of the Angular [dependency injection](https://angular.io/guide/dependency-injection-overview) system is the ability to use mock classes when testing a component or services.