From 0978e4bfb6555db9cfa6a56628a08b3ed8d4b755 Mon Sep 17 00:00:00 2001 From: Tobias Kohr Date: Wed, 22 Nov 2023 10:52:49 +0100 Subject: [PATCH] fix(md-converter): do not initialize updateFrequency with null --- .../src/lib/gn4/gn4.metadata.mapper.spec.ts | 2 -- .../api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.ts | 1 - .../src/lib/metadata-info/metadata-info.component.spec.ts | 4 ++-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.spec.ts b/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.spec.ts index f462b78ff2..4574665d33 100644 --- a/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.spec.ts +++ b/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.spec.ts @@ -96,7 +96,6 @@ describe('Gn4MetadataMapper', () => { website: new URL('http://my.org'), }, status: null, - updateFrequency: null, lineage: null, recordUpdated: null, distributions: [], @@ -136,7 +135,6 @@ describe('Gn4MetadataMapper', () => { website: new URL('http://my.org'), }, status: null, - updateFrequency: null, lineage: null, recordUpdated: null, distributions: [], diff --git a/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.ts b/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.ts index 9f782429fe..2870353baf 100644 --- a/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.ts +++ b/libs/api/metadata-converter/src/lib/gn4/gn4.metadata.mapper.ts @@ -22,7 +22,6 @@ export class Gn4MetadataMapper extends MetadataBaseMapper { const emptyRecord: Partial = { kind: 'dataset', status: null, - updateFrequency: null, lineage: null, recordUpdated: null, ownerOrganization: null, diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts index 0d4b55577f..6c1125c866 100644 --- a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts +++ b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts @@ -88,13 +88,13 @@ describe('MetadataInfoComponent', () => { }) }) describe('updateFrequency', () => { - describe('updateFrequency is null', () => { + describe('updateFrequency is not defined', () => { beforeEach(() => { fixture = TestBed.createComponent(MetadataInfoComponent) component = fixture.componentInstance component.metadata = { ...DATASET_RECORDS[0], - updateFrequency: null, + updateFrequency: undefined, } fixture.detectChanges() })