Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the select tool highlights identify results #818

Open
chughes-lincoln opened this issue Mar 15, 2023 · 4 comments
Open

Clicking the select tool highlights identify results #818

chughes-lincoln opened this issue Mar 15, 2023 · 4 comments
Assignees
Milestone

Comments

@chughes-lincoln
Copy link
Contributor

chughes-lincoln commented Mar 15, 2023

If you have identify highlight set to false for a layer, and select highlight set to true, clicking the select tool after an identification highlights all previous results (assuming you didn't clear your results after the identify)

i.e. Turn on pipelines in the demo. Identify a pipeline which doesn't highlight the result because it's set to false. Click Select and the pipeline highlights before you do a selection.

@theduckylittle theduckylittle added this to the 3.11.0 milestone Apr 21, 2023
@theduckylittle theduckylittle self-assigned this Apr 25, 2023
@theduckylittle theduckylittle added bug and removed bug labels Apr 25, 2023
@theduckylittle
Copy link
Member

Is this a bug or a feature?

For example, wanting to buffer the feature you just identified?

@chughes-lincoln
Copy link
Contributor Author

I would say a bug. If the admin wants users to be able to buffer identify results they can just set identify highlight to on.

With the identify tool you also often have several different datasets that are identifiable at once, with often overlapping geometries. Having all these results be highlighted when the user isn't expecting them can be confusing and doesn't provide much value. Clicking the correct result that you want to buffer can also be impossible.

Example below of how it looks with a surveys dataset:
image

@klassenjs klassenjs modified the milestones: 3.11.0, 3.12.0 May 19, 2023
@klassenjs klassenjs modified the milestones: 3.12.0, 3.13.0 Sep 15, 2023
@elil
Copy link
Member

elil commented Sep 30, 2023

This appears to also impact search (identify then search) which is certainly not a feature :)

I'm wondering about stop-gap measures like invoking a clear results in the beginning of search, select, etc. Hmm, that would also clear results from search or select results that are intended.

@chughes-lincoln
Copy link
Contributor Author

This also impacts measure (identify then measure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants