Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language codes are not consistent with ISO 639-2 #85

Closed
strogonoff opened this issue Aug 19, 2019 · 3 comments
Closed

Language codes are not consistent with ISO 639-2 #85

strogonoff opened this issue Aug 19, 2019 · 3 comments
Labels
question Further information is requested

Comments

@strogonoff
Copy link
Contributor

strogonoff commented Aug 19, 2019

For example, Malaysian is specified as may (e.g., the link https://www.geolexica.org/registers/#language-may), while the code appears to be msa.

@strogonoff strogonoff added the question Further information is requested label Aug 19, 2019
@ronaldtse
Copy link
Member

@strogonoff this problem is in the tc211-termbase gem:

Need to fix this:

  # TODO: read language_code from sheet
  def language_code
    # Hack to make ISO_639 gem work...
    lang = case language
    when "Dutch"
      "Dutch; Flemish"
    when "Spanish"
      "Spanish; Castilian"
    else
      language
    end
    ISO_639.find_by_english_name(lang).alpha3
  rescue
    raise StandardError.new("Failed to find alpha3 code for language: #{lang}")
  end

@ronaldtse
Copy link
Member

@skalee
Copy link
Contributor

skalee commented Jul 3, 2020

We should use the correct ISO 639-2 codes for terminology. Code for Malaysian was corrected quite some time ago. Ones pointed by @ronaldtse in above comment are also fixed. The last ones are being fixed in #137.

@skalee skalee closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants