Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authoritative sources where "(E)" is considered "Clause" #21

Open
ronaldtse opened this issue Jul 8, 2020 · 10 comments
Open

Fix authoritative sources where "(E)" is considered "Clause" #21

ronaldtse opened this issue Jul 8, 2020 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Member

Screen Shot 2020-07-08 at 4 30 33 PM

"(E)" here is part of the original document identifier, i.e. "ISO 19107:2019(E)", not the clause. This was a mistake in the original Excel file.

I propose we move all the "(E)" from "clause" to the "source":

  • source: "ISO 19107:2019(E)"
  • clause: "3.34"

Ping @skalee

@ronaldtse ronaldtse added the bug Something isn't working label Jul 8, 2020
@ronaldtse
Copy link
Member Author

ronaldtse commented Jul 8, 2020

There is an additional consideration that "ISO 19107:2019(F)" (French) or "ISO 19107:2019(R)" (Russian) exist too.

A translation that originates from the MLGT (this repository) should be clearly marked as such and differentiated against data that is sourced from external content (e.g. alternative language versions like "ISO 19107:2019(F)" or national standards like "JIS XXX:XXX").

(ping @strogonoff )

Relates to glossarist/glossarist-desktop#73

@skalee
Copy link
Contributor

skalee commented Jul 9, 2020

There is an additional consideration that "ISO 19107:2019(F)" (French) or "ISO 19107:2019(R)" (Russian) exist too.

@ronaldtse I'm not sure what you mean by that. There is no single occurrence of (F) or (R) in YAMLs.

In fact, grep -ho '(.)' concepts/concept-*.yaml|sort|uniq|tr '\n' ' ' produces following:

(+) (-) (/) (1) (2) (3) (6) (8) (A) (E) (H) (a) (b) (h) (i) (j) (n) (s) (t) (x) (y) (°) (λ) (ϕ) (и) (ы) (أ) (ب) (ز) (ع) (م) (ن) (∅) (屬) (恣) (曆) (逆) (類)

@skalee
Copy link
Contributor

skalee commented Jul 9, 2020

@strogonoff How to fix that in context of _revisions? Can I simply all the broken authoritative source clauses & refs everywhere, or should I add another revision, or what?

@skalee
Copy link
Contributor

skalee commented Jul 14, 2020

@ronaldtse @strogonoff Guys, I really need clarification before proceeding, especially on the _revisions thing.

@skalee
Copy link
Contributor

skalee commented Jul 30, 2020

@ronaldtse, @strogonoff?

@ronaldtse
Copy link
Member Author

@ronaldtse I'm not sure what you mean by that. There is no single occurrence of (F) or (R) in YAMLs.

It doesn't exist right now but they are allowed to exist, just like (E) does.

How to fix that in context of _revisions? Can I simply all the broken authoritative source clauses & refs everywhere, or should I add another revision, or what?

Ping @strogonoff , I believe we can fix all the clauses & refs in the data because the data we have is already the authoritative set.

@strogonoff
Copy link
Contributor

strogonoff commented Jul 30, 2020

It depends, if this register is not yet being used we can replace data in past revisions (that is the original revision, there’d be only one revision if it‘s not used yet), if it is used we should create a new revision (author could be used the same as the one from the initial revision, “automated migration”) and let all authors pull it, but if it is used we may also run in conflicts since authors may have done changes already.

@strogonoff
Copy link
Contributor

strogonoff commented Jul 30, 2020

Generally, once it’s being used, any migration presupposes downtime where no one is using the app and should be planned a while in advance with notice to app user.

@strogonoff
Copy link
Contributor

Since this isn’t breaking the app terribly as far as I can see, if people have worked on this registry we could schedule maintenance downtime for early August, coordinate it with some bigger app update and also do this migration.

@skalee
Copy link
Contributor

skalee commented Jul 30, 2020

Thanks @strogonoff! It explains a lot.

But now I have another question: if it's going to be a part of migration, should I use any specific toolset? For example, do you need it in JavaScript? Or can I prepare a Ruby script which will be run during migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants