New Release v1.5.2 - #patch #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps us avoid changing UNLISTED_ICON_SET's content on both the service and the k8s configuration. In order to achieve this, I'm assigning an empty string '' (since os.environ.get requires a default value), and removing that string with a simple loop.
This change improves readability of settings.py, and removes the double assignement, with a cleaner overall routine. UNLISTED_ICON_SETS is now assigned in settings.py using the function fetch_and_clean_unlisted_sets.
Previously, fetch_and_clean_unlisted_sets was specifically only usable to fetch an environment variable and clean it. In order to address this, this workflow has been separated. In settings.py, the environment variable is fetched and passed onto split_and_clean_string.
…isted-value PB-1083: Removed default icon set 'babs' from UNLISTED_ICON_SET
sami-nouidri-swisstopo
requested review from
ltkum
and removed request for
ltshb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment on DEV has been done and tested successfully. As such, I want to merge develop into master to conduct integration tests with the map viewer.
For reminder, this patch removes UNLISTED_ICON_SETS' default value, such that only the k8s configuration defines what sets are unlisted.