Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect tablespoon conversion #35

Open
barbmc opened this issue Feb 19, 2015 · 11 comments
Open

Incorrect tablespoon conversion #35

barbmc opened this issue Feb 19, 2015 · 11 comments

Comments

@barbmc
Copy link

barbmc commented Feb 19, 2015

Why does this conversion output 44 g?

var qtyunit = '3 tb';
qtyunit = Qty(qtyunit);
qtyunit = qtyunit.to('ml').toPrec('ml').toString();

@gentooboontoo
Copy link
Owner

Could you check your example? I just tried and it outputted 44ml as expected:

Qty('3tbs').to('ml').toPrec('ml').toString(); // => "44 ml"

There's also a typo in your example: tb instead of tbs.

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

There's 15mls in a tablespoon isn't there

Regards
Barbara

Date: Thu, 19 Feb 2015 00:18:35 -0800
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

Could you check your example? I just tried and it outputted 44ml as expected:

Qty('3tbs').to('ml').toPrec('ml').toString(); // => "44 ml"

There's also a typo in your example: tb instead of tbs.


Reply to this email directly or view it on GitHub.

@gentooboontoo
Copy link
Owner

According to several references, there's 14.7867648 ml in a tb (so approximately 44ml for three tb):

Qty('1 tbs').to('ml').toString(); // => "14.7867648 ml"
Qty('3 tbs').to('ml').toString(); // => "44.3602944 ml"

Do you have any issue when using it?

Whatever it be, I've added tb as tablespoon alias.

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

Ok.

--- Original Message ---

From: "Julien Sanchez" [email protected]
Sent: 19 February 2015 23:39
To: "gentooboontoo/js-quantities" [email protected]
Cc: "barbmc" [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

According to several references, there's 14.7867648 ml in a tb (so approximately 44ml for three tb):

Qty('1 tbs').to('ml').toString(); // => "14.7867648 ml"
Qty('3 tbs').to('ml').toString(); // => "44.3602944 ml"

Do you have any issue when using it?

Whatever it be, I've added tb as tablespoon alias.


Reply to this email directly or view it on GitHub:
#35 (comment)

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

Ok. How can I make it round up to 45 ml?

--- Original Message ---

From: "Julien Sanchez" [email protected]
Sent: 19 February 2015 23:39
To: "gentooboontoo/js-quantities" [email protected]
Cc: "barbmc" [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

According to several references, there's 14.7867648 ml in a tb (so approximately 44ml for three tb):

Qty('1 tbs').to('ml').toString(); // => "14.7867648 ml"
Qty('3 tbs').to('ml').toString(); // => "44.3602944 ml"

Do you have any issue when using it?

Whatever it be, I've added tb as tablespoon alias.


Reply to this email directly or view it on GitHub:
#35 (comment)

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

Actually I added to myself which is why it was there :)

--- Original Message ---

From: "Julien Sanchez" [email protected]
Sent: 19 February 2015 23:39
To: "gentooboontoo/js-quantities" [email protected]
Cc: "barbmc" [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

According to several references, there's 14.7867648 ml in a tb (so approximately 44ml for three tb):

Qty('1 tbs').to('ml').toString(); // => "14.7867648 ml"
Qty('3 tbs').to('ml').toString(); // => "44.3602944 ml"

Do you have any issue when using it?

Whatever it be, I've added tb as tablespoon alias.


Reply to this email directly or view it on GitHub:
#35 (comment)

@gentooboontoo
Copy link
Owner

Currently, there's no way to redefine units. You could update the tablespoon value in your own fork here by replacing 1.47867648e-5 with 1.5e-5:

https://github.com/gentooboontoo/js-quantities/blob/master/src/quantities.js#L117

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

Great thanks

--- Original Message ---

From: "Julien Sanchez" [email protected]
Sent: 20 February 2015 00:03
To: "gentooboontoo/js-quantities" [email protected]
Cc: "barbmc" [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

Currently, there's no way to redefine units. You could update the tablespoon value in your own fork here by replacing 1.47867648e-5 with 1.5e-5:

https://github.com/gentooboontoo/js-quantities/blob/master/src/quantities.js#L117


Reply to this email directly or view it on GitHub:
#35 (comment)

@barbmc
Copy link
Author

barbmc commented Feb 19, 2015

I can give you lots of other aliases if you like.

--- Original Message ---

From: "Julien Sanchez" [email protected]
Sent: 19 February 2015 23:39
To: "gentooboontoo/js-quantities" [email protected]
Cc: "barbmc" [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

According to several references, there's 14.7867648 ml in a tb (so approximately 44ml for three tb):

Qty('1 tbs').to('ml').toString(); // => "14.7867648 ml"
Qty('3 tbs').to('ml').toString(); // => "44.3602944 ml"

Do you have any issue when using it?

Whatever it be, I've added tb as tablespoon alias.


Reply to this email directly or view it on GitHub:
#35 (comment)

@gentooboontoo
Copy link
Owner

Willingly. I could add any missing unit with actual use and not conflicting with existing ones.

@barbmc
Copy link
Author

barbmc commented Feb 20, 2015

My complete list is attached. A lot of them won't be relevant to you as they come from recipes

Regards
Barbara

Date: Thu, 19 Feb 2015 06:04:25 -0800
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [js-quantities] Incorrect tablespoon conversion (#35)

Willingly. I could add any missing unit with actual use and not conflicting with existing ones.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants