Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catching all exceptions is dangerous #14

Closed
sourabhxyz opened this issue Jan 4, 2024 · 0 comments · Fixed by #17
Closed

Catching all exceptions is dangerous #14

sourabhxyz opened this issue Jan 4, 2024 · 0 comments · Fixed by #17
Assignees
@sourabhxyz

Comments

@sourabhxyz
Copy link
Member

Said wrt unsafe use of SomeException in codebase.
@sourabhxyz sourabhxyz self-assigned this Jan 4, 2024
sourabhxyz added a commit that referenced this issue Jan 4, 2024
@sourabhxyz
Feat #11 & #14: Placing transactions linearly and not catching all ex…
0865d31 
…ceptions
@sourabhxyz sourabhxyz mentioned this issue Jan 4, 2024
Merged
@sourabhxyz sourabhxyz linked a pull request Jan 4, 2024 that will close this issue
Feat #11, #14, #15, #16, #18 & #23 #17
Merged
sourabhxyz added a commit that referenced this issue Jan 5, 2024
@sourabhxyz
Feat #11, #14, #18: Bug fix - to be able to place buy orders as well
d8603fa
sourabhxyz added a commit that referenced this issue Jan 5, 2024
@sourabhxyz
Feat #11, #14, #18: Code improvements
8a389c8
brunjlar added a commit that referenced this issue Jan 5, 2024
@brunjlar
Merge pull request #17 from geniusyield/11-making-operation-robust
ac5d500 
Feat #11, #14, #15, #16, #18 & #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sourabhxyz sourabhxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat #11, #14, #15, #16, #18 & #23 geniusyield/market-maker
1 participant
@sourabhxyz