From 20c7aaf92afea7172cbd19d96a2bf857ce39a8b3 Mon Sep 17 00:00:00 2001 From: Gemma Hou Date: Tue, 3 Sep 2024 19:58:51 +0000 Subject: [PATCH] fix presubmit samples --- config/tests/samples/create/harness.go | 2 +- dev/tasks/run-e2e | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/tests/samples/create/harness.go b/config/tests/samples/create/harness.go index 657c6c84fe..87918b1d3f 100644 --- a/config/tests/samples/create/harness.go +++ b/config/tests/samples/create/harness.go @@ -670,7 +670,7 @@ func MaybeSkip(t *testing.T, name string, resources []*unstructured.Unstructured case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeNodeGroup"}: case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeNodeTemplate"}: case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeManagedSSLCertificate"}: - case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeServiceAttachment"}: + //case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeServiceAttachment"}: case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeSubnetwork"}: case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeTargetVPNGateway"}: case schema.GroupKind{Group: "compute.cnrm.cloud.google.com", Kind: "ComputeVPNGateway"}: diff --git a/dev/tasks/run-e2e b/dev/tasks/run-e2e index 4f9f36c7dd..16841dc8ea 100755 --- a/dev/tasks/run-e2e +++ b/dev/tasks/run-e2e @@ -74,7 +74,7 @@ if [[ -z "${TEST_TIMEOUT:-}" ]]; then fi echo "Using TEST_TIMEOUT=${TEST_TIMEOUT}" -# Run e2e tests against real gcp, capturing output +# Run e2e tests against mock gcp, capturing output GOLDEN_REQUEST_CHECKS=1 \ GOLDEN_OBJECT_CHECKS=1 \ WRITE_GOLDEN_OUTPUT=1 \