fix: log an error while trying to register ts-node #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
reviewed
Nov 10, 2023
src/utils/typescript.ts
Outdated
| swc: JSON.parse(process.env.TS_NODE_SWC ?? swc.toString()), | ||
| }); | ||
| } catch (err) { | ||
| console.error("hermione: an error occured while trying to register ts-node:", err); |
There was a problem hiding this comment.
while ts-node registration
может докинем еще значения, с которыми пытались зарегаться?
There was a problem hiding this comment.
Я сделал так, чтобы ловить любые ошибки при регистрации, чтобы ловить не только ошибки парсинга. Сейчас там пишется:
% TS_NODE_SWC=False npx hermione
SyntaxError: Unexpected token F in JSON at position 0
at JSON.parse (<anonymous>)
at tryToRegisterTsNode (.../node_modules/hermione/build/utils/typescript.js:29:27)
at new BaseHermione (.../node_modules/hermione/build/base-hermione.js:19:9)
...
There was a problem hiding this comment.
Могу в принципе и добавить эти значения
KuznetsovRoman
force-pushed
the
HERMIONE-1252.ts_node_err
branch
from
0f345b5 to
e5f4323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.