Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add example with DnD #1009

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore(examples): add example with DnD #1009

merged 1 commit into from
Sep 13, 2024

Conversation

sipayRT
Copy link
Member

@sipayRT sipayRT commented Sep 5, 2024

No description provided.

Comment on lines 38 to 41
devServer: {
command: "npm run server:dev"
},
Copy link
Member

@KuznetsovRoman KuznetsovRoman Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to pass SERVER_PORT as environment variable here:

    devServer: {
        command: "npm run server:dev",
        env: { PORT: SERVER_PORT },
    },

instead of passing the copy of it via npm script

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case you will not be able to run the dev-server separately with the same port (8080 by default)

@sipayRT sipayRT merged commit 9962f77 into master Sep 13, 2024
2 checks passed
@sipayRT sipayRT deleted the sp.dnd-example branch September 13, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants