Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentence case in welcome screen #961

Closed
heldderarbeit opened this issue Sep 19, 2024 · 1 comment · Fixed by #963
Closed

Use sentence case in welcome screen #961

heldderarbeit opened this issue Sep 19, 2024 · 1 comment · Fixed by #963

Comments

@heldderarbeit
Copy link

heldderarbeit commented Sep 19, 2024

Bug/Feature description

The text in the welcome screen when opening the app for the first time is mostly presented in Capitalized Case (but not for every word).

Screenshot from 2024-09-19 18-28-15

Select a Folder, or Drag Audiobooks Here to Add Them to Your Library

Maybe it would be easier to read if it were in Sentence case and without the comma:

Select a folder or drag audiobooks here to add them to your library

The comma seems not to be necessary in this case, since the main clauses are very short. It would also be consistent with English Capitalization Rules and consistent with the welcome screen for other Gnome apps, which usually use Sentence Case:

Screenshot from 2024-09-19 18-04-02


Screenshot from 2024-09-19 18-18-56

Screenshot from 2024-09-19 18-20-31

Screenshot from 2024-09-19 18-19-28

Steps to reproduce

Open the app for the first time

System Information

  • Operating System: Arch
  • Installation source: Flathub
  • Version of cozy: 1.3.0
@rdbende
Copy link
Collaborator

rdbende commented Sep 19, 2024

You're right, and I think I already had a local fix for this that I forgot to publish. Will fix soon

@rdbende rdbende linked a pull request Sep 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants