Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that sap.app.i18n.bundleUrl is not undefined #48

Open
gregorwolf opened this issue Jun 27, 2024 · 0 comments
Open

Add check that sap.app.i18n.bundleUrl is not undefined #48

gregorwolf opened this issue Jun 27, 2024 · 0 comments

Comments

@gregorwolf
Copy link
Collaborator

With #9 we've added Support for the manifest.json config sap.app.i18n.bundleUrl. But in cap-sflight the i18n configuration is done with bundleName. I've tried adding cds-launchpad-plugin with the commit gregorwolf/cap-sflight@53e0414 but get the following error when I access the Launchpad:

[cds] - ❗️Uncaught Error: ENOENT: no such file or directory, open '/Users/gwolf/Documents/Projects/cap/cap-sflight/app/travel_processor/webapp/undefined'
    at Object.openSync (node:fs:582:18)
    at Object.readFileSync (node:fs:461:35)
    at /Users/gwolf/Documents/Projects/cap/cap-sflight/node_modules/cds-launchpad-plugin/dist/index.js:199:57

The error occurs as bundleUrl is used without checking to be undefined.

I haven't found bundleName in the documentation Supported Locales and Fallback Chain. In Descriptor for Applications, Components, and Libraries (manifest.json) I find it only in the context of models. So I think the use in cap-sflight is incorrect.

But if you agree I will add a check that sap.app.i18n.bundleUrl is not undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant