Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicates #2

Open
onedanshow opened this issue Apr 26, 2013 · 3 comments
Open

Prevent duplicates #2

onedanshow opened this issue Apr 26, 2013 · 3 comments

Comments

@onedanshow
Copy link

Great extension. Thanks for adding it. My only recommendation is to add functionality to prevent duplicates from being added if a varient with the same option type already exists.

@geermc4
Copy link
Owner

geermc4 commented Apr 26, 2013

Prevent duplicates where?

@onedanshow
Copy link
Author

When one clicks the "Create All" button, the logic doesn't check to see a variant with the same option types already exists. I assume it would go here:

https://github.com/geermc4/spree_variant_all_options/blob/master/app/controllers/spree/admin/variants_controller_decorator.rb#L12

Else, it results in duplicate variants that the admin has to delete.

@geermc4
Copy link
Owner

geermc4 commented Apr 26, 2013

ah, true, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants