Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability between ee.Dictionary and ee.FeatureCollection #368

Closed
wants to merge 3 commits into from

Conversation

fitoprincipe
Copy link
Member

@fitoprincipe fitoprincipe commented Oct 31, 2024

Provide a way to convert a ee.Dictionary into a ee.FeatureCollection and viceversa.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1273b71). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage        ?   91.00%           
=======================================
  Files           ?       27           
  Lines           ?     1689           
  Branches        ?       80           
=======================================
  Hits            ?     1537           
  Misses          ?      130           
  Partials        ?       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split toTable and ToDictionary into 2 different PR so we can review them separately? I think the toDictionary is almost ready to go but I would like to spend more time on the toTable one.

@fitoprincipe
Copy link
Member Author

should we close this one?

@12rambau
Copy link
Member

12rambau commented Nov 8, 2024

superseded by #372 and #373

@12rambau 12rambau closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants