Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensible defaults for github release #76

Open
jasonkarns opened this issue Mar 21, 2014 · 1 comment
Open

sensible defaults for github release #76

jasonkarns opened this issue Mar 21, 2014 · 1 comment

Comments

@jasonkarns
Copy link

Presently, the github release step requires environment variables with username/password/token.

Git already has a mechanism for accessing this information: .gitconfig.

I submit that grunt-release should get the username/token from git config github.user and git config github.token respectively.

Further, the upstream branch that is used as the push target can be taken from git. It shouldn't need duplicated in the gruntfile:

git rev-parse --symbolic-full-name --abbrev-ref @{upstream}

@geddski
Copy link
Owner

geddski commented May 2, 2014

@jasonkarns not a bad idea, so long as people put it in .git/config and not .gitconfig which would be part of the repo. ENV vars are pretty common for this sort of thing though, so I'd be open to supporting both. You interested in submitting a PR for this?

As for the push target, it just executes a git push, relying on the info in .git/config for which remote the branch is tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants