Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display git push output #68

Open
patcon opened this issue Feb 20, 2014 · 4 comments
Open

Add option to display git push output #68

patcon opened this issue Feb 20, 2014 · 4 comments

Comments

@patcon
Copy link

patcon commented Feb 20, 2014

Heroku gives useful output on the deploy and its success. Would be great if grunt-release didn't swallow this useful data :)

Let me know if this sounds alright, and I'm happy to submit a PR.

@geddski
Copy link
Owner

geddski commented Feb 20, 2014

would be easy to implement, just make a "silent" option (defaults to true)
that in turn gets passed into shell.exec(cmd, {silent:true}), change that
to the silent option and voila. I'll happily accept a PR with this change,
please update the readme as well. Thanks!

On Wed, Feb 19, 2014 at 7:55 PM, Patrick Connolly
[email protected]:

Heroku gives useful output on the deploy and its success. Would be great
if grunt-release didn't swallow this useful data :)

Let me know if this sounds alright, and I'm happy to submit a PR.

Reply to this email directly or view it on GitHubhttps://github.com//issues/68
.

@patcon
Copy link
Author

patcon commented Feb 21, 2014

Awesome! Feel free to add me to a team with just "pull" access and assign it to me, so that it shows up on my issue dashboard :)

@geddski
Copy link
Owner

geddski commented Feb 21, 2014

hah didn't know about that little trick.

@patcon
Copy link
Author

patcon commented Feb 21, 2014

Oh wait. I forgot. It's not as clever as I thought. That just allows YOU to assign an issue to me, but I can't help myself by assigning it to me :/

Feel free to +1 this issue: isaacs/github#100

EDIT: Or wait, isaacs/github#153 is what this has to do with specifically :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants