Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeBump tasks don't exit immediately #135

Open
domtronn opened this issue Aug 18, 2015 · 2 comments
Open

beforeBump tasks don't exit immediately #135

domtronn opened this issue Aug 18, 2015 · 2 comments

Comments

@domtronn
Copy link

Hi, I was using grunt-release with a beforeBump task to run the tests of my project before a release, but when these tasks error, the deferred.reject doesn't get caught or exit correctly, so regardless of the grunt status, the release continues.

Here's an example of the gruntfile.js

grunt.initConfig({
    // Task configuration.
    release:  {
        options: {
            beforeBump: ['test']
        }
    }
});

So when I run

grunt release

It runs the tests, but if they fail, it just continues with the release.

Is there a reason why we don't just call grunt.fail.warn here? Because this will exit the task immediately...

@jalet
Copy link

jalet commented Sep 15, 2015

I too want to run my tests pre release/bump and exit on failure, any updates regarding this?

@drublic
Copy link
Collaborator

drublic commented Oct 2, 2015

Thanks for the report. Makes total sense not to continue any further. Will have a look at implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants