-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker and guide: Update to Godot 4.3 #53
Comments
Claiming:
Edit: I'm not sure I'll have time to get to these, so if everything else is already done feel free to claim these as well |
Claiming:
EDIT: seems like the Demo3DEnvironment was fixed already. |
Claiming:
|
Claiming:
|
Claiming:
|
I don't have time to investigate right now, but I'd consider removing or replacing the toon shader currently included. The current shader uses viewports and has a visible frame of lag in the editor. In 4.x, there are approaches that work entirely within the shader and shader includes, without the need for viewports or a setup script in the scene. One example of a cel shader that works without viewports is https://godotshaders.com/shader/complete-cel-shader-for-godot-4/ (https://github.com/eldskald/godot4-cel-shader), there are probably others and perhaps one has a compatible license and a creator who wants it included in this repo. |
The water shader can also use some improvements, but that one is much more suited to being upgraded in place. I'm willing and able to make the water shader changes. |
Claiming stylized_fire - #63 |
claiming stylized_liquid -> also finished at #65 |
@tetrapod00 I had missed your suggestion about the advanced toon shader. It is an example of emulating deferred rendering in Godot. This approach is used to capture different light information in separate rendering channels (texture channels) to control the effect of various lights on different models at the material level. The shader can be adapted to work with forward rendering as much of the logic is just common rendering techniques: anisotropy, metallic, etc. I'm not sure how useful keeping an example of deferred rendering in Godot is, as it's partly working against the engine. Does someone have a lot of experience with forward vs deferred rendering and why you'd want to learn to emulate the latter? As we're doing this not only with aesthetics but also learning in mind, if there's no strong educational reason to learn how to do this in Godot, we can simplify the scene setup. |
I personally would not expect an example on how to emulate deferred rendering from this set of example shaders. Like you said, it's slightly working against the engine. I might expect some example of how to render out to a "custom buffer" for use in postprocessing effects, using a technique something like https://github.com/thompsop1sou/custom-screen-buffers. If there is such an example, ideally it would be separated from the toon shader example, since a good toon shader is possible without emulating deferred or using viewports. I still haven't looked closer at the existing toon shader though. |
This issue focuses on porting the Godot Shaders repository from Godot 3 to Godot 4.3. The repository contains a collection of shaders and demo scenes for 2D and 3D games. The goal is to update the shaders and demo scenes to work with Godot 4.3, so that people can use them in their projects.
How to contribute
I saved a copy of the current shaders for Godot 3 in a branch. We can work directly on the
main
branch to port the project to Godot 4.3. Here's how you can help.Every file needs to be checked and compared against the Godot 3 version to make sure it works correctly in Godot 4.3. The scenes, shaders, and GDScript files generally need to be updated to use the new features and syntax of the engine.
Below you will find a list of files that have not been updated yet. I will update the ones left to do as new files get updated and work in Godot 4.3.
Claiming files to update
If you want to help, please:
I'll update the list periodically as you claim some. This is to avoid having multiple people updating the same files in parallel.
Updating the files
To update the files, you'll need to:
Here's a video running through the process of tracing where a shader is used and making some quick adjustments to it: Godot 4.3: How to update shaders.
Shaders and dependencies to update
Each checkbox represents a shader. If it's unchecked, it means that this shader and its dependencies haven't been updated yet. If a shader is claimed, you'll find the nickname next to the checkbox.
If you want to work on some shaders, please write a comment below listing the files you'll update.
Note: Be sure to check comments below for files others have claimed. I will not be able to update the list in real-time, so please coordinate with others to avoid working on the same files.
Other tasks:
The text was updated successfully, but these errors were encountered: