-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the official 2D Platformer demo #57
Comments
Great plan! A little extra: as Godot 3.2 is coming out soon, could you port it to Godot 3.2? The 2d part is already quite stable, even using the official alphas. |
Cheers! That's a good idea. I'll also port it to 3.2 👍 |
As the character is a KinematicBody2D I'd take the opportunity to use the recent move and slide with snap to make it not slide down on slopes. |
So I'm not sure what the scope of this demo is. It seems to me more of a clone type of demo trying to be a somewhat finished project instead of a "feature demo". So because of that I'd say:
|
Let's not increase the scope with UI scenes. We already have a complete demo of our own for that: https://github.com/GDquest/Your-First-Game-Godot-2d-Platformer |
This platformer code rewrite is a prototype to show what our styleguide, comments, etc. can bring to the official demos repo, so people can see the improvements we can bring to the table. |
I didn't think what I'm proposing to be a huge amount of extra work. Maybe menu & death/score is out of scope, but I don't really see a problem in keeping the touch controls. |
The project runs fine on 3.2 Beta1. I think a simple defeat/win overlay would be nice but I'll just refactor what's there without adding anything to tick off the aim. We can always assess after that. |
Will this be merged back into |
Thanks for the heads up! I think we'd like it to be but I'm not sure on the status. @NathanLovato might have more information |
@aaronfranke Yes, we made this as a contribution and proof of concept for a proposal to improve the quality of the official demos. This demo is a +/- complete remake of the platformer. Johnny entirely rewrote the code to make it teach good practices, made a new level... It would replace the original code, leading to no conflicts. We can replicate new features added to the official demo, no problem. We talked about improving and remaking official demos at GodotCon with Rémi and Juan, who approved our idea and plan. We had to get the GDScript styleguide improvements first, and now we're missing a clear design goal for the demos that everyone could follow, and that we could use to improve the overall quality of the repo. This PR is an example of what we intend to contribute, in terms of code quality and educational value. We should probably move it to its own repo for now, so people can see and test it, and open a PR and discussion for the Godot demos repo. Sounds good to you, @johnnygossdev ? |
Sounds good to me! |
The 2D Platformer is the first demo to be reworked into the Best Practices guidelines as discussed in #56.
The work-in-progress project can be found on the
feature/demo-platformer-2d
branch.I've made some notes of the changes I'd like to implement. Feedback is welcome!
General
Player
jumping_weapon
andfalling_weapon
animationsEnemies
Moving Platforms
Use Path2D for movement?(Doesn't behave well withsync_to_physics
)Bugs
_phyisics_process
?)The text was updated successfully, but these errors were encountered: