From 56282d10ca0fe30cd8edce2f6e9b79c0b402da05 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Thu, 15 Feb 2024 22:47:49 +0900 Subject: [PATCH 01/13] feat: add protobuf files --- proto/atriculation.proto | 30 ++++++++++++++++++++++++++++++ proto/history.proto | 28 ++++++++++++++++++++++++++++ proto/pronunciation.proto | 35 +++++++++++++++++++++++++++++++++++ proto/situation.proto | 31 +++++++++++++++++++++++++++++++ 4 files changed, 124 insertions(+) create mode 100644 proto/atriculation.proto create mode 100644 proto/history.proto create mode 100644 proto/pronunciation.proto create mode 100644 proto/situation.proto diff --git a/proto/atriculation.proto b/proto/atriculation.proto new file mode 100644 index 0000000..2e193df --- /dev/null +++ b/proto/atriculation.proto @@ -0,0 +1,30 @@ +syntax = "proto3"; + +package proto; + +// information for articulation practice +message ContextDTO { + int32 id = 1; + string image_url = 2; +} + +message GetContextRequest { + int32 id = 1; +} + +message GetContextResponse { + ContextDTO context = 1; +} + +message ArticulationFeeback { + int32 context_id = 1; + string overall_feedback = 5; +} + +message GetArticulationFeedbackRequest { + int32 context_id = 1; +} + +message GetArticulationFeedbackResponse { + ArticulationFeeback articulation_feedback = 1; +} \ No newline at end of file diff --git a/proto/history.proto b/proto/history.proto new file mode 100644 index 0000000..6db54a4 --- /dev/null +++ b/proto/history.proto @@ -0,0 +1,28 @@ +syntax = "proto3"; + +package proto; + +import "articulation.proto"; +import "pronunciation.proto"; + +enum HistoryType { + UNKNOWN = 0; + PRONUNCIATION = 1; + ARTICULATION = 2; +} + +message FeebackHistoryDTO { + HistoryType type = 1; + oneof feeback { + PronunciationFeedbackDTO pronunciation = 2; + ArticulationFeedbackDTO articulation = 3; + } +} + +message ListHistoriesRequest { + optional HistoryType type = 1; +} + +message ListHistoriesResponse { + repeated FeebackHistoryDTO histories = 1; +} \ No newline at end of file diff --git a/proto/pronunciation.proto b/proto/pronunciation.proto new file mode 100644 index 0000000..fb3ca0c --- /dev/null +++ b/proto/pronunciation.proto @@ -0,0 +1,35 @@ +syntax = "proto3"; + +package proto; + +// sentence which user has to try to pronounce +message SentenceDTO { + int32 id = 1; + string text = 2; +} + +message GetSetenceRequest { + int32 id = 1; +} + +message GetSetenceResponse { + SentenceDTO sentence = 1; +} + +message PronunciationFeeback { + int32 sentence_id = 1; + repeated int32 incorrect_indexes = 2; + int32 pronunciation_score = 3; + int32 volume_score = 4; + int32 speed_score = 5; + string overall_feedback = 6; +} + +message GetPronunciationFeebackRequest { + int32 sentence_id = 1; + string audio_file_url = 2; +} + +message SubmitPronunciationResponse { + PronunciationFeeback pronunciation_feeback = 1; +} \ No newline at end of file diff --git a/proto/situation.proto b/proto/situation.proto new file mode 100644 index 0000000..f0bc36f --- /dev/null +++ b/proto/situation.proto @@ -0,0 +1,31 @@ +syntax = "proto3"; + +package proto; + +import "articulation.proto"; +import "pronunciation.proto"; + +// situation used to select the theme of the session +message SituationDTO { + int32 id = 1; + string title = 2; + string thumbnail_url = 3; + repeated SentenceDTO sentences = 4; + repeated ContextDTO contexts = 5; +} + +message ListSituationsRequest { + // empty +} + +message ListSituationsResponse { + repeated SituationDTO situations = 1; +} + +message GetSituationRequest { + int32 id = 1; +} + +message GetSituationResponse { + SituationDTO situation = 1; +} \ No newline at end of file From 46cd37e25244cae080170b87e6ac9d47c071bbf5 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Thu, 15 Feb 2024 22:48:59 +0900 Subject: [PATCH 02/13] refactor: add newline --- proto/atriculation.proto | 2 +- proto/history.proto | 2 +- proto/pronunciation.proto | 2 +- proto/situation.proto | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/proto/atriculation.proto b/proto/atriculation.proto index 2e193df..d685a98 100644 --- a/proto/atriculation.proto +++ b/proto/atriculation.proto @@ -27,4 +27,4 @@ message GetArticulationFeedbackRequest { message GetArticulationFeedbackResponse { ArticulationFeeback articulation_feedback = 1; -} \ No newline at end of file +} diff --git a/proto/history.proto b/proto/history.proto index 6db54a4..c9a8b5f 100644 --- a/proto/history.proto +++ b/proto/history.proto @@ -25,4 +25,4 @@ message ListHistoriesRequest { message ListHistoriesResponse { repeated FeebackHistoryDTO histories = 1; -} \ No newline at end of file +} diff --git a/proto/pronunciation.proto b/proto/pronunciation.proto index fb3ca0c..dcbc91a 100644 --- a/proto/pronunciation.proto +++ b/proto/pronunciation.proto @@ -32,4 +32,4 @@ message GetPronunciationFeebackRequest { message SubmitPronunciationResponse { PronunciationFeeback pronunciation_feeback = 1; -} \ No newline at end of file +} diff --git a/proto/situation.proto b/proto/situation.proto index f0bc36f..f71bcbe 100644 --- a/proto/situation.proto +++ b/proto/situation.proto @@ -28,4 +28,4 @@ message GetSituationRequest { message GetSituationResponse { SituationDTO situation = 1; -} \ No newline at end of file +} From 1b62d79a281ddf6a0675ad27a07d87f8634302ac Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Thu, 15 Feb 2024 22:50:43 +0900 Subject: [PATCH 03/13] chore: rename file --- proto/{atriculation.proto => articulation.proto} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename proto/{atriculation.proto => articulation.proto} (100%) diff --git a/proto/atriculation.proto b/proto/articulation.proto similarity index 100% rename from proto/atriculation.proto rename to proto/articulation.proto From 0b39c3e7454f9cacd86e1b4ad45459387c619f0a Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 00:30:25 +0900 Subject: [PATCH 04/13] fix: rename and fix lint --- proto/articulation.proto | 16 ++++++++-------- proto/history.proto | 6 +++--- proto/pronunciation.proto | 4 ++-- proto/situation.proto | 31 ------------------------------- proto/topic.proto | 31 +++++++++++++++++++++++++++++++ 5 files changed, 44 insertions(+), 44 deletions(-) delete mode 100644 proto/situation.proto create mode 100644 proto/topic.proto diff --git a/proto/articulation.proto b/proto/articulation.proto index d685a98..0160883 100644 --- a/proto/articulation.proto +++ b/proto/articulation.proto @@ -3,28 +3,28 @@ syntax = "proto3"; package proto; // information for articulation practice -message ContextDTO { +message SceneDTO { int32 id = 1; string image_url = 2; } -message GetContextRequest { +message GetSceneRequest { int32 id = 1; } -message GetContextResponse { - ContextDTO context = 1; +message GetSceneResponse { + SceneDTO scene = 1; } -message ArticulationFeeback { - int32 context_id = 1; +message ArticulationFeedbackDTO { + int32 scene_id = 1; string overall_feedback = 5; } message GetArticulationFeedbackRequest { - int32 context_id = 1; + int32 scene_id = 1; } message GetArticulationFeedbackResponse { - ArticulationFeeback articulation_feedback = 1; + ArticulationFeedbackDTO articulation_feedback = 1; } diff --git a/proto/history.proto b/proto/history.proto index c9a8b5f..56459dc 100644 --- a/proto/history.proto +++ b/proto/history.proto @@ -6,9 +6,9 @@ import "articulation.proto"; import "pronunciation.proto"; enum HistoryType { - UNKNOWN = 0; - PRONUNCIATION = 1; - ARTICULATION = 2; + HISTORY_TYPE_UNSPECIFIED = 0; + HISTORY_TYPE_PRONUNCIATION = 1; + HISTORY_TYPE_ARTICULATION = 2; } message FeebackHistoryDTO { diff --git a/proto/pronunciation.proto b/proto/pronunciation.proto index dcbc91a..86a21f4 100644 --- a/proto/pronunciation.proto +++ b/proto/pronunciation.proto @@ -16,7 +16,7 @@ message GetSetenceResponse { SentenceDTO sentence = 1; } -message PronunciationFeeback { +message PronunciationFeedbackDTO { int32 sentence_id = 1; repeated int32 incorrect_indexes = 2; int32 pronunciation_score = 3; @@ -31,5 +31,5 @@ message GetPronunciationFeebackRequest { } message SubmitPronunciationResponse { - PronunciationFeeback pronunciation_feeback = 1; + PronunciationFeedbackDTO pronunciation_feeback = 1; } diff --git a/proto/situation.proto b/proto/situation.proto deleted file mode 100644 index f71bcbe..0000000 --- a/proto/situation.proto +++ /dev/null @@ -1,31 +0,0 @@ -syntax = "proto3"; - -package proto; - -import "articulation.proto"; -import "pronunciation.proto"; - -// situation used to select the theme of the session -message SituationDTO { - int32 id = 1; - string title = 2; - string thumbnail_url = 3; - repeated SentenceDTO sentences = 4; - repeated ContextDTO contexts = 5; -} - -message ListSituationsRequest { - // empty -} - -message ListSituationsResponse { - repeated SituationDTO situations = 1; -} - -message GetSituationRequest { - int32 id = 1; -} - -message GetSituationResponse { - SituationDTO situation = 1; -} diff --git a/proto/topic.proto b/proto/topic.proto new file mode 100644 index 0000000..9295e4d --- /dev/null +++ b/proto/topic.proto @@ -0,0 +1,31 @@ +syntax = "proto3"; + +package proto; + +import "articulation.proto"; +import "pronunciation.proto"; + +// topic used to select the theme of the session +message TopicDTO { + int32 id = 1; + string title = 2; + string thumbnail_url = 3; + repeated SentenceDTO sentences = 4; + repeated SceneDTO scenes = 5; +} + +message ListTopicsRequest { + // empty +} + +message ListTopicsResponse { + repeated TopicDTO topics = 1; +} + +message GetTopicRequest { + int32 id = 1; +} + +message GetTopicResponse { + TopicDTO topic = 1; +} From da72737c1189bbcdcb55adf3aed25b65bab64045 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 00:31:50 +0900 Subject: [PATCH 05/13] feat: add error dto --- proto/error.proto | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 proto/error.proto diff --git a/proto/error.proto b/proto/error.proto new file mode 100644 index 0000000..e537f9e --- /dev/null +++ b/proto/error.proto @@ -0,0 +1,8 @@ +syntax = "proto3"; + +package proto; + +message ErrorDTO { + int32 code = 1; + string message = 2; +} \ No newline at end of file From 612cc153b0512b2f8b103f48d9e4b17f6bb87aad Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 00:38:00 +0900 Subject: [PATCH 06/13] fix: lint setup --- .github/workflows/pull-request.yaml | 2 ++ buf.yaml => proto/buf.yaml | 1 + 2 files changed, 3 insertions(+) rename buf.yaml => proto/buf.yaml (72%) diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml index 9375fcb..4466172 100644 --- a/.github/workflows/pull-request.yaml +++ b/.github/workflows/pull-request.yaml @@ -9,3 +9,5 @@ jobs: - uses: actions/checkout@v4 - uses: bufbuild/buf-setup-action@v1 - uses: bufbuild/buf-lint-action@v1 + with: + input: proto diff --git a/buf.yaml b/proto/buf.yaml similarity index 72% rename from buf.yaml rename to proto/buf.yaml index 84d9c3b..3246458 100644 --- a/buf.yaml +++ b/proto/buf.yaml @@ -4,3 +4,4 @@ lint: - DEFAULT except: - PACKAGE_VERSION_SUFFIX + - PACKAGE_DIRECTORY_MATCH From 8f8816e3fb9b1b8fa644fe03799ed7191953b7b6 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 19:42:51 +0900 Subject: [PATCH 07/13] review: rename --- proto/articulation.proto | 30 ------------------- proto/error.proto | 2 +- proto/{pronunciation.proto => feedback.proto} | 30 +++++++++---------- proto/history.proto | 3 +- proto/scene.proto | 18 +++++++++++ proto/sentence.proto | 17 +++++++++++ proto/topic.proto | 7 ++--- proto/user.proto | 6 ---- 8 files changed, 54 insertions(+), 59 deletions(-) delete mode 100644 proto/articulation.proto rename proto/{pronunciation.proto => feedback.proto} (57%) create mode 100644 proto/scene.proto create mode 100644 proto/sentence.proto diff --git a/proto/articulation.proto b/proto/articulation.proto deleted file mode 100644 index 0160883..0000000 --- a/proto/articulation.proto +++ /dev/null @@ -1,30 +0,0 @@ -syntax = "proto3"; - -package proto; - -// information for articulation practice -message SceneDTO { - int32 id = 1; - string image_url = 2; -} - -message GetSceneRequest { - int32 id = 1; -} - -message GetSceneResponse { - SceneDTO scene = 1; -} - -message ArticulationFeedbackDTO { - int32 scene_id = 1; - string overall_feedback = 5; -} - -message GetArticulationFeedbackRequest { - int32 scene_id = 1; -} - -message GetArticulationFeedbackResponse { - ArticulationFeedbackDTO articulation_feedback = 1; -} diff --git a/proto/error.proto b/proto/error.proto index e537f9e..ce89b05 100644 --- a/proto/error.proto +++ b/proto/error.proto @@ -5,4 +5,4 @@ package proto; message ErrorDTO { int32 code = 1; string message = 2; -} \ No newline at end of file +} diff --git a/proto/pronunciation.proto b/proto/feedback.proto similarity index 57% rename from proto/pronunciation.proto rename to proto/feedback.proto index 86a21f4..588afac 100644 --- a/proto/pronunciation.proto +++ b/proto/feedback.proto @@ -2,20 +2,6 @@ syntax = "proto3"; package proto; -// sentence which user has to try to pronounce -message SentenceDTO { - int32 id = 1; - string text = 2; -} - -message GetSetenceRequest { - int32 id = 1; -} - -message GetSetenceResponse { - SentenceDTO sentence = 1; -} - message PronunciationFeedbackDTO { int32 sentence_id = 1; repeated int32 incorrect_indexes = 2; @@ -30,6 +16,20 @@ message GetPronunciationFeebackRequest { string audio_file_url = 2; } -message SubmitPronunciationResponse { +message GetPronunciationResponse { PronunciationFeedbackDTO pronunciation_feeback = 1; } + +message CommunicationFeedbackDTO { + int32 scene_id = 1; + string overall_feedback = 5; +} + +message GetCommunicationFeedbackRequest { + int32 scene_id = 1; + string audio_file_url = 2; +} + +message GetCommunicationFeedbackResponse { + CommunicationFeedbackDTO communication_feedback = 1; +} diff --git a/proto/history.proto b/proto/history.proto index 56459dc..2d2c6db 100644 --- a/proto/history.proto +++ b/proto/history.proto @@ -2,8 +2,7 @@ syntax = "proto3"; package proto; -import "articulation.proto"; -import "pronunciation.proto"; +import "feedback.proto"; enum HistoryType { HISTORY_TYPE_UNSPECIFIED = 0; diff --git a/proto/scene.proto b/proto/scene.proto new file mode 100644 index 0000000..0ee0d0c --- /dev/null +++ b/proto/scene.proto @@ -0,0 +1,18 @@ +syntax = "proto3"; + +package proto; + +// information for sentence formation practice +message SceneDTO { + int32 id = 1; + string image_url = 2; + string question = 3; +} + +message GetSceneRequest { + int32 id = 1; +} + +message GetSceneResponse { + SceneDTO scene = 1; +} diff --git a/proto/sentence.proto b/proto/sentence.proto new file mode 100644 index 0000000..0bae06c --- /dev/null +++ b/proto/sentence.proto @@ -0,0 +1,17 @@ +syntax = "proto3"; + +package proto; + +// sentence which user has to try to pronounce +message SentenceDTO { + int32 id = 1; + string text = 2; +} + +message GetSetenceRequest { + int32 id = 1; +} + +message GetSetenceResponse { + SentenceDTO sentence = 1; +} diff --git a/proto/topic.proto b/proto/topic.proto index 9295e4d..63f4406 100644 --- a/proto/topic.proto +++ b/proto/topic.proto @@ -2,16 +2,13 @@ syntax = "proto3"; package proto; -import "articulation.proto"; -import "pronunciation.proto"; - // topic used to select the theme of the session message TopicDTO { int32 id = 1; string title = 2; string thumbnail_url = 3; - repeated SentenceDTO sentences = 4; - repeated SceneDTO scenes = 5; + repeated string sentence_ids = 4; + repeated string scene_ids = 5; } message ListTopicsRequest { diff --git a/proto/user.proto b/proto/user.proto index 0bf0ce5..a5ef48f 100644 --- a/proto/user.proto +++ b/proto/user.proto @@ -6,11 +6,6 @@ message UserDTO { string id = 1; string name = 2; int32 age = 3; - DisorderType disorder_type = 4; -} - -enum DisorderType { - DISORDER_TYPE_UNSPECIFIED = 0; } message GetUserRequest { @@ -25,7 +20,6 @@ message UpdateUserRequest { string id = 1; optional string name = 2; optional int32 age = 3; - DisorderType disorder_type = 4; } message UpdateUserResponse { From e24ffadc4165246e1e6c69d3524e0c7f43b72c1d Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 19:48:15 +0900 Subject: [PATCH 08/13] fix: build error --- proto/history.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/history.proto b/proto/history.proto index 2d2c6db..fef4399 100644 --- a/proto/history.proto +++ b/proto/history.proto @@ -7,14 +7,14 @@ import "feedback.proto"; enum HistoryType { HISTORY_TYPE_UNSPECIFIED = 0; HISTORY_TYPE_PRONUNCIATION = 1; - HISTORY_TYPE_ARTICULATION = 2; + HISTORY_TYPE_COMMUNICATION = 2; } message FeebackHistoryDTO { HistoryType type = 1; oneof feeback { PronunciationFeedbackDTO pronunciation = 2; - ArticulationFeedbackDTO articulation = 3; + CommunicationFeedbackDTO communication = 3; } } From ac0c7dc6b95a14ad1d65ee43af44772396e508b8 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 19:50:04 +0900 Subject: [PATCH 09/13] fix: string to int --- proto/topic.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/topic.proto b/proto/topic.proto index 63f4406..44a5f9a 100644 --- a/proto/topic.proto +++ b/proto/topic.proto @@ -7,8 +7,8 @@ message TopicDTO { int32 id = 1; string title = 2; string thumbnail_url = 3; - repeated string sentence_ids = 4; - repeated string scene_ids = 5; + repeated int32 sentence_ids = 4; + repeated int32 scene_ids = 5; } message ListTopicsRequest { From 7d682c2238eea9cad4a0ca821924b40f86d6e3de Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sat, 17 Feb 2024 20:55:33 +0900 Subject: [PATCH 10/13] feat: id to string --- proto/feedback.proto | 8 ++++---- proto/scene.proto | 4 ++-- proto/sentence.proto | 4 ++-- proto/topic.proto | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/proto/feedback.proto b/proto/feedback.proto index 588afac..1125194 100644 --- a/proto/feedback.proto +++ b/proto/feedback.proto @@ -3,7 +3,7 @@ syntax = "proto3"; package proto; message PronunciationFeedbackDTO { - int32 sentence_id = 1; + string sentence_id = 1; repeated int32 incorrect_indexes = 2; int32 pronunciation_score = 3; int32 volume_score = 4; @@ -12,7 +12,7 @@ message PronunciationFeedbackDTO { } message GetPronunciationFeebackRequest { - int32 sentence_id = 1; + string sentence_id = 1; string audio_file_url = 2; } @@ -21,12 +21,12 @@ message GetPronunciationResponse { } message CommunicationFeedbackDTO { - int32 scene_id = 1; + string scene_id = 1; string overall_feedback = 5; } message GetCommunicationFeedbackRequest { - int32 scene_id = 1; + string scene_id = 1; string audio_file_url = 2; } diff --git a/proto/scene.proto b/proto/scene.proto index 0ee0d0c..9925ce1 100644 --- a/proto/scene.proto +++ b/proto/scene.proto @@ -4,13 +4,13 @@ package proto; // information for sentence formation practice message SceneDTO { - int32 id = 1; + string id = 1; string image_url = 2; string question = 3; } message GetSceneRequest { - int32 id = 1; + string id = 1; } message GetSceneResponse { diff --git a/proto/sentence.proto b/proto/sentence.proto index 0bae06c..e18811d 100644 --- a/proto/sentence.proto +++ b/proto/sentence.proto @@ -4,12 +4,12 @@ package proto; // sentence which user has to try to pronounce message SentenceDTO { - int32 id = 1; + string id = 1; string text = 2; } message GetSetenceRequest { - int32 id = 1; + string id = 1; } message GetSetenceResponse { diff --git a/proto/topic.proto b/proto/topic.proto index 44a5f9a..9600bc0 100644 --- a/proto/topic.proto +++ b/proto/topic.proto @@ -4,11 +4,11 @@ package proto; // topic used to select the theme of the session message TopicDTO { - int32 id = 1; + string id = 1; string title = 2; string thumbnail_url = 3; - repeated int32 sentence_ids = 4; - repeated int32 scene_ids = 5; + repeated string sentence_ids = 4; + repeated string scene_ids = 5; } message ListTopicsRequest { @@ -20,7 +20,7 @@ message ListTopicsResponse { } message GetTopicRequest { - int32 id = 1; + string id = 1; } message GetTopicResponse { From 99621e7dfa2aa7ca10be3815cb9dcf02391986b1 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sun, 18 Feb 2024 13:36:38 +0900 Subject: [PATCH 11/13] feat: add compact topic dto --- proto/topic.proto | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/proto/topic.proto b/proto/topic.proto index 9600bc0..cc029ae 100644 --- a/proto/topic.proto +++ b/proto/topic.proto @@ -11,12 +11,18 @@ message TopicDTO { repeated string scene_ids = 5; } +message CompactTopicDTO { + string id = 1; + string title = 2; + string thumbnail_url = 3; +} + message ListTopicsRequest { // empty } message ListTopicsResponse { - repeated TopicDTO topics = 1; + repeated CompactTopicDTO topics = 1; } message GetTopicRequest { From 7cbb1eb898e16ad010fe4e90f89e207bb5ae7e19 Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sun, 18 Feb 2024 13:57:54 +0900 Subject: [PATCH 12/13] Update proto/feedback.proto Co-authored-by: namoo (Ian) --- proto/feedback.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/feedback.proto b/proto/feedback.proto index 1125194..7ad7c11 100644 --- a/proto/feedback.proto +++ b/proto/feedback.proto @@ -11,12 +11,12 @@ message PronunciationFeedbackDTO { string overall_feedback = 6; } -message GetPronunciationFeebackRequest { +message GetPronunciationFeedbackRequest { string sentence_id = 1; string audio_file_url = 2; } -message GetPronunciationResponse { +message GetPronunciationFeedbackResponse { PronunciationFeedbackDTO pronunciation_feeback = 1; } From 283feb97ca151514c7933802127e7d6f68801a4c Mon Sep 17 00:00:00 2001 From: Jason Yoo Date: Sun, 18 Feb 2024 13:59:12 +0900 Subject: [PATCH 13/13] fix: reserved number --- proto/feedback.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proto/feedback.proto b/proto/feedback.proto index 7ad7c11..2a55802 100644 --- a/proto/feedback.proto +++ b/proto/feedback.proto @@ -22,7 +22,7 @@ message GetPronunciationFeedbackResponse { message CommunicationFeedbackDTO { string scene_id = 1; - string overall_feedback = 5; + string overall_feedback = 2; } message GetCommunicationFeedbackRequest {