-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove-tab-key-access-to-home-logo #27
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if we add the CSS to hide the logo into the adminSelectorsCSS, ownerSelectorsCSS, and memberSelectorsCSS. This way we don't hardcode anything and if we need to make a change it's simple to update instead of having to rebuild and redeploy the extension.
Ok. I understand that you recommend to maintain the use of property to hide and remove elements instead of hard coding it. I will change it and test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix cannot be apply to all site. Only to our main site. Community should not be impacted by this.
@Steph4104 @doug0102 Do you think any workaround for this? |
Yes, I know the wall extension is apply to all site. But the fix you try to do should only apply to our main site. Not the user communities. I don't think the wall extension is the right place to apply this fix. Currently, if you look at communities in PROD, logo icon is not hide |
ok. I will think if I can do any workaround for this. |
Maybe we could add another property to the extension that lets us specify a site ID and CSS that should only apply to that site. Something like Or we just hardcode it for our site assuming it never changes and we don't think we will need to do targeted CSS for any other sites. |
I am trying to prevent the hiding just for teams site. Lets see. |
@Steph4104 |
home logo link removed for all the users to eliminate tab key access to hidden home link in prod