-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUETools: EAC log file encoding not always preserved #330
Comments
The |
Sorry, forgot to check #51 before posting. Do you perhaps know the reason for changing the encoding of (checksum-less) log files? I know it's not terribly important, but I've just always preferred to keep my logs "unaltered". |
Thanks for the additional info and posting the example log file, which contains localized
The original request primarily concerned log files with checksum. |
Well, if you decide to preserve the encoding only for logs with checksums, this would probably work as a quick temporary fix:
|
Yes, this will be fixed. |
EAC log files are encoded using UTF-16LE since version 1.0 beta 1. Since gchudov#51 (commit 9f80400) this encoding is preserved in case of EAC log files, which contain a log checksum. However, only English log files have been supported so far. - Also preserve the encoding of EAC log files in different languages, if they contain a log checksum. - Resolves gchudov#330
@ffwema A build with a fix has been prepared in #331, which also preserves the encoding of localized EAC logfiles, which contain a log checksum, like in example log file with checksum. |
A tiny bug: when encoding with CUETools, the EAC log encoding is not always preserved (the problem was partially solved in version 2.1.8). This example log file (apologies for the .txt extension but for some reason the GitHub does not allow me to upload files with .log extension) is UTF-16 LE BOM encoded, however the CUETools converts it to UTF-8-BOM.
EAC encodes logs as:
The text was updated successfully, but these errors were encountered: