-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with HA 0.82.0 - invalid service data/breaks (newUI) #51
Comments
Do you have 1.04? |
In 1.04 those lines don't seem to exist. Instead, similar lines are present: self._hass.services.call("switch", "turn_off", {self._alarm}) |
This is branch "newUI", much more recent than 1.04. I downloaded the code just 3 days ago, it's v1.1.2 as you can see currently here: |
I have noticed that MANY of the files uploaded have extraneous spaces and tabs, one of them had windows line endings instead of linux. After cleaning everything up and replacing all tabs and indents with two spaces it cleaned up A LOT of problems with the function in .82. I am still finding issues with CSS ordering and everything in mine causing some UI oddities on strange sized displays like the 7" Raspberry pi. I may try to put in a merge request eventually unless gazoscalvertos is going to commit updates soon. I noticed quite a few broken features and would love to clean up and contribute to the latest! |
@brillb ah, I see. I wasn't even aware of that branch. |
Describe the bug
Unable to use on HA 0.82.0, and likely other 0.80+ versions
To Reproduce
Steps to reproduce the behavior:
Install on 0.82.0
Expected behavior
Panel appears, activates/deactivates
Screenshots
fixed by changing to:
at all locations which were previously:
Fix in the attached Diff from bwalarm.py v1.1.2:
bwalarm-diff1.txt
also diff for alarms.html (missing two break statements)
alarmshtml-diff1.txt
The text was updated successfully, but these errors were encountered: