From 8a21ad9a95ceda14087ee78308965eb8de0abc5b Mon Sep 17 00:00:00 2001 From: "Addisu Z. Taddese" Date: Tue, 10 Sep 2024 00:41:40 -0500 Subject: [PATCH 1/2] Fix log playback GUI display Loading the logging playback plugin before `SceneBroadcaster` prevents playback from being displayed on the GUI. Signed-off-by: Addisu Z. Taddese --- src/SimulationRunner.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/SimulationRunner.cc b/src/SimulationRunner.cc index 268e956cda..141b22f376 100644 --- a/src/SimulationRunner.cc +++ b/src/SimulationRunner.cc @@ -1596,8 +1596,6 @@ void SimulationRunner::CreateEntities(const sdf::World &_world) this->entityCompMgr.ProcessRemoveEntityRequests(); this->entityCompMgr.ClearRemovedComponents(); - this->LoadLoggingPlugins(this->serverConfig); - // Load any additional plugins from the Server Configuration this->LoadServerPlugins(this->serverConfig.Plugins()); @@ -1653,6 +1651,8 @@ void SimulationRunner::CreateEntities(const sdf::World &_world) } this->LoadServerPlugins(defaultPlugins); + this->LoadLoggingPlugins(this->serverConfig); + }; // Store the initial state of the ECM; From dad1d9f18eb8917bb30c6a193a0c6ea973475926 Mon Sep 17 00:00:00 2001 From: "Addisu Z. Taddese" Date: Thu, 12 Sep 2024 14:42:59 -0500 Subject: [PATCH 2/2] Add comment about loading logging plugins Signed-off-by: Addisu Z. Taddese --- src/SimulationRunner.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/SimulationRunner.cc b/src/SimulationRunner.cc index 141b22f376..baa2712adc 100644 --- a/src/SimulationRunner.cc +++ b/src/SimulationRunner.cc @@ -1651,6 +1651,9 @@ void SimulationRunner::CreateEntities(const sdf::World &_world) } this->LoadServerPlugins(defaultPlugins); + // Load logging plugins after all server plugins so that necessary + // plugins such as SceneBroadcaster are loaded first. This might be + // a bug or an assumption made in the logging plugins. this->LoadLoggingPlugins(this->serverConfig); };