gz::common:moveFile() does not work accross different partitions

[jrutgeer]

Environment

• Ubuntu 22.04
• Garden, source built

Description

gz::common:moveFile() calls std::filesystem::rename(), which fails with error generic:18 Invalid cross-device link if the source and destination folder are on different partitions.

Steps to reproduce

E.g. with /home and / mounted on different partitions:

• Go to home folder,
• Start a simulation, e.g. gz sim lights.sdf,
• Load the video recorder plugin and record a video,
• Save the video to some folder not on the home partition, e.g. to /tmp
• This yields following error message:

[GUI] [Wrn] [Filesystem.cc:50] Failed common::moveFile (ec: generic:18 Invalid cross-device link)
[GUI] [Err] [VideoRecorder.cc:380] Unable to rename file from[ign_recording.mp4] to [/tmp/aaa.mp4]

• Do the same steps but start the simulation and save on the same partition --> works correctly.

Possible fix

I found this similar report (though boost rather than std), which proposes to copy + delete original if succesful.

[mjcarroll]

Interesting, good catch. Would you be interested in doing a PR with the proposed workaround (copy+delete)

[jrutgeer]

good catch.

Well, I did not catch it, I experienced it... ;-)

While I generally try to contribute (e.g. fix, new functionality, system plugin), I cannot commit time for this one unfortunately.