Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsl_vertical_alignment example takes seconds to render each update #364

Open
dymk opened this issue Feb 20, 2016 · 3 comments
Open

dsl_vertical_alignment example takes seconds to render each update #364

dymk opened this issue Feb 20, 2016 · 3 comments
Labels
performance question

Comments

@dymk
Copy link

dymk commented Feb 20, 2016

Tested with:

Vedeu 0.8.16
OSX 10.11.3
iTerm 2 (v3 Beta) and Terminal.app

This is a pretty bad performance bug, running the dsl_vertical_alignment.rb is horrendously slow (each refresh takes ~4 seconds), when pressing one of 'hjkl' to move around the middle square. Is there any low hanging fruit here to pluck?
@gavinlaking
Copy link
Owner

The biggest cost is the fact that both dsl_vertical_alignment.rb and dsl_horizontal_alignment.rb use multiple renderers. I disabled the text renderer which writes to the filesystem (Vedeu::Renderers::Text) and my refresh time is reduced to a still unacceptable 350ms. Ideally, I'd like to get this down to 60fps (16.67ms), so there is work to be done.

Pull requests are always welcome, but in their absence, patience is appreciated :-D

Gav

gavinlaking added a commit that referenced this issue Feb 22, 2016
@gavinlaking
Comment out 'text' renderer to speed up these examples;
e63c945 
This masks an underlying problem- Vedeu is too slow! But work is underway to alleviate this
problem, so in the meantime, make these examples as quick as can be.

Work relating to #364.
@gavinlaking
Copy link
Owner

Refresh time for me is between 250ms and 300ms now, still a fair way to go to reach ~16ms.

gavinlaking added a commit that referenced this issue May 7, 2016
@gavinlaking
Reduce duplication;
7f830bf 
Work relating to #364.
gavinlaking added a commit that referenced this issue May 21, 2016
@gavinlaking
Remove 'position' attribute;
612eb37 
Removing the position attribute from the Cells::Clear instances reduces
work for the Output::Compressor leading to dramatic performance
improvements.

Work relating to #364. - Refresh time for me is between 150ms and 200ms now.
gavinlaking added a commit that referenced this issue May 21, 2016
@gavinlaking
Remove additional Array instantiation for each line being cleared;
397b648 
Work relating to #364.
@gavinlaking
Copy link
Owner

Refresh time for me is between 150ms and 200ms as of 612eb37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinlaking @dymk