Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE10 - page scrolled down immediately on load #20582

Closed
andrejpavlovic opened this issue Jan 13, 2020 · 4 comments
Closed

IE10 - page scrolled down immediately on load #20582

andrejpavlovic opened this issue Jan 13, 2020 · 4 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@andrejpavlovic
Copy link

andrejpavlovic commented Jan 13, 2020

Description

When opening any gatsby page in IE10, the page is immediately scrolled down by a couple of hundred pixels (varies by screen size).

Steps to reproduce

Using IE10, go to https://www.gatsbyjs.org/ for example.

Expected result

Once page loads and hydrates, it should stay at the top (not scrolled down)

Actual result

The page is scrolled down.

Environment

Gatsby 2.15.9

Details

After some digging around and going through past releases, looks like the regression was introduced by this IE10-specific fix: #13027 (version 2.3.7 and onward)

The call to document.documentElement.doScroll() in https://github.com/mikaelkristiansson/domready/blob/0e1e0fd082cc161b909f809390782e7f70396cc4/src/ready.js#L19 seems to be causing the page to automatically scroll on load

@pieh pieh added type: upstream Issues outside of Gatsby's control, caused by dependencies type: bug An issue or pull request relating to a bug in Gatsby labels Jan 14, 2020
@pieh
Copy link
Contributor

pieh commented Jan 14, 2020

I'll mark this as upstream. Seems like @mikaelkristiansson is already looking into it ( ded/domready#59 (comment) )

@andrejpavlovic
Copy link
Author

andrejpavlovic commented Jan 17, 2020

Issue seems to have been fixed in @mikaelkristiansson/domready v1.0.10
Change: mikaelkristiansson/domready@689caa8

@github-actions
Copy link

github-actions bot commented Feb 7, 2020

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 7, 2020
@sidharthachatterjee
Copy link
Contributor

Looks like this has been fixed upstream (mikaelkristiansson/domready@689caa8) and updated in Gatsby's dependencies as well (#20617)

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

3 participants