improve caching in CI #128
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 82.93% 82.77% -0.16%
==========================================
Files 16 16
Lines 627 627
Branches 38 38
==========================================
- Hits 520 519 -1
Misses 92 92
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. |
.github/workflows/check.yml
Outdated
| if: github.ref == 'refs/heads/master' | ||
| with: | ||
| path: "~/.cache/bazel_disk_cache" | ||
| key: bazel-disk-test-${{ matrix.toolchain }}-${{ matrix.feature }} |
There was a problem hiding this comment.
this will fail to save the cache once it is established
is it work deleting the cache so that it can be updated when commits are merged?
There was a problem hiding this comment.
Do you think there's something low effort that I should do instead?
Next step I think would be to set up buildbuddy, but I don't want to spend the time to do that just yet.
There was a problem hiding this comment.
setting up buildbuddy was very low effort.
< 15 mins would be my guess
There was a problem hiding this comment.
OK, done. That was easier than expected!
garymm
force-pushed
the
garymm/github-cache
branch
from
1368d0a to
7c91f21
Compare
garymm
force-pushed
the
garymm/github-cache
branch
from
7c91f21 to
2501c9f
Compare
use buildbuddy for build cache only write to non-build caches from master, which should save cache space and increase hit rates. Change-Id: I33464f548bd63ae790f328c58be767f48e62568b
garymm
force-pushed
the
garymm/github-cache
branch
from
2501c9f to
6984734
Compare
this save disk space and should help cache hit rates