Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 support #1581

Closed
atomicrobokid opened this issue Aug 30, 2024 · 3 comments · Fixed by #1582
Closed

Node 22 support #1581

atomicrobokid opened this issue Aug 30, 2024 · 3 comments · Fixed by #1582

Comments

@atomicrobokid
Copy link

Engine is restricted to
"node": ">=16.0.0 <=20.x.x",

Any reason why this can't be bumped to include Node 22? I have a project that is node 22 based, and this package throws a warning

@dgrebb
Copy link
Contributor

dgrebb commented Aug 31, 2024

If I remember correctly something in 21 brought a breaking error, but I'll take another look.

@dgrebb
Copy link
Contributor

dgrebb commented Sep 1, 2024

Raised #1582 for this @atomicrobokid @garris.

I have no idea what I was thinking with <=20.x.x. All tests, minus one which I've commented on elsewhere, are passing.

Docker intact as well.

@garris
Copy link
Owner

garris commented Sep 1, 2024

Awesome! Happy to pull in the bump. I'll follow up on the file extension warning in the other thread. I don't mind reverting that if it's causing a stir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants