-
Notifications
You must be signed in to change notification settings - Fork 3
Guard against non-existing iframes in resize. #9
Comments
Issue #9. Guard against non-existing iframes in resize.
Merged, seamed sensible to have a element check. But should we maybe look into if a removal of the iframe could "stop" the plugin-call-chain? |
Yes, that would be a nice enhancement. We still need to check existence of element in |
Next release brings a cleanup and rerender setup https://github.com/gardr/host/blob/master/lib/manager.js#L344 |
Sometimes there are cases when one plugin is removing an iframe and another, called directly after, tries to resize it, which causes errors in
Iframe.resize()
method (trying to get to style property of element that no longer exists).This can be guarded against by wrapping styling in a conditional, something like:
It could also be dealt with in every plugin individually, but I think that would be redundant.
The text was updated successfully, but these errors were encountered: