Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js2 - challenge 3.js missing test for col = 0 #1207

Closed
isam007 opened this issue Dec 20, 2021 · 1 comment
Closed

js2 - challenge 3.js missing test for col = 0 #1207

isam007 opened this issue Dec 20, 2021 · 1 comment
Labels
curriculum lesson content

Comments

@isam007
Copy link
Contributor

isam007 commented Dec 20, 2021

currently this solution to challenge 3 passes all tests and got accepted.
image
However this type of solution shouldn't work if the row > 0, but col = 0! Yet there is no test case to catch that.
image

This challenge needs one more test case where row > 0 and col = 0, for example (solution (3, 0)).
@songz songz added the curriculum lesson content label Dec 21, 2021
@songz
Copy link
Contributor

songz commented Dec 23, 2021

this issue is fixed in this PR into the curriculum repository: garageScript/curriculum#377

@songz songz closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
curriculum lesson content
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@songz @isam007