Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All contributors of the branch gh-gap show up on the front page of the github repository #46

Open
mohamed-barakat opened this issue Oct 21, 2020 · 5 comments · May be fixed by #47
Open

Comments

@mohamed-barakat
Copy link
Member

If the gh-pages are created using PackageMaker then GitHub shows all contributors to the branch gh-gap on the front page of the repository. Here is an example:

https://github.com/homalg-project/CatReps

This list is persistent even after recreating the gh-pages branch from scratch.

I don't think this is desirable

@fingolfin
Copy link
Member

This is not specific to PackageMaker, this is a consequence of using GithubPagesForGAP. And, well, all those people did contribute.... But If it bothers you, you can discard the gh-pages history and start a fresh one, re-importing all files currently in there.

@mohamed-barakat
Copy link
Member Author

I would even like it to see the contributors per branch, especially for the gh-pages branch which plays a different role.

The motivation for writing this issue was that I was really puzzled to see Pedro and Chris on the list of contributors as I forgot about the gh-pages branch and expected this to be a GitHub error (I expect to see you everywhere 😄). Even worse, if one clicks on the contributor's link there is no reference to them anymore and there is no option to change the branch. I expect this to puzzle other people as well since they won't have the gh-pages branch on their minds.

@mohamed-barakat
Copy link
Member Author

... you can discard the gh-pages history and start a fresh one, re-importing all files currently in there.

I did this for the other packages but it is still persistent for CatReps, even though I recreated the gh-pages branch and force-pushed.

The acknowledgment for GitHubPagesForGAP is properly displayed on the bottom left corner here and I am happy with it. By clicking on the link one sees the corresponding list of contributors.

@mohamed-barakat
Copy link
Member Author

I just wanted to draw your attention to this issue and you are free to close it.

@fingolfin
Copy link
Member

It is unclear to me what you are asking for, then. This sounds more like an issue with GitHub than with PackageMaker?

mohamed-barakat added a commit to mohamed-barakat/PackageMaker that referenced this issue Oct 22, 2020
@mohamed-barakat mohamed-barakat linked a pull request Oct 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants