Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rare race condition between merging a PR and "Scan for updates" workflow #677

Open
fingolfin opened this issue Dec 21, 2022 · 0 comments
Open

Comments

@fingolfin
Copy link
Member

Last night I merged PR #673. But when I merged it, the "Scan for updates" workflow was already running, and promptly produced PR #673.

I think what happened is roughly this:

  1. the workflow got started per its schedule, at the then current commit a320275
  2. while it was running, I merged PR [profiling] Update to 2.5.2 #673.
  3. the workflow proceeds and determines that profiling was updated compared to a320275
  4. so a new PR was opened (because no open PR for profiling existed at this point, as I had already merged it.

I am not sure how to prevent this or if it is even possible. But we certainly can lower the probability of this happening: e.g. just before opening the PR the workflow could perform a git pull` and abort if there are no changes afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant