Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated closing of "redundant" automatic PRs #239

Open
fingolfin opened this issue Mar 29, 2022 · 1 comment
Open

Automated closing of "redundant" automatic PRs #239

fingolfin opened this issue Mar 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@fingolfin
Copy link
Member

Sometimes an automatic PR becomes redundant because the changes in it are merge in some other way. E.g. today CAP and linearalgebraforcap were updated and this created PRs #229 and #230 but the two package updates need each other, so they failed -- hence I made PR #231 to update them in one go.

After that was merged, I manually closed the two PRs -- but due to bad timings, my merge overlapped with a "scan for updates", so two new PRs (#236 and #237) were opened for the two packages -- even though the changes were basically already in main. I had to close them again. Which is mostly fine, but it would be good if some cron job (e.g. scan-for-updates.yml) could perhaps also look for open but redundant PRs (i.e. PRs whose branch, when rebased on main, has zero changes left), and closes them automatically.

Then again, this is not that frequent, so perhaps we can ignore it...

@fingolfin fingolfin added the enhancement New feature or request label Mar 29, 2022
@fingolfin
Copy link
Member Author

https://github.com/peter-evans/close-pull may be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant