-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
details of transformer code #9
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for your work, I have a question about sequence embedding. The screenshot is from transformer.py
When you get sequence embedding, the position embedding has already been added to sequence embedding as fllows:
Why do you input the same position embedding into decoder layer ? After this operation, position embedding is added to sequence embedding twice.
The text was updated successfully, but these errors were encountered: